mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support
@ 2026-02-06 11:22 Biju
  2026-02-23 17:12 ` Rob Herring (Arm)
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Biju @ 2026-02-06 11:22 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
	Magnus Damm
  Cc: Biju Das, linux-watchdog, devicetree, linux-kernel,
	linux-renesas-soc, Prabhakar Mahadev Lad, Biju Das

From: Biju Das <biju.das.jz@bp.renesas.com>

Document the support for the watchdog IP available on RZ/G3L SoC. The
watchdog IP available on RZ/G3L SoC is identical to the one found on
RZ/G2L SoC.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 .../devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml          | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
index a4d06c9c8b86..40b4fb26d9c5 100644
--- a/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
@@ -18,6 +18,7 @@ properties:
               - renesas,r9a07g044-wdt    # RZ/G2{L,LC}
               - renesas,r9a07g054-wdt    # RZ/V2L
               - renesas,r9a08g045-wdt    # RZ/G3S
+              - renesas,r9a08g046-wdt    # RZ/G3L
           - const: renesas,rzg2l-wdt
 
       - items:
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support
  2026-02-06 11:22 [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support Biju
@ 2026-02-23 17:12 ` Rob Herring (Arm)
  2026-05-05  6:04 ` Biju Das
  2026-05-05  7:31 ` Geert Uytterhoeven
  2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring (Arm) @ 2026-02-23 17:12 UTC (permalink / raw)
  To: Biju
  Cc: Biju Das, Geert Uytterhoeven, devicetree, Krzysztof Kozlowski,
	linux-renesas-soc, linux-kernel, Prabhakar Mahadev Lad,
	Guenter Roeck, Magnus Damm, Conor Dooley, Wim Van Sebroeck,
	linux-watchdog


On Fri, 06 Feb 2026 11:22:25 +0000, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Document the support for the watchdog IP available on RZ/G3L SoC. The
> watchdog IP available on RZ/G3L SoC is identical to the one found on
> RZ/G2L SoC.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  .../devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml          | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support
  2026-02-06 11:22 [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support Biju
  2026-02-23 17:12 ` Rob Herring (Arm)
@ 2026-05-05  6:04 ` Biju Das
  2026-05-05  7:31 ` Geert Uytterhoeven
  2 siblings, 0 replies; 5+ messages in thread
From: Biju Das @ 2026-05-05  6:04 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Geert Uytterhoeven
  Cc: linux-watchdog, devicetree, linux-kernel, linux-renesas-soc,
	Prabhakar Mahadev Lad, biju.das.au, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, magnus.damm, biju.das.au

Hi Wim/Guenter/Geert,

> -----Original Message-----
> From: Biju <biju.das.au@gmail.com>
> Sent: 06 February 2026 11:22
> Subject: [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support
> 
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Document the support for the watchdog IP available on RZ/G3L SoC. The watchdog IP available on RZ/G3L
> SoC is identical to the one found on RZ/G2L SoC.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  .../devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml          | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
> b/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
> index a4d06c9c8b86..40b4fb26d9c5 100644
> --- a/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
> @@ -18,6 +18,7 @@ properties:
>                - renesas,r9a07g044-wdt    # RZ/G2{L,LC}
>                - renesas,r9a07g054-wdt    # RZ/V2L
>                - renesas,r9a08g045-wdt    # RZ/G3S
> +              - renesas,r9a08g046-wdt    # RZ/G3L
>            - const: renesas,rzg2l-wdt
> 
>        - items:
> --
> 2.43.0

Gentle ping.

Cheers,
Biju


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support
  2026-02-06 11:22 [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support Biju
  2026-02-23 17:12 ` Rob Herring (Arm)
  2026-05-05  6:04 ` Biju Das
@ 2026-05-05  7:31 ` Geert Uytterhoeven
  2026-05-05  8:06   ` Biju Das
  2 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2026-05-05  7:31 UTC (permalink / raw)
  To: Biju
  Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
	Magnus Damm, Biju Das, linux-watchdog, devicetree, linux-kernel,
	linux-renesas-soc, Prabhakar Mahadev Lad

Hi Biju,

On Fri, 6 Feb 2026 at 12:22, Biju <biju.das.au@gmail.com> wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Document the support for the watchdog IP available on RZ/G3L SoC. The
> watchdog IP available on RZ/G3L SoC is identical to the one found on
> RZ/G2L SoC.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
> @@ -18,6 +18,7 @@ properties:
>                - renesas,r9a07g044-wdt    # RZ/G2{L,LC}
>                - renesas,r9a07g054-wdt    # RZ/V2L
>                - renesas,r9a08g045-wdt    # RZ/G3S
> +              - renesas,r9a08g046-wdt    # RZ/G3L
>            - const: renesas,rzg2l-wdt
>
>        - items:

However, there seems to be a small difference in the formulas for the
timeout register value on the various SoCs:

RZ/G2L, RZ/G2UL, and RZ/V2L:

    WDTTIME setting value = \frac{WDT cycle}{(WDTn_CLK (n = 0,1,2)
cycle × 1024 × 1024) − 1}

RZ/G3S and RZ/G3E:

    WDTTIME setting value = \frac{WDT cycle}{(WDTn_CLK (n = 0,1,2)
cycle × 1024 × 1024} − 1

I.e. on the former, the "- 1" offset is inside the denominator, while
on the former, it is outside the fraction.  I assume this is just a typo
in the documentation, and both formulas are supposed to be identical, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support
  2026-05-05  7:31 ` Geert Uytterhoeven
@ 2026-05-05  8:06   ` Biju Das
  0 siblings, 0 replies; 5+ messages in thread
From: Biju Das @ 2026-05-05  8:06 UTC (permalink / raw)
  To: geert, biju.das.au
  Cc: Wim Van Sebroeck, Guenter Roeck, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven,
	magnus.damm, linux-watchdog, devicetree, linux-kernel,
	linux-renesas-soc, Prabhakar Mahadev Lad

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 05 May 2026 08:32
> Subject: Re: [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support
> 
> Hi Biju,
> 
> On Fri, 6 Feb 2026 at 12:22, Biju <biju.das.au@gmail.com> wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Document the support for the watchdog IP available on RZ/G3L SoC. The
> > watchdog IP available on RZ/G3L SoC is identical to the one found on
> > RZ/G2L SoC.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > ---
> > a/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/renesas,rzg2l-wdt.yam
> > +++ l
> > @@ -18,6 +18,7 @@ properties:
> >                - renesas,r9a07g044-wdt    # RZ/G2{L,LC}
> >                - renesas,r9a07g054-wdt    # RZ/V2L
> >                - renesas,r9a08g045-wdt    # RZ/G3S
> > +              - renesas,r9a08g046-wdt    # RZ/G3L
> >            - const: renesas,rzg2l-wdt
> >
> >        - items:
> 
> However, there seems to be a small difference in the formulas for the timeout register value on the
> various SoCs:
> 
> RZ/G2L, RZ/G2UL, and RZ/V2L:
> 
>     WDTTIME setting value = \frac{WDT cycle}{(WDTn_CLK (n = 0,1,2) cycle × 1024 × 1024) − 1}
> 
> RZ/G3S and RZ/G3E:
> 
>     WDTTIME setting value = \frac{WDT cycle}{(WDTn_CLK (n = 0,1,2) cycle × 1024 × 1024} − 1
> 
> I.e. on the former, the "- 1" offset is inside the denominator, while on the former, it is outside the
> fraction.  I assume this is just a typo in the documentation, and both formulas are supposed to be
> identical, so

I agree it is a typo on RZ/G2L, RZ/G2UL, and RZ/V2L hardware manual, I will report this issue to
Documentation team.

as

Watchdog timer cycle = WDTn_CLK (n = 0, 1, 2) cycle × 1024 × 1024 × (WDTTIME setting value + 1)

To get min/max value 43.69/178956.97 msec with 24 MHz mentioned on all DoCs,

WDT min Cycle = 1024 * 1024 * (0 + 1) / (24 * 10^6) = 0.043690 = 43.69 msec
WDT max cycle = 1024 * 1024 * (0xfff + 1) / (24 * 10^6) = 178956.97 msec
	
Cheers,
Biju

> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But when I'm talking to
> journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-05-05  8:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-06 11:22 [PATCH] dt-bindings: watchdog: renesas,wdt: Document RZ/G3L support Biju
2026-02-23 17:12 ` Rob Herring (Arm)
2026-05-05  6:04 ` Biju Das
2026-05-05  7:31 ` Geert Uytterhoeven
2026-05-05  8:06   ` Biju Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®