[PATCH] ASoC: rt5575: Remove redundant assignment to .owner

[PATCH] ASoC: rt5575: Remove redundant assignment to .owner

[xiaopeitux]

From: Pei Xiao <xiaopei01@kylinos.cn>

The coccicheck tool reports the following warning for this driver:
./rt5575.c:342:3-8: No need to set .owner here. The core will do it.

The manual assignment of .owner = THIS_MODULE; in the rt5575_i2c_driver
struct is redundant. The i2c_add_driver() function, which is called to
register the driver, automatically sets the driver's owner to THIS_MODULE.

The driver core handles this assignment internally, making the explicit
initialization in the struct definition unnecessary. Remove the
unnecessary line.

Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
 sound/soc/codecs/rt5575.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/rt5575.c b/sound/soc/codecs/rt5575.c
index c5525ad195ee..24e41af29689 100644
--- a/sound/soc/codecs/rt5575.c
+++ b/sound/soc/codecs/rt5575.c
@@ -339,7 +339,6 @@ MODULE_DEVICE_TABLE(of, rt5575_of_match);
 static struct i2c_driver rt5575_i2c_driver = {
 	.driver = {
 		.name = "rt5575",
-		.owner = THIS_MODULE,
 		.of_match_table = rt5575_of_match,
 	},
 	.probe = rt5575_i2c_probe,
-- 
2.25.1

Re: [PATCH] ASoC: rt5575: Remove redundant assignment to .owner

[Mark Brown]

On Fri, 20 Feb 2026 10:56:40 +0800, xiaopeitux@foxmail.com wrote:
> The coccicheck tool reports the following warning for this driver:
> ./rt5575.c:342:3-8: No need to set .owner here. The core will do it.
> 
> The manual assignment of .owner = THIS_MODULE; in the rt5575_i2c_driver
> struct is redundant. The i2c_add_driver() function, which is called to
> register the driver, automatically sets the driver's owner to THIS_MODULE.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt5575: Remove redundant assignment to .owner
      commit: f817c6a21235b503e68c50d0900d66cb1e1cf7bc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark