From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
To: kwilczynski@kernel.org, Daniel Hodges <git@danielhodges.dev>
Cc: kishon@kernel.org, bhelgaas@google.com, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] PCI: epf-mhi: return 0 on success instead of positive jiffies
Date: Thu, 26 Feb 2026 12:50:17 +0530 [thread overview]
Message-ID: <177209041798.86372.5318911333192648470.b4-ty@kernel.org> (raw)
In-Reply-To: <20260206200529.10784-1-git@danielhodges.dev>
On Fri, 06 Feb 2026 15:05:29 -0500, Daniel Hodges wrote:
> wait_for_completion_timeout() returns the number of jiffies remaining
> on success (positive value) or 0 on timeout. The pci_epf_mhi_edma_read()
> and pci_epf_mhi_edma_write() functions use the return value directly as
> their own return value, only converting timeout (0) to -ETIMEDOUT.
>
> On success, they return the positive jiffies value. The callers in
> drivers/bus/mhi/ep/ring.c check for errors with "if (ret < 0)" for
> read_sync and "if (ret)" for write_sync. This causes write_sync success
> cases to be incorrectly treated as errors since the positive jiffies
> value is non-zero.
>
> [...]
Applied, thanks!
[1/1] PCI: epf-mhi: return 0 on success instead of positive jiffies
commit: f6797680fe312ae6d32a773eb4d33400f24555c2
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
next prev parent reply other threads:[~2026-02-26 7:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 20:05 Daniel Hodges
2026-02-09 5:06 ` Krishna Chaitanya Chundru
2026-02-26 7:20 ` Manivannan Sadhasivam [this message]
2026-02-27 19:15 ` Bjorn Helgaas
2026-03-02 5:54 ` Manivannan Sadhasivam
2026-03-02 14:59 ` Daniel Hodges
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177209041798.86372.5318911333192648470.b4-ty@kernel.org \
--to=manivannan.sadhasivam@oss.qualcomm.com \
--cc=bhelgaas@google.com \
--cc=git@danielhodges.dev \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mhi@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®