[PATCH] regulator: bq257xx: Fix device node reference leak in bq257xx_reg_dt_parse_gpio()

[PATCH] regulator: bq257xx: Fix device node reference leak in bq257xx_reg_dt_parse_gpio()

[Felix Gu]

In bq257xx_reg_dt_parse_gpio(), if fails to get subchild, it returns
without calling of_node_put(child), causing the device node reference
leak.

Fixes: 981dd162b635 ("regulator: bq257xx: Add bq257xx boost regulator driver")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
 drivers/regulator/bq257xx-regulator.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/regulator/bq257xx-regulator.c b/drivers/regulator/bq257xx-regulator.c
index fc1ccede4468..dab8f1ab4450 100644
--- a/drivers/regulator/bq257xx-regulator.c
+++ b/drivers/regulator/bq257xx-regulator.c
@@ -115,11 +115,10 @@ static void bq257xx_reg_dt_parse_gpio(struct platform_device *pdev)
 		return;
 
 	subchild = of_get_child_by_name(child, pdata->desc.of_match);
+	of_node_put(child);
 	if (!subchild)
 		return;
 
-	of_node_put(child);
-
 	pdata->otg_en_gpio = devm_fwnode_gpiod_get_index(&pdev->dev,
 							 of_fwnode_handle(subchild),
 							 "enable", 0,

---
base-commit: 779cae956c8316aebc1946ef86ca001f99658270
change-id: 20260224-bq257-5a42efcd2347

Best regards,
-- 
Felix Gu <ustc.gu@gmail.com>

Re: [PATCH] regulator: bq257xx: Fix device node reference leak in bq257xx_reg_dt_parse_gpio()

[Mark Brown]

On Tue, 24 Feb 2026 19:19:03 +0800, Felix Gu wrote:
> In bq257xx_reg_dt_parse_gpio(), if fails to get subchild, it returns
> without calling of_node_put(child), causing the device node reference
> leak.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: bq257xx: Fix device node reference leak in bq257xx_reg_dt_parse_gpio()
      commit: 4baaddaa44af01cd4ce239493060738fd0881835

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark