mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v4] arm64: dts: qcom: x1-crd: add USB DisplayPort audio
@ 2026-02-09  9:32 Krzysztof Kozlowski
  2026-02-09 13:11 ` Dmitry Baryshkov
  2026-03-18 13:50 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-09  9:32 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski, Konrad Dybcio

Add support for playing audio over USB DisplayPort (the two left USB-C
ports on the CRD device).

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Changes since v3:
1. This time really drop sound-name-prefix. Forgot to actually implement
   this in v3.
v2: https://patch.msgid.link/20250624122933.54776-2-krzysztof.kozlowski@linaro.org

Answering comments:
1. No clue about third port. I do not have a reliable working CRD
   device, so I cannot test it. I add what I tested.

2. Topology and Alsa UCM were merged long time ago, so btw without this
   patch CRD is negativelly affected or even broken (ALSA tries to
   configure non-existing DAI links)...

Changes since v2:
1. Rebase - sound-name-prefix are now part of DTSI.
v2: https://patch.msgid.link/20250624122933.54776-2-krzysztof.kozlowski@linaro.org

Changes since v1:
1. Rebase (x1-crd.dtsi appeared)
2. Re-order cpu/codec
3. Add blank line before status for mdss_dp
4. Tags
---
 arch/arm64/boot/dts/qcom/x1-crd.dtsi | 32 ++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1-crd.dtsi b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
index ded96fb43489..c0c7ddabd8fc 100644
--- a/arch/arm64/boot/dts/qcom/x1-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1-crd.dtsi
@@ -226,6 +226,38 @@ sound {
 				"VA DMIC3", "MIC BIAS1",
 				"TX SWR_INPUT1", "ADC2_OUTPUT";
 
+		displayport-0-dai-link {
+			link-name = "DisplayPort0 Playback";
+
+			codec {
+				sound-dai = <&mdss_dp0>;
+			};
+
+			cpu {
+				sound-dai = <&q6apmbedai DISPLAY_PORT_RX_0>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
+		displayport-1-dai-link {
+			link-name = "DisplayPort1 Playback";
+
+			codec {
+				sound-dai = <&mdss_dp1>;
+			};
+
+			cpu {
+				sound-dai = <&q6apmbedai DISPLAY_PORT_RX_1>;
+			};
+
+			platform {
+				sound-dai = <&q6apm>;
+			};
+		};
+
 		wcd-playback-dai-link {
 			link-name = "WCD Playback";
 
-- 
2.51.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] arm64: dts: qcom: x1-crd: add USB DisplayPort audio
  2026-02-09  9:32 [PATCH v4] arm64: dts: qcom: x1-crd: add USB DisplayPort audio Krzysztof Kozlowski
@ 2026-02-09 13:11 ` Dmitry Baryshkov
  2026-03-18 13:50 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-02-09 13:11 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	Konrad Dybcio

On Mon, Feb 09, 2026 at 10:32:38AM +0100, Krzysztof Kozlowski wrote:
> Add support for playing audio over USB DisplayPort (the two left USB-C
> ports on the CRD device).
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v4] arm64: dts: qcom: x1-crd: add USB DisplayPort audio
  2026-02-09  9:32 [PATCH v4] arm64: dts: qcom: x1-crd: add USB DisplayPort audio Krzysztof Kozlowski
  2026-02-09 13:11 ` Dmitry Baryshkov
@ 2026-03-18 13:50 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-03-18 13:50 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski


On Mon, 09 Feb 2026 10:32:38 +0100, Krzysztof Kozlowski wrote:
> Add support for playing audio over USB DisplayPort (the two left USB-C
> ports on the CRD device).
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: x1-crd: add USB DisplayPort audio
      commit: 90b7cc18e9333879991f178c3f78bd1b93e2e8e7

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-18 13:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-09  9:32 [PATCH v4] arm64: dts: qcom: x1-crd: add USB DisplayPort audio Krzysztof Kozlowski
2026-02-09 13:11 ` Dmitry Baryshkov
2026-03-18 13:50 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®