[PATCH net-next 0/2] net: mdio-gpio: remove unneeded headers

[PATCH net-next 0/2] net: mdio-gpio: remove unneeded headers

[Bartosz Golaszewski]

This removes linux/mdio-gpio.h and linux/platform_data/mdio-gpio.h as
they are not needed due to the symbols either being used by the
mdio-gpio module alone or not used at all.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Bartosz Golaszewski (2):
      net: mdio-gpio: remove linux/mdio-gpio.h
      net: mdio-gpio: remove linux/platform_data/mdio-gpio.h

 MAINTAINERS                             |  1 -
 drivers/net/mdio/mdio-gpio.c            | 12 ++++--------
 include/linux/mdio-gpio.h               |  9 ---------
 include/linux/platform_data/mdio-gpio.h | 14 --------------
 4 files changed, 4 insertions(+), 32 deletions(-)
---
base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900
change-id: 20260316-gpio-mdio-hdr-cleanup-c70763dd52f4

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

[PATCH net-next 1/2] net: mdio-gpio: remove linux/mdio-gpio.h

[Bartosz Golaszewski]

The three defines from the linux/mdio-gpio.h header are only used in the
mdio-gpio module. There's no reason to have them in a public header.
Move them into the driver and remove mdio-gpio.h.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/net/mdio/mdio-gpio.c | 5 ++++-
 include/linux/mdio-gpio.h    | 9 ---------
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/net/mdio/mdio-gpio.c b/drivers/net/mdio/mdio-gpio.c
index 1cfd538b5105d9b0621572c22bc93dddef85d6f5..c993108898964bee9048a19c40e9de4e5c943b48 100644
--- a/drivers/net/mdio/mdio-gpio.c
+++ b/drivers/net/mdio/mdio-gpio.c
@@ -20,13 +20,16 @@
 #include <linux/gpio/consumer.h>
 #include <linux/interrupt.h>
 #include <linux/mdio-bitbang.h>
-#include <linux/mdio-gpio.h>
 #include <linux/module.h>
 #include <linux/of_mdio.h>
 #include <linux/platform_data/mdio-gpio.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 
+#define MDIO_GPIO_MDC	0
+#define MDIO_GPIO_MDIO	1
+#define MDIO_GPIO_MDO	2
+
 struct mdio_gpio_info {
 	struct mdiobb_ctrl ctrl;
 	struct gpio_desc *mdc, *mdio, *mdo;
diff --git a/include/linux/mdio-gpio.h b/include/linux/mdio-gpio.h
deleted file mode 100644
index cea443a672cb4bc466b7844756aa6261fca864e2..0000000000000000000000000000000000000000
--- a/include/linux/mdio-gpio.h
+++ /dev/null
@@ -1,9 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __LINUX_MDIO_GPIO_H
-#define __LINUX_MDIO_GPIO_H
-
-#define MDIO_GPIO_MDC	0
-#define MDIO_GPIO_MDIO	1
-#define MDIO_GPIO_MDO	2
-
-#endif

-- 
2.47.3

Re: [PATCH net-next 1/2] net: mdio-gpio: remove linux/mdio-gpio.h

[Linus Walleij]

On Mon, Mar 16, 2026 at 11:04 AM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:

> The three defines from the linux/mdio-gpio.h header are only used in the
> mdio-gpio module. There's no reason to have them in a public header.
> Move them into the driver and remove mdio-gpio.h.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Thanks for cleaning up this.
Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

[PATCH net-next 2/2] net: mdio-gpio: remove linux/platform_data/mdio-gpio.h

[Bartosz Golaszewski]

Nobody defines struct mdio_gpio_platform_data. Remove platform data
support from mdio-gpio and drop the header.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 MAINTAINERS                             |  1 -
 drivers/net/mdio/mdio-gpio.c            |  7 -------
 include/linux/platform_data/mdio-gpio.h | 14 --------------
 3 files changed, 22 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 4efaa76a0e6da830438661d2e5eb5095e4eb5020..50fd7077504683f557d730a3acc88babb0861909 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9593,7 +9593,6 @@ F:	include/linux/phy_fixed.h
 F:	include/linux/phy_link_topology.h
 F:	include/linux/phylib_stubs.h
 F:	include/linux/platform_data/mdio-bcm-unimac.h
-F:	include/linux/platform_data/mdio-gpio.h
 F:	include/net/phy/
 F:	include/trace/events/mdio.h
 F:	include/uapi/linux/mdio.h
diff --git a/drivers/net/mdio/mdio-gpio.c b/drivers/net/mdio/mdio-gpio.c
index c993108898964bee9048a19c40e9de4e5c943b48..958d1c6608ab76b8761d9d9f68d67311cc06fc98 100644
--- a/drivers/net/mdio/mdio-gpio.c
+++ b/drivers/net/mdio/mdio-gpio.c
@@ -22,7 +22,6 @@
 #include <linux/mdio-bitbang.h>
 #include <linux/module.h>
 #include <linux/of_mdio.h>
-#include <linux/platform_data/mdio-gpio.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 
@@ -113,7 +112,6 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev,
 					  struct mdio_gpio_info *bitbang,
 					  int bus_id)
 {
-	struct mdio_gpio_platform_data *pdata = dev_get_platdata(dev);
 	struct mii_bus *new_bus;
 
 	bitbang->ctrl.ops = &mdio_gpio_ops;
@@ -130,11 +128,6 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev,
 	else
 		strscpy(new_bus->id, "gpio", sizeof(new_bus->id));
 
-	if (pdata) {
-		new_bus->phy_mask = pdata->phy_mask;
-		new_bus->phy_ignore_ta_mask = pdata->phy_ignore_ta_mask;
-	}
-
 	if (device_is_compatible(dev, "microchip,mdio-smi0")) {
 		bitbang->ctrl.op_c22_read = 0;
 		bitbang->ctrl.op_c22_write = 0;
diff --git a/include/linux/platform_data/mdio-gpio.h b/include/linux/platform_data/mdio-gpio.h
deleted file mode 100644
index 13874fa6e7679fe9754479621adcab0332312356..0000000000000000000000000000000000000000
--- a/include/linux/platform_data/mdio-gpio.h
+++ /dev/null
@@ -1,14 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-/*
- * MDIO-GPIO bus platform data structure
- */
-
-#ifndef __LINUX_MDIO_GPIO_PDATA_H
-#define __LINUX_MDIO_GPIO_PDATA_H
-
-struct mdio_gpio_platform_data {
-	u32 phy_mask;
-	u32 phy_ignore_ta_mask;
-};
-
-#endif /* __LINUX_MDIO_GPIO_PDATA_H */

-- 
2.47.3

Re: [PATCH net-next 2/2] net: mdio-gpio: remove linux/platform_data/mdio-gpio.h

[Linus Walleij]

On Mon, Mar 16, 2026 at 11:04 AM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:

> Nobody defines struct mdio_gpio_platform_data. Remove platform data
> support from mdio-gpio and drop the header.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Reviewed-by: Linus Walleij <linusw@kernel.org>

Yours,
Linus Walleij

Re: [PATCH net-next 0/2] net: mdio-gpio: remove unneeded headers

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 16 Mar 2026 11:04:02 +0100 you wrote:
> This removes linux/mdio-gpio.h and linux/platform_data/mdio-gpio.h as
> they are not needed due to the symbols either being used by the
> mdio-gpio module alone or not used at all.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> Bartosz Golaszewski (2):
>       net: mdio-gpio: remove linux/mdio-gpio.h
>       net: mdio-gpio: remove linux/platform_data/mdio-gpio.h
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: mdio-gpio: remove linux/mdio-gpio.h
    https://git.kernel.org/netdev/net-next/c/9c6b4009da59
  - [net-next,2/2] net: mdio-gpio: remove linux/platform_data/mdio-gpio.h
    https://git.kernel.org/netdev/net-next/c/356d4fbcf3de

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html