[PATCH v2 0/5] dt-bindings: USB: qcom,snps-dwc3: cleanup of existing bindings

[PATCH v2 0/5] dt-bindings: USB: qcom,snps-dwc3: cleanup of existing bindings

[Krzysztof Kozlowski]

Changes in v2:
1. Three new patches, combine previous two into one patchset.

Previous postings:
https://lore.kernel.org/r/20260319091709.20981-2-krzysztof.kozlowski@oss.qualcomm.com/
https://lore.kernel.org/r/20260319092348.35237-2-krzysztof.kozlowski@oss.qualcomm.com/

Best regards,
Krzysztof

---
Krzysztof Kozlowski (5):
      dt-bindings: usb: qcom,snps-dwc3: Drop stale child node comment
      dt-bindings: usb: qcom,snps-dwc3: Add missing clocks and interrupts constraints
      dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM6375
      dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM4250
      dt-bindings: usb: qcom,snps-dwc3: Add constraints for IPQ5424 and IPQ9574

 .../devicetree/bindings/usb/qcom,snps-dwc3.yaml    | 36 ++++++++++++++++++++--
 1 file changed, 33 insertions(+), 3 deletions(-)
---
base-commit: 785f0eb2f85decbe7c1ef9ae922931f0194ffc2e
change-id: 20260323-dt-bindings-snps-qcom-dwc3-cleanup-390d61fbde23

Best regards,
--  
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

[PATCH v2 1/5] dt-bindings: usb: qcom,snps-dwc3: Drop stale child node comment

[Krzysztof Kozlowski]

After moving the binding to style with combined wrapper+device (so one
node) there is no child node required.  Drop the stale comment about it.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Changes in v2:
1. None
---
 Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
index f879e2e104c4..2b6a0939d98d 100644
--- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
@@ -153,8 +153,6 @@ properties:
 
   wakeup-source: true
 
-# Required child node:
-
 required:
   - compatible
   - reg

-- 
2.51.0

Re: [PATCH v2 1/5] dt-bindings: usb: qcom,snps-dwc3: Drop stale child node comment

[Rob Herring (Arm)]

On Mon, 23 Mar 2026 09:54:12 +0100, Krzysztof Kozlowski wrote:
> After moving the binding to style with combined wrapper+device (so one
> node) there is no child node required.  Drop the stale comment about it.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Changes in v2:
> 1. None
> ---
>  Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH v2 2/5] dt-bindings: usb: qcom,snps-dwc3: Add missing clocks and interrupts constraints

[Krzysztof Kozlowski]

The top-level part defines variable number of clocks and interrupts, and
each "if:then:" block narrows them.  It however narrows only the
maxItems leaving minItems undefined, which then takes different values
depending on dtschema being used.

Recommended style is to avoid ambiguity in such case, thus if top-level
part has broad constraints, then each "if:then:" must specify both upper
and lower limits.

Add missing constraints, mostly minItems but also maxItems for one
variant.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Changes in v2:
1. Narrow also interrupts for qcom,ipq5018-dwc3/qcom,ipq5332-dwc3
---
 Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
index 2b6a0939d98d..1ad2b52955ee 100644
--- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
@@ -173,6 +173,7 @@ allOf:
     then:
       properties:
         clocks:
+          minItems: 3
           maxItems: 3
         clock-names:
           items:
@@ -220,6 +221,7 @@ allOf:
     then:
       properties:
         clocks:
+          minItems: 5
           maxItems: 5
         clock-names:
           items:
@@ -262,6 +264,7 @@ allOf:
     then:
       properties:
         clocks:
+          minItems: 4
           maxItems: 4
         clock-names:
           items:
@@ -281,6 +284,7 @@ allOf:
     then:
       properties:
         clocks:
+          minItems: 4
           maxItems: 4
         clock-names:
           items:
@@ -301,6 +305,7 @@ allOf:
     then:
       properties:
         clocks:
+          minItems: 9
           maxItems: 9
         clock-names:
           items:
@@ -361,6 +366,7 @@ allOf:
       properties:
         clocks:
           minItems: 6
+          maxItems: 6
         clock-names:
           items:
             - const: cfg_noc
@@ -402,6 +408,7 @@ allOf:
     then:
       properties:
         clocks:
+          minItems: 7
           maxItems: 7
         clock-names:
           items:
@@ -470,6 +477,7 @@ allOf:
     then:
       properties:
         interrupts:
+          minItems: 4
           maxItems: 4
         interrupt-names:
           items:

-- 
2.51.0

Re: [PATCH v2 2/5] dt-bindings: usb: qcom,snps-dwc3: Add missing clocks and interrupts constraints

[Rob Herring (Arm)]

On Mon, 23 Mar 2026 09:54:13 +0100, Krzysztof Kozlowski wrote:
> The top-level part defines variable number of clocks and interrupts, and
> each "if:then:" block narrows them.  It however narrows only the
> maxItems leaving minItems undefined, which then takes different values
> depending on dtschema being used.
> 
> Recommended style is to avoid ambiguity in such case, thus if top-level
> part has broad constraints, then each "if:then:" must specify both upper
> and lower limits.
> 
> Add missing constraints, mostly minItems but also maxItems for one
> variant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Changes in v2:
> 1. Narrow also interrupts for qcom,ipq5018-dwc3/qcom,ipq5332-dwc3
> ---
>  Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH v2 3/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM6375

[Krzysztof Kozlowski]

The qcom,sm6375-dwc3 is already documented in top level part, but it
misses specific constraints for clocks and interrupts.

Closes: https://sashiko.dev/#/patchset/20260319092348.35237-2-krzysztof.kozlowski%40oss.qualcomm.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

I wanted to add Reported-by tag, but checkpatch does not like non-email
address:
ERROR: Unrecognized email address: 'sashiko.dev'

Changes in v2:
1. New patch
---
 Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
index 1ad2b52955ee..94eda4fe48ad 100644
--- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
@@ -357,6 +357,7 @@ allOf:
               - qcom,sc8180x-dwc3-mp
               - qcom,sm6115-dwc3
               - qcom,sm6125-dwc3
+              - qcom,sm6375-dwc3
               - qcom,sm8150-dwc3
               - qcom,sm8250-dwc3
               - qcom,sm8450-dwc3
@@ -531,6 +532,7 @@ allOf:
               - qcom,sdx75-dwc3
               - qcom,sm4250-dwc3
               - qcom,sm6350-dwc3
+              - qcom,sm6375-dwc3
               - qcom,sm8150-dwc3
               - qcom,sm8250-dwc3
               - qcom,sm8350-dwc3

-- 
2.51.0

Re: [PATCH v2 3/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM6375

[Konrad Dybcio]

On 3/23/26 9:54 AM, Krzysztof Kozlowski wrote:
> The qcom,sm6375-dwc3 is already documented in top level part, but it
> misses specific constraints for clocks and interrupts.
> 
> Closes: https://sashiko.dev/#/patchset/20260319092348.35237-2-krzysztof.kozlowski%40oss.qualcomm.com
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH v2 3/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM6375

[Rob Herring (Arm)]

On Mon, 23 Mar 2026 09:54:14 +0100, Krzysztof Kozlowski wrote:
> The qcom,sm6375-dwc3 is already documented in top level part, but it
> misses specific constraints for clocks and interrupts.
> 
> Closes: https://sashiko.dev/#/patchset/20260319092348.35237-2-krzysztof.kozlowski%40oss.qualcomm.com
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> I wanted to add Reported-by tag, but checkpatch does not like non-email
> address:
> ERROR: Unrecognized email address: 'sashiko.dev'
> 
> Changes in v2:
> 1. New patch
> ---
>  Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>

[PATCH v2 4/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM4250

[Krzysztof Kozlowski]

The qcom,sm4250-dwc3 is already documented in top level part, but it
misses specific constraints for clocks.  The SoC is derivative of SM6115
(or vice versa), so the interrupts part is incorrectly placed and should
be same as for SM6115.

Closes: https://sashiko.dev/#/patchset/20260319092348.35237-2-krzysztof.kozlowski%40oss.qualcomm.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Changes in v2:
1. New patch
---
 Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
index 94eda4fe48ad..e9e534f49183 100644
--- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
@@ -355,6 +355,7 @@ allOf:
               - qcom,sar2130p-dwc3
               - qcom,sc8180x-dwc3
               - qcom,sc8180x-dwc3-mp
+              - qcom,sm4250-dwc3
               - qcom,sm6115-dwc3
               - qcom,sm6125-dwc3
               - qcom,sm6375-dwc3
@@ -452,6 +453,7 @@ allOf:
               - qcom,msm8996-dwc3
               - qcom,qcs404-dwc3
               - qcom,sdm660-dwc3
+              - qcom,sm4250-dwc3
               - qcom,sm6115-dwc3
               - qcom,sm6125-dwc3
     then:
@@ -530,7 +532,6 @@ allOf:
               - qcom,sdx55-dwc3
               - qcom,sdx65-dwc3
               - qcom,sdx75-dwc3
-              - qcom,sm4250-dwc3
               - qcom,sm6350-dwc3
               - qcom,sm6375-dwc3
               - qcom,sm8150-dwc3

-- 
2.51.0

Re: [PATCH v2 4/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM4250

[Konrad Dybcio]

On 3/23/26 9:54 AM, Krzysztof Kozlowski wrote:
> The qcom,sm4250-dwc3 is already documented in top level part, but it
> misses specific constraints for clocks.  The SoC is derivative of SM6115
> (or vice versa), so the interrupts part is incorrectly placed and should
> be same as for SM6115.

They're the same SoC with a different speedbin fuse value for the CPU/GPU,
I'd say drop this binding altogether

Konrad

Re: [PATCH v2 4/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for SM4250

[Krzysztof Kozlowski]

On 23/03/2026 12:01, Konrad Dybcio wrote:
> On 3/23/26 9:54 AM, Krzysztof Kozlowski wrote:
>> The qcom,sm4250-dwc3 is already documented in top level part, but it
>> misses specific constraints for clocks.  The SoC is derivative of SM6115
>> (or vice versa), so the interrupts part is incorrectly placed and should
>> be same as for SM6115.
> 
> They're the same SoC with a different speedbin fuse value for the CPU/GPU,
> I'd say drop this binding altogether

Sure, I also thought about it.

Best regards,
Krzysztof

[PATCH v2 5/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for IPQ5424 and IPQ9574

[Krzysztof Kozlowski]

The qcom,ipq5424-dwc3 and qcom,ipq9574-dwc3 are already documented in
top level part, but they miss specific constraints for clocks (IPQ5424)
and interrupts (both).

Closes: https://sashiko.dev/#/patchset/20260319092348.35237-2-krzysztof.kozlowski%40oss.qualcomm.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Changes in v2:
1. New patch
---
 .../devicetree/bindings/usb/qcom,snps-dwc3.yaml     | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
index e9e534f49183..603d4cbd2803 100644
--- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
@@ -202,6 +202,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,ipq5424-dwc3
               - qcom,ipq9574-dwc3
               - qcom,kaanapali-dwc3
               - qcom,msm8953-dwc3
@@ -489,6 +490,26 @@ allOf:
             - const: dp_hs_phy_irq
             - const: dm_hs_phy_irq
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,ipq5424-dwc3
+              - qcom,ipq9574-dwc3
+    then:
+      properties:
+        interrupts:
+          minItems: 5
+          maxItems: 5
+        interrupt-names:
+          items:
+            - const: dwc_usb3
+            - const: pwr_event
+            - const: qusb2_phy
+            - const: dp_hs_phy_irq
+            - const: dm_hs_phy_irq
+
   - if:
       properties:
         compatible:

-- 
2.51.0

Re: [PATCH v2 5/5] dt-bindings: usb: qcom,snps-dwc3: Add constraints for IPQ5424 and IPQ9574

[Rob Herring (Arm)]

On Mon, 23 Mar 2026 09:54:16 +0100, Krzysztof Kozlowski wrote:
> The qcom,ipq5424-dwc3 and qcom,ipq9574-dwc3 are already documented in
> top level part, but they miss specific constraints for clocks (IPQ5424)
> and interrupts (both).
> 
> Closes: https://sashiko.dev/#/patchset/20260319092348.35237-2-krzysztof.kozlowski%40oss.qualcomm.com
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Changes in v2:
> 1. New patch
> ---
>  .../devicetree/bindings/usb/qcom,snps-dwc3.yaml     | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>