mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes
@ 2026-03-24 15:29 Abel Vesa
  2026-03-24 15:29 ` [PATCH v3 1/3] arm64: dts: qcom: eliza: Coding style clean-ups Abel Vesa
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Abel Vesa @ 2026-03-24 15:29 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov
  Cc: Nitin Rawat, Krzysztof Kozlowski, linux-arm-msm, devicetree,
	linux-kernel, Abel Vesa, Konrad Dybcio

Some review comments were not addressed before the initial Eliza
devicetree support was merged. This series addresses the remaining
issues.

The changes are split into three patches:
- one patch with coding style cleanups
- one functional fix for GCC/CX power domain handling
- one functional fix that adds the msi-parent to the UFS node

The MCQ mode was enabled during review in anticipation of driver
support, which did not materialize in time.

Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Changes in v3:
- Re-worded commit message for second patch according to Bjorn's
  suggestion sent for v1.
- Picked up Konrad's and Dmitry's R-b tag for the third patch.
- Link to v2: https://patch.msgid.link/20260323-eliza-base-dt-fixes-v2-0-59af0627b7c2@oss.qualcomm.com

Changes in v2:
- Rebased on next-20260323.
- Replaced the third patch with one that adds the missing msi-parent
  property. It turned out that the MCQ issue was related to some GCC
  bit missing, but this msi-parent property is still needed by the MCQ
  mode.
- Picked up Dmitry's and Konrad's R-b tags for the first two patches.
- Link to v1: https://patch.msgid.link/20260322-eliza-base-dt-fixes-v1-0-c633a6064a24@oss.qualcomm.com

---
Abel Vesa (3):
      arm64: dts: qcom: eliza: Coding style clean-ups
      arm64: dts: qcom: eliza: Add missing CX power domain to GCC
      arm64: dts: qcom: eliza: Add missing msi-parent for UFS

 arch/arm64/boot/dts/qcom/eliza.dtsi | 31 +++++++++++++++++++------------
 1 file changed, 19 insertions(+), 12 deletions(-)
---
base-commit: 09c0f7f1bcdbc3c37a5a760cbec76bf18f278406
change-id: 20260322-eliza-base-dt-fixes-6b93dd26c697

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 1/3] arm64: dts: qcom: eliza: Coding style clean-ups
  2026-03-24 15:29 [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes Abel Vesa
@ 2026-03-24 15:29 ` Abel Vesa
  2026-03-24 15:29 ` [PATCH v3 2/3] arm64: dts: qcom: eliza: Add missing CX power domain to GCC Abel Vesa
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-03-24 15:29 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov
  Cc: Nitin Rawat, Krzysztof Kozlowski, linux-arm-msm, devicetree,
	linux-kernel, Abel Vesa, Konrad Dybcio

Some coding style issues were raised during review but the devicetree
was merged meanwhile. Address them here.

These changes are non-functional.

Fixes: db7fe6963466 ("arm64: dts: qcom: Introduce Eliza Soc base dtsi")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza.dtsi | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
index 190f10a77d74..5dc3aede6842 100644
--- a/arch/arm64/boot/dts/qcom/eliza.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
@@ -686,7 +686,7 @@ pcie_noc: interconnect@16c0000 {
 			reg = <0x0 0x016c0000 0x0 0x11400>;
 			qcom,bcm-voters = <&apps_bcm_voter>;
 			clocks = <&gcc GCC_AGGRE_NOC_PCIE_AXI_CLK>,
-				<&gcc GCC_CFG_NOC_PCIE_ANOC_AHB_CLK>;
+				 <&gcc GCC_CFG_NOC_PCIE_ANOC_AHB_CLK>;
 			#interconnect-cells = <2>;
 		};
 
@@ -722,7 +722,6 @@ ufs_mem_phy: phy@1d80000 {
 			clocks = <&rpmhcc RPMH_CXO_CLK>,
 				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>,
 				 <&tcsr TCSR_UFS_CLKREF_EN>;
-
 			clock-names = "ref",
 				      "ref_aux",
 				      "qref";
@@ -912,10 +911,12 @@ pdc: interrupt-controller@b220000 {
 		spmi: arbiter@c400000 {
 			compatible = "qcom,eliza-spmi-pmic-arb",
 				     "qcom,x1e80100-spmi-pmic-arb";
-			reg = <0 0x0c400000 0 0x3000>,
-			      <0 0x0c500000 0 0x400000>,
-			      <0 0x0c440000 0 0x80000>;
-			reg-names = "core", "chnls", "obsrvr";
+			reg = <0x0 0x0c400000 0x0 0x3000>,
+			      <0x0 0x0c500000 0x0 0x400000>,
+			      <0x0 0x0c440000 0x0 0x80000>;
+			reg-names = "core",
+				    "chnls",
+				    "obsrvr";
 
 			qcom,ee = <0>;
 			qcom,channel = <0>;
@@ -925,9 +926,10 @@ spmi: arbiter@c400000 {
 			ranges;
 
 			spmi_bus0: spmi@c42d000 {
-				reg = <0 0x0c42d000 0 0x4000>,
-				      <0 0x0c4c0000 0 0x10000>;
-				reg-names = "cnfg", "intr";
+				reg = <0x0 0x0c42d000 0x0 0x4000>,
+				      <0x0 0x0c4c0000 0x0 0x10000>;
+				reg-names = "cnfg",
+					    "intr";
 
 				interrupt-names = "periph_irq";
 				interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
@@ -939,9 +941,10 @@ spmi_bus0: spmi@c42d000 {
 			};
 
 			spmi_bus1: spmi@c432000 {
-				reg = <0 0x0c432000 0 0x4000>,
-				      <0 0x0c4d0000 0 0x10000>;
-				reg-names = "cnfg", "intr";
+				reg = <0x0 0x0c432000 0x0 0x4000>,
+				      <0x0 0x0c4d0000 0x0 0x10000>;
+				reg-names = "cnfg",
+					    "intr";
 
 				interrupt-names = "periph_irq";
 				interrupts-extended = <&pdc 3 IRQ_TYPE_LEVEL_HIGH>;

-- 
2.48.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 2/3] arm64: dts: qcom: eliza: Add missing CX power domain to GCC
  2026-03-24 15:29 [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes Abel Vesa
  2026-03-24 15:29 ` [PATCH v3 1/3] arm64: dts: qcom: eliza: Coding style clean-ups Abel Vesa
@ 2026-03-24 15:29 ` Abel Vesa
  2026-03-24 15:29 ` [PATCH v3 3/3] arm64: dts: qcom: eliza: Add missing msi-parent for UFS Abel Vesa
  2026-03-26  3:19 ` [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes Bjorn Andersson
  3 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-03-24 15:29 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov
  Cc: Nitin Rawat, Krzysztof Kozlowski, linux-arm-msm, devicetree,
	linux-kernel, Abel Vesa, Konrad Dybcio

Unless CX is declared the power-domain of GCC votes (power and
performance) on the GDSCs provided by GCC will not propagate to the CX,
which might result in under-voltage conditions.

Add the missing power-domains property to associate GCC with RPMHPD_CX.

Fixes: db7fe6963466 ("arm64: dts: qcom: Introduce Eliza Soc base dtsi")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
index 5dc3aede6842..fab603cd8e42 100644
--- a/arch/arm64/boot/dts/qcom/eliza.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
@@ -617,6 +617,8 @@ gcc: clock-controller@100000 {
 				 <&ufs_mem_phy 2>,
 				 <0>;
 
+			power-domains = <&rpmhpd RPMHPD_CX>;
+
 			#clock-cells = <1>;
 			#reset-cells = <1>;
 			#power-domain-cells = <1>;

-- 
2.48.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3 3/3] arm64: dts: qcom: eliza: Add missing msi-parent for UFS
  2026-03-24 15:29 [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes Abel Vesa
  2026-03-24 15:29 ` [PATCH v3 1/3] arm64: dts: qcom: eliza: Coding style clean-ups Abel Vesa
  2026-03-24 15:29 ` [PATCH v3 2/3] arm64: dts: qcom: eliza: Add missing CX power domain to GCC Abel Vesa
@ 2026-03-24 15:29 ` Abel Vesa
  2026-03-26  3:19 ` [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes Bjorn Andersson
  3 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-03-24 15:29 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Dmitry Baryshkov
  Cc: Nitin Rawat, Krzysztof Kozlowski, linux-arm-msm, devicetree,
	linux-kernel, Abel Vesa, Konrad Dybcio

Wire up the UFS controller to the GIC ITS by specifying the
msi-parent property. The UFS host uses MSI and requires a valid
ITS mapping in order to allocate and receive interrupts.

Add the ITS reference along with the device ID to match the SMMU
stream ID.

Fixes: db7fe6963466 ("arm64: dts: qcom: Introduce Eliza Soc base dtsi")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
index fab603cd8e42..62fccb43a7e8 100644
--- a/arch/arm64/boot/dts/qcom/eliza.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
@@ -785,6 +785,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			iommus = <&apps_smmu 0x60 0x0>;
 			dma-coherent;
 
+			msi-parent = <&gic_its 0x60>;
+
 			lanes-per-direction = <2>;
 			qcom,ice = <&ice>;
 

-- 
2.48.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes
  2026-03-24 15:29 [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes Abel Vesa
                   ` (2 preceding siblings ...)
  2026-03-24 15:29 ` [PATCH v3 3/3] arm64: dts: qcom: eliza: Add missing msi-parent for UFS Abel Vesa
@ 2026-03-26  3:19 ` Bjorn Andersson
  3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2026-03-26  3:19 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Dmitry Baryshkov, Abel Vesa
  Cc: Nitin Rawat, Krzysztof Kozlowski, linux-arm-msm, devicetree,
	linux-kernel, Konrad Dybcio


On Tue, 24 Mar 2026 17:29:40 +0200, Abel Vesa wrote:
> Some review comments were not addressed before the initial Eliza
> devicetree support was merged. This series addresses the remaining
> issues.
> 
> The changes are split into three patches:
> - one patch with coding style cleanups
> - one functional fix for GCC/CX power domain handling
> - one functional fix that adds the msi-parent to the UFS node
> 
> [...]

Applied, thanks!

[1/3] arm64: dts: qcom: eliza: Coding style clean-ups
      commit: 394715392733c1c6ee8812a70c884efa39f9e82b
[2/3] arm64: dts: qcom: eliza: Add missing CX power domain to GCC
      commit: 335804e0568bb985c763f8e9aef749654e415b57
[3/3] arm64: dts: qcom: eliza: Add missing msi-parent for UFS
      commit: 9b7dcb754a3cc6e5e13b523f17fa7585aa9adb99

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-03-26  3:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-24 15:29 [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes Abel Vesa
2026-03-24 15:29 ` [PATCH v3 1/3] arm64: dts: qcom: eliza: Coding style clean-ups Abel Vesa
2026-03-24 15:29 ` [PATCH v3 2/3] arm64: dts: qcom: eliza: Add missing CX power domain to GCC Abel Vesa
2026-03-24 15:29 ` [PATCH v3 3/3] arm64: dts: qcom: eliza: Add missing msi-parent for UFS Abel Vesa
2026-03-26  3:19 ` [PATCH v3 0/3] arm64: dts: qcom: eliza: Left-over review fixes Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®