mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [GIT PULL] rtla: Fix build failure without libbpf
@ 2026-03-30 16:52 Steven Rostedt
  2026-03-30 21:02 ` pr-tracker-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2026-03-30 16:52 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: LKML, Tomas Glozar


Linus,

rtla fixes for 7.0:

- Fix build failure when libbpf does not exist

  RTLA supports building without BPF libraries, but a recent change
  added a libbpf.h include outside of the BPF protection which caused
  build failures when libbpf was not installed.


Please pull the latest trace-rtla-v7.0-rc5 tree, which can be found at:


  git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace-rtla-v7.0-rc5

Tag SHA1: 816c62dbcd7d5f2e9f6caa1ce77a9b77c1b20014
Head SHA1: 2e8b1a1d12ae3338efeb1c3de3eb4e9324b87a28


Tomas Glozar (1):
      rtla: Fix build without libbpf header

----
 tools/tracing/rtla/src/timerlat_bpf.h | 1 -
 1 file changed, 1 deletion(-)
---------------------------
commit 2e8b1a1d12ae3338efeb1c3de3eb4e9324b87a28
Author: Tomas Glozar <tglozar@redhat.com>
Date:   Mon Mar 30 11:12:07 2026 +0200

    rtla: Fix build without libbpf header
    
    rtla supports building without libbpf. However, BPF actions
    patchset [1] adds an include of bpf/libbpf.h into timerlat_bpf.h,
    which breaks build on systems that don't have libbpf headers
    installed.
    
    This is a leftover from a draft version of the patchset where
    timerlat_bpf_set_action() (which takes a struct bpf_program * argument)
    was defined in the header. timerlat_bpf.c already includes bpf/libbpf.h
    via timerlat.skel.h when libbpf is present.
    
    Remove the redundant include to fix build on systems without libbpf
    headers.
    
    [1] https://lore.kernel.org/linux-trace-kernel/20251126144205.331954-1-tglozar@redhat.com/T/
    
    Cc: John Kacur <jkacur@redhat.com>
    Cc: Luis Goncalves <lgoncalv@redhat.com>
    Cc: Crystal Wood <crwood@redhat.com>
    Cc: Costa Shulyupin <costa.shul@redhat.com>
    Link: https://patch.msgid.link/20260330091207.16184-1-tglozar@redhat.com
    Reported-by: Steven Rostedt (Google) <rostedt@goodmis.org>
    Closes: https://lore.kernel.org/linux-trace-kernel/20260329122202.65a8b575@robin/
    Fixes: 8cd0f08ac72e ("rtla/timerlat: Support tail call from BPF program")
    Signed-off-by: Tomas Glozar <tglozar@redhat.com>
    Reviewed-by: Wander Lairson Costa <wander@redhat.com>
    Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

diff --git a/tools/tracing/rtla/src/timerlat_bpf.h b/tools/tracing/rtla/src/timerlat_bpf.h
index 169abeaf4363..f7c5675737fe 100644
--- a/tools/tracing/rtla/src/timerlat_bpf.h
+++ b/tools/tracing/rtla/src/timerlat_bpf.h
@@ -12,7 +12,6 @@ enum summary_field {
 };
 
 #ifndef __bpf__
-#include <bpf/libbpf.h>
 #ifdef HAVE_BPF_SKEL
 int timerlat_bpf_init(struct timerlat_params *params);
 int timerlat_bpf_attach(void);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-30 21:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-30 16:52 [GIT PULL] rtla: Fix build failure without libbpf Steven Rostedt
2026-03-30 21:02 ` pr-tracker-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®