From: "tip-bot2 for Zide Chen" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Steve Wahl <steve.wahl@hpe.com>, Zide Chen <zide.chen@intel.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Dapeng Mi <dapeng1.mi@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: perf/urgent] perf/x86/intel/uncore: Skip discovery table for offline dies
Date: Tue, 07 Apr 2026 07:06:39 -0000 [thread overview]
Message-ID: <177554559987.226963.3746298599233294057.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260313174050.171704-3-zide.chen@intel.com>
The following commit has been merged into the perf/urgent branch of tip:
Commit-ID: 7b568e9eba2fad89a696f22f0413d44cf4a1f892
Gitweb: https://git.kernel.org/tip/7b568e9eba2fad89a696f22f0413d44cf4a1f892
Author: Zide Chen <zide.chen@intel.com>
AuthorDate: Fri, 13 Mar 2026 10:40:48 -07:00
Committer: Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 07 Apr 2026 09:05:29 +02:00
perf/x86/intel/uncore: Skip discovery table for offline dies
This warning can be triggered if NUMA is disabled and the system
boots with fewer CPUs than the number of CPUs in die 0.
WARNING: CPU: 9 PID: 7257 at uncore.c:1157 uncore_pci_pmu_register+0x136/0x160 [intel_uncore]
Currently, the discovery table continues to be parsed even if all CPUs
in the associated die are offline. This can lead to an array overflow
at "pmu->boxes[die] = box" in uncore_pci_pmu_register(), which may
trigger the warning above or cause other issues.
Fixes: edae1f06c2cd ("perf/x86/intel/uncore: Parse uncore discovery tables")
Reported-by: Steve Wahl <steve.wahl@hpe.com>
Signed-off-by: Zide Chen <zide.chen@intel.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Tested-by: Steve Wahl <steve.wahl@hpe.com>
Link: https://patch.msgid.link/20260313174050.171704-3-zide.chen@intel.com
---
arch/x86/events/intel/uncore_discovery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/intel/uncore_discovery.c b/arch/x86/events/intel/uncore_discovery.c
index 427939b..583cbd0 100644
--- a/arch/x86/events/intel/uncore_discovery.c
+++ b/arch/x86/events/intel/uncore_discovery.c
@@ -371,7 +371,7 @@ static bool uncore_discovery_pci(struct uncore_discovery_domain *domain)
(val & UNCORE_DISCOVERY_DVSEC2_BIR_MASK) * UNCORE_DISCOVERY_BIR_STEP;
die = get_device_die_id(dev);
- if (die < 0)
+ if ((die < 0) || (die >= uncore_max_dies()))
continue;
parse_discovery_table(domain, dev, die, bar_offset, &parsed);
next prev parent reply other threads:[~2026-04-07 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 17:40 [PATCH V4 0/4] Miscellaneous Intel uncore patches Zide Chen
2026-03-13 17:40 ` [PATCH V4 1/4] perf/x86/intel/uncore: Fix iounmap() leak on global_init failure Zide Chen
2026-04-07 7:06 ` [tip: perf/urgent] " tip-bot2 for Zide Chen
2026-03-13 17:40 ` [PATCH V4 2/4] perf/x86/intel/uncore: Skip discovery table for offline dies Zide Chen
2026-04-07 7:06 ` tip-bot2 for Zide Chen [this message]
2026-03-13 17:40 ` [PATCH V4 3/4] perf/x86/intel/uncore: Fix die ID init and look up bugs Zide Chen
2026-03-16 6:53 ` Mi, Dapeng
2026-03-16 16:58 ` Chen, Zide
2026-04-07 7:06 ` [tip: perf/urgent] " tip-bot2 for Zide Chen
2026-03-13 17:40 ` [PATCH V4 4/4] perf/x86/intel/uncore: Remove extra double quote mark Zide Chen
2026-04-07 7:06 ` [tip: perf/urgent] " tip-bot2 for Zide Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=177554559987.226963.3746298599233294057.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=dapeng1.mi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=steve.wahl@hpe.com \
--cc=x86@kernel.org \
--cc=zide.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®