mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: David Howells <dhowells@redhat.com>,
	torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: Mark bitrevX() functions as const
Date: Mon, 11 Dec 2006 14:22:30 +0000	[thread overview]
Message-ID: <17788.1165846950@redhat.com> (raw)
In-Reply-To: <20061211132540.GA4629@APFDCB5C>

Akinobu Mita <akinobu.mita@gmail.com> wrote:

> __attribute_pure__ ?

I'm not sure "pure" is better than const in this case.  Although it *does* look
at a global variable (byte_rev_table), that variable is constant.  In effect,
the functions output does only depend on its input.  The R/O data it requires
is no different to its out of line code.  You'd have to consult a compiler
wrangler to be sure, though.

David

  parent reply	other threads:[~2006-12-11 14:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-11 12:35 David Howells
2006-12-11 12:57 ` Jeff Garzik
2006-12-11 13:37   ` Andreas Schwab
2006-12-11 13:53     ` Jeff Garzik
2006-12-11 13:14 ` David Howells
2006-12-11 13:32   ` Jeff Garzik
2006-12-11 14:18   ` David Howells
2006-12-11 13:25 ` Akinobu Mita
2006-12-11 14:22 ` David Howells [this message]
2006-12-11 16:05 ` Linus Torvalds
2006-12-11 16:12 ` David Howells
2006-12-11 16:34   ` Linus Torvalds
2006-12-11 17:35   ` Jan Engelhardt
2006-12-11 17:51     ` Bernd Petrovitsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17788.1165846950@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®