From: Akinobu Mita <akinobu.mita@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: Mark bitrevX() functions as const
Date: Mon, 11 Dec 2006 22:25:40 +0900 [thread overview]
Message-ID: <20061211132540.GA4629@APFDCB5C> (raw)
In-Reply-To: <29447.1165840536@redhat.com>
On Mon, Dec 11, 2006 at 12:35:36PM +0000, David Howells wrote:
> diff --git a/include/linux/bitrev.h b/include/linux/bitrev.h
> index 05e540d..032056b 100644
> --- a/include/linux/bitrev.h
> +++ b/include/linux/bitrev.h
> @@ -5,11 +5,11 @@ #include <linux/types.h>
>
> extern u8 const byte_rev_table[256];
>
> -static inline u8 bitrev8(u8 byte)
> +static inline __attribute__((const)) u8 bitrev8(u8 byte)
> {
> return byte_rev_table[byte];
> }
>
> -extern u32 bitrev32(u32 in);
> +extern __attribute__((const)) u32 bitrev32(u32 in);
>
> #endif /* _LINUX_BITREV_H */
__attribute_pure__ ?
next prev parent reply other threads:[~2006-12-11 13:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 12:35 David Howells
2006-12-11 12:57 ` Jeff Garzik
2006-12-11 13:37 ` Andreas Schwab
2006-12-11 13:53 ` Jeff Garzik
2006-12-11 13:14 ` David Howells
2006-12-11 13:32 ` Jeff Garzik
2006-12-11 14:18 ` David Howells
2006-12-11 13:25 ` Akinobu Mita [this message]
2006-12-11 14:22 ` David Howells
2006-12-11 16:05 ` Linus Torvalds
2006-12-11 16:12 ` David Howells
2006-12-11 16:34 ` Linus Torvalds
2006-12-11 17:35 ` Jan Engelhardt
2006-12-11 17:51 ` Bernd Petrovitsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061211132540.GA4629@APFDCB5C \
--to=akinobu.mita@gmail.com \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®