* [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep
@ 2026-05-31 0:00 Rosen Penev
2026-05-31 1:21 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rosen Penev @ 2026-05-31 0:00 UTC (permalink / raw)
To: netdev
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Sebastian Andrzej Siewior, Thomas Gleixner,
open list
Add the missing @may_sleep parameter description to the
mpc52xx_fec_stop kernel-doc comment.
Fixes: c35a0824e88b ("net: fec_mpc52xx: Replace in_interrupt() usage")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/freescale/fec_mpc52xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx.c b/drivers/net/ethernet/freescale/fec_mpc52xx.c
index a770e7edb1dc..4f555bc13ddf 100644
--- a/drivers/net/ethernet/freescale/fec_mpc52xx.c
+++ b/drivers/net/ethernet/freescale/fec_mpc52xx.c
@@ -692,6 +692,7 @@ static void mpc52xx_fec_start(struct net_device *dev)
/**
* mpc52xx_fec_stop
* @dev: network device
+ * @may_sleep: whether the caller can sleep (e.g., to wait for tx drain)
*
* stop all activity on fec and empty dma buffers
*/
--
2.54.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep
2026-05-31 0:00 [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep Rosen Penev
@ 2026-05-31 1:21 ` Andrew Lunn
2026-06-01 7:08 ` Sebastian Andrzej Siewior
2026-06-02 21:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2026-05-31 1:21 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Sebastian Andrzej Siewior,
Thomas Gleixner, open list
On Sat, May 30, 2026 at 05:00:42PM -0700, Rosen Penev wrote:
> Add the missing @may_sleep parameter description to the
> mpc52xx_fec_stop kernel-doc comment.
>
> Fixes: c35a0824e88b ("net: fec_mpc52xx: Replace in_interrupt() usage")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep
2026-05-31 0:00 [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep Rosen Penev
2026-05-31 1:21 ` Andrew Lunn
@ 2026-06-01 7:08 ` Sebastian Andrzej Siewior
2026-06-02 21:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2026-06-01 7:08 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Thomas Gleixner, open list
On 2026-05-30 17:00:42 [-0700], Rosen Penev wrote:
> Add the missing @may_sleep parameter description to the
> mpc52xx_fec_stop kernel-doc comment.
>
> Fixes: c35a0824e88b ("net: fec_mpc52xx: Replace in_interrupt() usage")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep
2026-05-31 0:00 [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep Rosen Penev
2026-05-31 1:21 ` Andrew Lunn
2026-06-01 7:08 ` Sebastian Andrzej Siewior
@ 2026-06-02 21:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-02 21:40 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, andrew+netdev, davem, edumazet, kuba, pabeni, bigeasy,
tglx, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 30 May 2026 17:00:42 -0700 you wrote:
> Add the missing @may_sleep parameter description to the
> mpc52xx_fec_stop kernel-doc comment.
>
> Fixes: c35a0824e88b ("net: fec_mpc52xx: Replace in_interrupt() usage")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
>
> [...]
Here is the summary with links:
- [net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep
https://git.kernel.org/netdev/net-next/c/d20687818f46
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-02 21:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-31 0:00 [PATCH net] net: fec_mpc52xx: add missing kernel-doc for @may_sleep Rosen Penev
2026-05-31 1:21 ` Andrew Lunn
2026-06-01 7:08 ` Sebastian Andrzej Siewior
2026-06-02 21:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®