* [PATCH net] inet: frags: remove redundant assignment in inet_frag_reasm_prepare()
@ 2026-06-03 6:53 yuan.gao
2026-06-03 7:11 ` Eric Dumazet
2026-06-05 1:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: yuan.gao @ 2026-06-03 6:53 UTC (permalink / raw)
To: David Ahern, Ido Schimmel, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, netdev, linux-kernel
Cc: yuan.gao
The assignment is redundant because skb_clone() already copies skb->cb.
Remove the unnecessary code.
Signed-off-by: yuan.gao <yuan.gao@ucloud.cn>
---
net/ipv4/inet_fragment.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c
index 496308c02..6119b660a 100644
--- a/net/ipv4/inet_fragment.c
+++ b/net/ipv4/inet_fragment.c
@@ -473,7 +473,6 @@ void *inet_frag_reasm_prepare(struct inet_frag_queue *q, struct sk_buff *skb,
head = skb;
goto out_restore_sk;
}
- FRAG_CB(fp)->next_frag = FRAG_CB(skb)->next_frag;
if (RB_EMPTY_NODE(&skb->rbnode))
FRAG_CB(parent)->next_frag = fp;
else
@@ -488,7 +487,6 @@ void *inet_frag_reasm_prepare(struct inet_frag_queue *q, struct sk_buff *skb,
skb->destructor = NULL;
}
skb_morph(skb, head);
- FRAG_CB(skb)->next_frag = FRAG_CB(head)->next_frag;
rb_replace_node(&head->rbnode, &skb->rbnode,
&q->rb_fragments);
consume_skb(head);
--
2.32.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] inet: frags: remove redundant assignment in inet_frag_reasm_prepare()
2026-06-03 6:53 [PATCH net] inet: frags: remove redundant assignment in inet_frag_reasm_prepare() yuan.gao
@ 2026-06-03 7:11 ` Eric Dumazet
2026-06-05 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2026-06-03 7:11 UTC (permalink / raw)
To: yuan.gao
Cc: David Ahern, Ido Schimmel, David S. Miller, Jakub Kicinski,
Paolo Abeni, Simon Horman, netdev, linux-kernel
On Tue, Jun 2, 2026 at 11:54 PM yuan.gao <yuan.gao@ucloud.cn> wrote:
>
> The assignment is redundant because skb_clone() already copies skb->cb.
>
> Remove the unnecessary code.
>
This looks like a net-next candidate to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] inet: frags: remove redundant assignment in inet_frag_reasm_prepare()
2026-06-03 6:53 [PATCH net] inet: frags: remove redundant assignment in inet_frag_reasm_prepare() yuan.gao
2026-06-03 7:11 ` Eric Dumazet
@ 2026-06-05 1:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-06-05 1:30 UTC (permalink / raw)
To: yuan.gao
Cc: dsahern, idosch, davem, edumazet, kuba, pabeni, horms, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 3 Jun 2026 14:53:23 +0800 you wrote:
> The assignment is redundant because skb_clone() already copies skb->cb.
>
> Remove the unnecessary code.
>
> Signed-off-by: yuan.gao <yuan.gao@ucloud.cn>
> ---
> net/ipv4/inet_fragment.c | 2 --
> 1 file changed, 2 deletions(-)
Here is the summary with links:
- [net] inet: frags: remove redundant assignment in inet_frag_reasm_prepare()
https://git.kernel.org/netdev/net-next/c/831d557a3e40
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-05 1:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-03 6:53 [PATCH net] inet: frags: remove redundant assignment in inet_frag_reasm_prepare() yuan.gao
2026-06-03 7:11 ` Eric Dumazet
2026-06-05 1:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®