mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Hans de Goede <hansg@kernel.org>, Alex Hung <alexhung@gmail.com>,
	 Nikolay Metchev <nikolaymetchev@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: intel-hid: Add HP ProBook x360 440 G1 to button_array_table
Date: Wed, 10 Jun 2026 14:40:41 +0300	[thread overview]
Message-ID: <178109164158.12333.17664383272837286649.b4-ty@b4> (raw)
In-Reply-To: <20260609213309.445019-1-nikolaymetchev@gmail.com>

On Tue, 09 Jun 2026 22:33:09 +0100, Nikolay Metchev wrote:

> The volume rocker buttons on the HP ProBook x360 440 G1 convertible emit
> events 0xc4-0xc7 via the intel-hid ACPI device (INT33D5). These codes are
> only present in intel_array_keymap, which is used when the "5 button
> array" input device exists. On this machine button_array_present()
> returns false because the firmware does not advertise the array through
> the HEBC method, so notify_handler() routes the events to a NULL
> priv->array and they are dropped as "unknown event 0xc4". As a result
> the side volume keys do nothing.
> 
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: intel-hid: Add HP ProBook x360 440 G1 to button_array_table
      commit: c39023ca9a447f09c072080efc84d6874c2275c9

--
 i.


      parent reply	other threads:[~2026-06-10 11:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 13:32 [PATCH] " Nikolay Metchev
2026-06-08 12:50 ` Ilpo Järvinen
2026-06-09 21:33   ` [PATCH v2] " Nikolay Metchev
2026-06-10  8:36     ` Hans de Goede
2026-06-10 11:40     ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178109164158.12333.17664383272837286649.b4-ty@b4 \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=alexhung@gmail.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikolaymetchev@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®