mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Nikolay Metchev <nikolaymetchev@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: intel-hid: Add HP ProBook x360 440 G1 to button_array_table
Date: Mon, 8 Jun 2026 15:50:48 +0300 (EEST)	[thread overview]
Message-ID: <6f0e5451-0ce5-d4c2-8ade-3489701c9df6@linux.intel.com> (raw)
In-Reply-To: <CAMPeJfpKCV=cbxbMJen3FFfJ1J9Q7i4Wup4AZJLP4PvScmNYzg@mail.gmail.com>

On Tue, 2 Jun 2026, Nikolay Metchev wrote:

> The HP ProBook x360 440 G1 convertible sends
>  5-button-array event codes
>  (0xc4/0xc5 volume-up, 0xc6/0xc7 volume-down for the
>  side volume rocker)
>  to the intel-hid ACPI device (INT33D5), but it does
>  not advertise the
>  array through the HEBC capability method. As a result
>  button_array_present() returns false, the "Intel HID
>  5 button array"
>  input device is never created, and the rocker events
>  are dropped in
>  notify_handler() with "intel-hid INT33D5:00: unknown
>  event 0xc4".
> 
>  Add the machine to button_array_table so the 5 button
>  array input
>  device is set up, which makes the side volume rocker
>  emit
>  KEY_VOLUMEUP / KEY_VOLUMEDOWN as expected.
> 
>  Tested on an HP ProBook x360 440 G1: with
>  enable_5_button_array=1
>  (same code path as this quirk) the kernel logs
>  "platform supports 5
>  button array" and the rocker generates native
>  KEY_VOLUMEUP /
>  KEY_VOLUMEDOWN events.
> 
>  Signed-off-by: Nikolay Metchev
>  <nikolaymetchev@gmail.com>

Please send the patch inline, not as an attachment.

-- 
 i.


  reply	other threads:[~2026-06-08 12:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 13:32 Nikolay Metchev
2026-06-08 12:50 ` Ilpo Järvinen [this message]
2026-06-09 21:33   ` [PATCH v2] " Nikolay Metchev
2026-06-10  8:36     ` Hans de Goede
2026-06-10 11:40     ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f0e5451-0ce5-d4c2-8ade-3489701c9df6@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikolaymetchev@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome