mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v1] Bluetooth: qca: Add BT FW build version log
@ 2026-06-09  7:54 Xiuzhuo Shang
  2026-06-09  9:39 ` Bartosz Golaszewski
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Xiuzhuo Shang @ 2026-06-09  7:54 UTC (permalink / raw)
  To: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz
  Cc: linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li,
	xiuzhuo.shang

Printf BT FW build version log after BT FW downloaded.

Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
---
 drivers/bluetooth/btqca.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index dda76365726f..04ebe290bc78 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
 
 	hci_set_fw_info(hdev, "%s", build_label);
 
+	bt_dev_info(hdev, "QCA FW build version: %s", build_label);
+
 	kfree(build_label);
 out:
 	kfree_skb(skb);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v1] Bluetooth: qca: Add BT FW build version log
  2026-06-09  7:54 [PATCH v1] Bluetooth: qca: Add BT FW build version log Xiuzhuo Shang
@ 2026-06-09  9:39 ` Bartosz Golaszewski
  2026-06-09 10:29   ` Paul Menzel
  2026-06-10  6:42 ` [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log Xiuzhuo Shang
  2026-06-10 15:40 ` [PATCH v1] Bluetooth: qca: Add BT FW build version log patchwork-bot+bluetooth
  2 siblings, 1 reply; 15+ messages in thread
From: Bartosz Golaszewski @ 2026-06-09  9:39 UTC (permalink / raw)
  To: Xiuzhuo Shang
  Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz,
	linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li

On Tue, 9 Jun 2026 09:54:17 +0200, Xiuzhuo Shang
<xiuzhuo.shang@oss.qualcomm.com> said:
> Printf BT FW build version log after BT FW downloaded.
>
> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
> ---
>  drivers/bluetooth/btqca.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index dda76365726f..04ebe290bc78 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
>
>  	hci_set_fw_info(hdev, "%s", build_label);
>
> +	bt_dev_info(hdev, "QCA FW build version: %s", build_label);
> +
>  	kfree(build_label);
>  out:
>  	kfree_skb(skb);
> --
> 2.43.0
>
>

This string can be read from debugfs, do we need an additional message in the
kernel log?

Bart

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v1] Bluetooth: qca: Add BT FW build version log
  2026-06-09  9:39 ` Bartosz Golaszewski
@ 2026-06-09 10:29   ` Paul Menzel
  2026-06-09 10:49     ` Bartosz Golaszewski
  2026-06-10  5:49     ` Xiuzhuo Shang
  0 siblings, 2 replies; 15+ messages in thread
From: Paul Menzel @ 2026-06-09 10:29 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Xiuzhuo Shang, Marcel Holtmann, Luiz Augusto von Dentz,
	linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li

Dear Xiuzhuo, dear Bartosz


Am 09.06.26 um 11:39 schrieb Bartosz Golaszewski:
> On Tue, 9 Jun 2026 09:54:17 +0200, Xiuzhuo Shang said:
>> Printf BT FW build version log after BT FW downloaded.

Please paste the new lines, so reviewers see how it is going to look 
like. Please also document a motivation (answering Why?).

>> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
>> ---
>>   drivers/bluetooth/btqca.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> index dda76365726f..04ebe290bc78 100644
>> --- a/drivers/bluetooth/btqca.c
>> +++ b/drivers/bluetooth/btqca.c
>> @@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
>>
>>   	hci_set_fw_info(hdev, "%s", build_label);
>>
>> +	bt_dev_info(hdev, "QCA FW build version: %s", build_label);
>> +
>>   	kfree(build_label);
>>   out:
>>   	kfree_skb(skb);
> 
> This string can be read from debugfs, do we need an additional message in the
> kernel log?

In my opinion the firmware version should be part of the Linux logs, as 
that is what users share with bug reports, and you do not want to have 
several cycles collecting information. For example, currently for 
QCA6174 it’s currently:

     Bluetooth: hci0: QCA: patch rome 0x302 build 0x3e8, firmware rome 
0x302 build 0x111


Kind regards,

Paul


PS:

```
$ sudo dmesg | grep -e ath10k -e Bluetooth
[   17.880668] ath10k_pci 0000:3a:00.0: enabling device (0000 -> 0002)
[   17.883428] ath10k_pci 0000:3a:00.0: pci irq msi oper_irq_mode 2 
irq_mode 0 reset_mode 0
[   18.138972] ath10k_pci 0000:3a:00.0: qca6174 hw3.2 target 0x05030000 
chip_id 0x00340aff sub 1a56:1535
[   18.138977] ath10k_pci 0000:3a:00.0: kconfig debug 1 debugfs 1 
tracing 1 dfs 0 testmode 0
[   18.139068] ath10k_pci 0000:3a:00.0: firmware ver 
WLAN.RM.4.4.1-00309- api 6 features wowlan,ignore-otp,mfp crc32 0793bcf2
[   18.206593] ath10k_pci 0000:3a:00.0: board_file api 2 bmi_id N/A 
crc32 d2863f91
[   18.221145] Bluetooth: Core ver 2.22
[   18.221802] Bluetooth: HCI device and connection manager initialized
[   18.221807] Bluetooth: HCI socket layer initialized
[   18.221808] Bluetooth: L2CAP socket layer initialized
[   18.221813] Bluetooth: SCO socket layer initialized
[   18.258187] Bluetooth: hci0: using rampatch file: 
qca/rampatch_usb_00000302.bin
[   18.258192] Bluetooth: hci0: QCA: patch rome 0x302 build 0x3e8, 
firmware rome 0x302 build 0x111
[   18.301557] ath10k_pci 0000:3a:00.0: htt-ver 3.87 wmi-op 4 htt-op 3 
cal otp max-sta 32 raw 0 hwcrypto 1
[   18.381567] ath10k_pci 0000:3a:00.0 wlp58s0: renamed from wlan0
[   18.619003] Bluetooth: hci0: using NVM file: qca/nvm_usb_00000302.bin
[   18.643646] Bluetooth: hci0: HCI Enhanced Setup Synchronous 
Connection command is advertised, but not supported.
```

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v1] Bluetooth: qca: Add BT FW build version log
  2026-06-09 10:29   ` Paul Menzel
@ 2026-06-09 10:49     ` Bartosz Golaszewski
  2026-06-10  5:49     ` Xiuzhuo Shang
  1 sibling, 0 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2026-06-09 10:49 UTC (permalink / raw)
  To: Paul Menzel
  Cc: Xiuzhuo Shang, Marcel Holtmann, Luiz Augusto von Dentz,
	linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li,
	Bartosz Golaszewski

On Tue, 9 Jun 2026 12:29:41 +0200, Paul Menzel <pmenzel@molgen.mpg.de> said:
> Dear Xiuzhuo, dear Bartosz
>
>
> Am 09.06.26 um 11:39 schrieb Bartosz Golaszewski:
>> On Tue, 9 Jun 2026 09:54:17 +0200, Xiuzhuo Shang said:
>>> Printf BT FW build version log after BT FW downloaded.
>
> Please paste the new lines, so reviewers see how it is going to look
> like. Please also document a motivation (answering Why?).
>
>>> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
>>> ---
>>>   drivers/bluetooth/btqca.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>>> index dda76365726f..04ebe290bc78 100644
>>> --- a/drivers/bluetooth/btqca.c
>>> +++ b/drivers/bluetooth/btqca.c
>>> @@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
>>>
>>>   	hci_set_fw_info(hdev, "%s", build_label);
>>>
>>> +	bt_dev_info(hdev, "QCA FW build version: %s", build_label);
>>> +
>>>   	kfree(build_label);
>>>   out:
>>>   	kfree_skb(skb);
>>
>> This string can be read from debugfs, do we need an additional message in the
>> kernel log?
>
> In my opinion the firmware version should be part of the Linux logs, as
> that is what users share with bug reports, and you do not want to have
> several cycles collecting information. For example, currently for
> QCA6174 it’s currently:
>
>      Bluetooth: hci0: QCA: patch rome 0x302 build 0x3e8, firmware rome
> 0x302 build 0x111
>
>
> Kind regards,
>
> Paul
>
>
> PS:
>
> ```
> $ sudo dmesg | grep -e ath10k -e Bluetooth
> [   17.880668] ath10k_pci 0000:3a:00.0: enabling device (0000 -> 0002)
> [   17.883428] ath10k_pci 0000:3a:00.0: pci irq msi oper_irq_mode 2
> irq_mode 0 reset_mode 0
> [   18.138972] ath10k_pci 0000:3a:00.0: qca6174 hw3.2 target 0x05030000
> chip_id 0x00340aff sub 1a56:1535
> [   18.138977] ath10k_pci 0000:3a:00.0: kconfig debug 1 debugfs 1
> tracing 1 dfs 0 testmode 0
> [   18.139068] ath10k_pci 0000:3a:00.0: firmware ver
> WLAN.RM.4.4.1-00309- api 6 features wowlan,ignore-otp,mfp crc32 0793bcf2
> [   18.206593] ath10k_pci 0000:3a:00.0: board_file api 2 bmi_id N/A
> crc32 d2863f91
> [   18.221145] Bluetooth: Core ver 2.22
> [   18.221802] Bluetooth: HCI device and connection manager initialized
> [   18.221807] Bluetooth: HCI socket layer initialized
> [   18.221808] Bluetooth: L2CAP socket layer initialized
> [   18.221813] Bluetooth: SCO socket layer initialized
> [   18.258187] Bluetooth: hci0: using rampatch file:
> qca/rampatch_usb_00000302.bin
> [   18.258192] Bluetooth: hci0: QCA: patch rome 0x302 build 0x3e8,
> firmware rome 0x302 build 0x111
> [   18.301557] ath10k_pci 0000:3a:00.0: htt-ver 3.87 wmi-op 4 htt-op 3
> cal otp max-sta 32 raw 0 hwcrypto 1
> [   18.381567] ath10k_pci 0000:3a:00.0 wlp58s0: renamed from wlan0
> [   18.619003] Bluetooth: hci0: using NVM file: qca/nvm_usb_00000302.bin
> [   18.643646] Bluetooth: hci0: HCI Enhanced Setup Synchronous
> Connection command is advertised, but not supported.
> ```
>

Fair enough.

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v1] Bluetooth: qca: Add BT FW build version log
  2026-06-09 10:29   ` Paul Menzel
  2026-06-09 10:49     ` Bartosz Golaszewski
@ 2026-06-10  5:49     ` Xiuzhuo Shang
  1 sibling, 0 replies; 15+ messages in thread
From: Xiuzhuo Shang @ 2026-06-10  5:49 UTC (permalink / raw)
  To: Paul Menzel, Bartosz Golaszewski
  Cc: Marcel Holtmann, Luiz Augusto von Dentz, linux-arm-msm,
	linux-bluetooth, linux-kernel, cheng.jiang, quic_chezhou,
	wei.deng, shuai.zhang, mengshi.wu, jinwang.li


Hi,Paul,

On 6/9/2026 6:29 PM, Paul Menzel wrote:
> Dear Xiuzhuo, dear Bartosz
> 
> 
> Am 09.06.26 um 11:39 schrieb Bartosz Golaszewski:
>> On Tue, 9 Jun 2026 09:54:17 +0200, Xiuzhuo Shang said:
>>> Printf BT FW build version log after BT FW downloaded.
> 
> Please paste the new lines, so reviewers see how it is going to look like. Please also document a motivation (answering Why?).
Thanks for your suggestion, I will send PATCH v2.

> 
>>> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
>>> ---
>>>   drivers/bluetooth/btqca.c | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>>> index dda76365726f..04ebe290bc78 100644
>>> --- a/drivers/bluetooth/btqca.c
>>> +++ b/drivers/bluetooth/btqca.c
>>> @@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
>>>
>>>       hci_set_fw_info(hdev, "%s", build_label);
>>>
>>> +    bt_dev_info(hdev, "QCA FW build version: %s", build_label);
>>> +
>>>       kfree(build_label);
>>>   out:
>>>       kfree_skb(skb);
>>
>> This string can be read from debugfs, do we need an additional message in the
>> kernel log?
> 
> In my opinion the firmware version should be part of the Linux logs, as that is what users share with bug reports, and you do not want to have several cycles collecting information. For example, currently for QCA6174 it’s currently:
> 
>     Bluetooth: hci0: QCA: patch rome 0x302 build 0x3e8, firmware rome 0x302 build 0x111
> 
> 
> Kind regards,
> 
> Paul
> 
> 
> PS:
> 
> ```
> $ sudo dmesg | grep -e ath10k -e Bluetooth
> [   17.880668] ath10k_pci 0000:3a:00.0: enabling device (0000 -> 0002)
> [   17.883428] ath10k_pci 0000:3a:00.0: pci irq msi oper_irq_mode 2 irq_mode 0 reset_mode 0
> [   18.138972] ath10k_pci 0000:3a:00.0: qca6174 hw3.2 target 0x05030000 chip_id 0x00340aff sub 1a56:1535
> [   18.138977] ath10k_pci 0000:3a:00.0: kconfig debug 1 debugfs 1 tracing 1 dfs 0 testmode 0
> [   18.139068] ath10k_pci 0000:3a:00.0: firmware ver WLAN.RM.4.4.1-00309- api 6 features wowlan,ignore-otp,mfp crc32 0793bcf2
> [   18.206593] ath10k_pci 0000:3a:00.0: board_file api 2 bmi_id N/A crc32 d2863f91
> [   18.221145] Bluetooth: Core ver 2.22
> [   18.221802] Bluetooth: HCI device and connection manager initialized
> [   18.221807] Bluetooth: HCI socket layer initialized
> [   18.221808] Bluetooth: L2CAP socket layer initialized
> [   18.221813] Bluetooth: SCO socket layer initialized
> [   18.258187] Bluetooth: hci0: using rampatch file: qca/rampatch_usb_00000302.bin
> [   18.258192] Bluetooth: hci0: QCA: patch rome 0x302 build 0x3e8, firmware rome 0x302 build 0x111
> [   18.301557] ath10k_pci 0000:3a:00.0: htt-ver 3.87 wmi-op 4 htt-op 3 cal otp max-sta 32 raw 0 hwcrypto 1
> [   18.381567] ath10k_pci 0000:3a:00.0 wlp58s0: renamed from wlan0
> [   18.619003] Bluetooth: hci0: using NVM file: qca/nvm_usb_00000302.bin
> [   18.643646] Bluetooth: hci0: HCI Enhanced Setup Synchronous Connection command is advertised, but not supported.
> ```


^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log
  2026-06-09  7:54 [PATCH v1] Bluetooth: qca: Add BT FW build version log Xiuzhuo Shang
  2026-06-09  9:39 ` Bartosz Golaszewski
@ 2026-06-10  6:42 ` Xiuzhuo Shang
  2026-06-10  7:07   ` Bartosz Golaszewski
                     ` (2 more replies)
  2026-06-10 15:40 ` [PATCH v1] Bluetooth: qca: Add BT FW build version log patchwork-bot+bluetooth
  2 siblings, 3 replies; 15+ messages in thread
From: Xiuzhuo Shang @ 2026-06-10  6:42 UTC (permalink / raw)
  To: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz
  Cc: linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li,
	xiuzhuo.shang, Bartosz Golaszewski

Firmware version is critical for bug triage. Users reporting issues
typically share dmesg output rather than debugfs contents, requiring
extra communication rounds to collect this information. Log the FW
build version directly to the kernel log so it is immediately
available in bug reports.

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
---
Example output:
  Bluetooth: hci0: QCA FW build version: BTFW.MOSELLE.1.1.3-00106-MSL_PATCHZ-1
 drivers/bluetooth/btqca.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index dda76365726f..04ebe290bc78 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
 
 	hci_set_fw_info(hdev, "%s", build_label);
 
+	bt_dev_info(hdev, "QCA FW build version: %s", build_label);
+
 	kfree(build_label);
 out:
 	kfree_skb(skb);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log
  2026-06-10  6:42 ` [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log Xiuzhuo Shang
@ 2026-06-10  7:07   ` Bartosz Golaszewski
  2026-06-10  7:36     ` Xiuzhuo Shang
  2026-06-10 15:40   ` patchwork-bot+bluetooth
  2026-06-10 20:54   ` Paul Menzel
  2 siblings, 1 reply; 15+ messages in thread
From: Bartosz Golaszewski @ 2026-06-10  7:07 UTC (permalink / raw)
  To: Xiuzhuo Shang
  Cc: linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li,
	Bartosz Golaszewski, Bartosz Golaszewski, Marcel Holtmann,
	Luiz Augusto von Dentz

On Wed, 10 Jun 2026 08:42:32 +0200, Xiuzhuo Shang
<xiuzhuo.shang@oss.qualcomm.com> said:
> Firmware version is critical for bug triage. Users reporting issues
> typically share dmesg output rather than debugfs contents, requiring
> extra communication rounds to collect this information. Log the FW
> build version directly to the kernel log so it is immediately
> available in bug reports.
>
> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
> ---

Please don't send a new version if all you did is collected a single tag.

Bart

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log
  2026-06-10  7:07   ` Bartosz Golaszewski
@ 2026-06-10  7:36     ` Xiuzhuo Shang
  2026-06-10  8:17       ` Bartosz Golaszewski
  2026-06-12  7:42       ` Dmitry Baryshkov
  0 siblings, 2 replies; 15+ messages in thread
From: Xiuzhuo Shang @ 2026-06-10  7:36 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li,
	Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz

Hi Bart,

The main change in v2 was the commit message — I added the motivation and an example log line as

Paul requested on v1. Carrying your Acked-by (given on v1) forward was just to avoid losing it. So

v2 wasn't sent solely to collect a tag.


Thanks,

Xiuzhuo
 

On 6/10/2026 3:07 PM, Bartosz Golaszewski wrote:
> On Wed, 10 Jun 2026 08:42:32 +0200, Xiuzhuo Shang
> <xiuzhuo.shang@oss.qualcomm.com> said:
>> Firmware version is critical for bug triage. Users reporting issues
>> typically share dmesg output rather than debugfs contents, requiring
>> extra communication rounds to collect this information. Log the FW
>> build version directly to the kernel log so it is immediately
>> available in bug reports.
>>
>> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
>> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
>> ---
> 
> Please don't send a new version if all you did is collected a single tag.
> 
> Bart


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log
  2026-06-10  7:36     ` Xiuzhuo Shang
@ 2026-06-10  8:17       ` Bartosz Golaszewski
  2026-06-12  7:42       ` Dmitry Baryshkov
  1 sibling, 0 replies; 15+ messages in thread
From: Bartosz Golaszewski @ 2026-06-10  8:17 UTC (permalink / raw)
  To: Xiuzhuo Shang
  Cc: linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li,
	Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz

On Wed, Jun 10, 2026 at 9:36 AM Xiuzhuo Shang
<xiuzhuo.shang@oss.qualcomm.com> wrote:
>
> Hi Bart,
>
> The main change in v2 was the commit message — I added the motivation and an example log line as
>
> Paul requested on v1. Carrying your Acked-by (given on v1) forward was just to avoid losing it. So
>
> v2 wasn't sent solely to collect a tag.
>

Well, I don't know it because you didn't add a changelog to v2. Please
add something like "Changes in v2:" in the future.

Bartosz

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v1] Bluetooth: qca: Add BT FW build version log
  2026-06-09  7:54 [PATCH v1] Bluetooth: qca: Add BT FW build version log Xiuzhuo Shang
  2026-06-09  9:39 ` Bartosz Golaszewski
  2026-06-10  6:42 ` [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log Xiuzhuo Shang
@ 2026-06-10 15:40 ` patchwork-bot+bluetooth
  2 siblings, 0 replies; 15+ messages in thread
From: patchwork-bot+bluetooth @ 2026-06-10 15:40 UTC (permalink / raw)
  To: Xiuzhuo Shang
  Cc: brgl, marcel, luiz.dentz, linux-arm-msm, linux-bluetooth,
	linux-kernel, cheng.jiang, quic_chezhou, wei.deng, shuai.zhang,
	mengshi.wu, jinwang.li

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  9 Jun 2026 15:54:17 +0800 you wrote:
> Printf BT FW build version log after BT FW downloaded.
> 
> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
> ---
>  drivers/bluetooth/btqca.c | 2 ++
>  1 file changed, 2 insertions(+)

Here is the summary with links:
  - [v1] Bluetooth: qca: Add BT FW build version log
    https://git.kernel.org/bluetooth/bluetooth-next/c/559cab24b04e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log
  2026-06-10  6:42 ` [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log Xiuzhuo Shang
  2026-06-10  7:07   ` Bartosz Golaszewski
@ 2026-06-10 15:40   ` patchwork-bot+bluetooth
  2026-06-10 20:54   ` Paul Menzel
  2 siblings, 0 replies; 15+ messages in thread
From: patchwork-bot+bluetooth @ 2026-06-10 15:40 UTC (permalink / raw)
  To: Xiuzhuo Shang
  Cc: brgl, marcel, luiz.dentz, linux-arm-msm, linux-bluetooth,
	linux-kernel, cheng.jiang, quic_chezhou, wei.deng, shuai.zhang,
	mengshi.wu, jinwang.li, bartosz.golaszewski

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 10 Jun 2026 14:42:32 +0800 you wrote:
> Firmware version is critical for bug triage. Users reporting issues
> typically share dmesg output rather than debugfs contents, requiring
> extra communication rounds to collect this information. Log the FW
> build version directly to the kernel log so it is immediately
> available in bug reports.
> 
> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
> 
> [...]

Here is the summary with links:
  - [v2] Bluetooth: qca: Add BT FW build version to kernel log
    https://git.kernel.org/bluetooth/bluetooth-next/c/559cab24b04e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log
  2026-06-10  6:42 ` [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log Xiuzhuo Shang
  2026-06-10  7:07   ` Bartosz Golaszewski
  2026-06-10 15:40   ` patchwork-bot+bluetooth
@ 2026-06-10 20:54   ` Paul Menzel
  2026-06-11  2:51     ` Xiuzhuo Shang
  2 siblings, 1 reply; 15+ messages in thread
From: Paul Menzel @ 2026-06-10 20:54 UTC (permalink / raw)
  To: Xiuzhuo Shang
  Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz,
	linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li,
	Bartosz Golaszewski

Dear Xiuzhuo,


Thank you for the patch, which was applied today.

Am 10.06.26 um 08:42 schrieb Xiuzhuo Shang:
> Firmware version is critical for bug triage. Users reporting issues
> typically share dmesg output rather than debugfs contents, requiring
> extra communication rounds to collect this information. Log the FW
> build version directly to the kernel log so it is immediately
> available in bug reports.
> 
> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
> ---
> Example output:
>    Bluetooth: hci0: QCA FW build version: BTFW.MOSELLE.1.1.3-00106-MSL_PATCHZ-1

Please put it in the commit message next time.

Also, just for completeness, could you please paste all the 
Bluetooth/hci0/QCA logs, so that maybe a more condensed logging format 
can be found?

>   drivers/bluetooth/btqca.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index dda76365726f..04ebe290bc78 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
>   
>   	hci_set_fw_info(hdev, "%s", build_label);
>   
> +	bt_dev_info(hdev, "QCA FW build version: %s", build_label);
> +
>   	kfree(build_label);
>   out:
>   	kfree_skb(skb);


Kind regards,

Paul

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log
  2026-06-10 20:54   ` Paul Menzel
@ 2026-06-11  2:51     ` Xiuzhuo Shang
  0 siblings, 0 replies; 15+ messages in thread
From: Xiuzhuo Shang @ 2026-06-11  2:51 UTC (permalink / raw)
  To: Paul Menzel
  Cc: Bartosz Golaszewski, Marcel Holtmann, Luiz Augusto von Dentz,
	linux-arm-msm, linux-bluetooth, linux-kernel, cheng.jiang,
	quic_chezhou, wei.deng, shuai.zhang, mengshi.wu, jinwang.li,
	Bartosz Golaszewski



On 6/11/2026 4:54 AM, Paul Menzel wrote:
> Dear Xiuzhuo,
> 
> 
> Thank you for the patch, which was applied today.
> 
> Am 10.06.26 um 08:42 schrieb Xiuzhuo Shang:
>> Firmware version is critical for bug triage. Users reporting issues
>> typically share dmesg output rather than debugfs contents, requiring
>> extra communication rounds to collect this information. Log the FW
>> build version directly to the kernel log so it is immediately
>> available in bug reports.
>>
>> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
>> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
>> ---
>> Example output:
>>    Bluetooth: hci0: QCA FW build version: BTFW.MOSELLE.1.1.3-00106-MSL_PATCHZ-1
> 
> Please put it in the commit message next time.
> 
> Also, just for completeness, could you please paste all the Bluetooth/hci0/QCA logs, so that maybe a more condensed logging format can be found?

Hi,Paul,
Thanks for your suggestion. 

root@rb3gen2-core-kit:/# dmesg | grep -iE "bluetooth|hci|wcn|btqca|btfm|rfkill"
[    5.159228] sdhci_msm 8804000.mmc: Got CD GPIO
[    5.219919] mmc2: SDHCI controller on 8804000.mmc [8804000.mmc] using ADMA 64-bit
[   11.806187] ath11k 17a10040.wifi: wcn6750 hw1.0
[   11.818575] ath11k 17a10040.wifi: wcn6750 hw1.0
[   11.823714] ath11k 17a10040.wifi: wcn6750 hw1.0
[   20.284824] pci 0001:04:00.0: xHCI HW not ready after 5 sec (HC bug?) status = 0x801
[   20.338018] Bluetooth: Core ver 2.22
[   20.341805] NET: Registered PF_BLUETOOTH protocol family
[   20.347310] Bluetooth: HCI device and connection manager initialized
[   20.347327] Bluetooth: HCI socket layer initialized
[   20.347333] Bluetooth: L2CAP socket layer initialized
[   20.347352] Bluetooth: SCO socket layer initialized
[   20.479734] Bluetooth: HCI UART driver ver 2.3
[   20.496850] Bluetooth: HCI UART protocol H4 registered
[   20.515949] Bluetooth: HCI UART protocol LL registered
[   20.516004] Bluetooth: HCI UART protocol QCA registered
[   20.528204] Bluetooth: hci0: setting up wcn6750
[   20.699447] Modules linked in: iris_vpu(O+) nf_conntrack audioreach_driver(O) qcom_pbs nf_defrag_ipv6 v4l2_mem2mem videobuf2_v4l2 snd_q6dsp_common qcom_spmi_temp_alarm qcom_spmi_adc_tm5 nf_defrag_ipv4 qcom_spmi_adc5 rtc_pm8xxx qcom_pon nvmem_qcom_spmi_sdam videobuf2_common qcom_vadc_common videodev iptable_filter hci_uart ip_tables btqca gpio_shared_proxy x_tables apr mc msm_kgsl(O+) pwrseq_qcom_wcn videocc_sc7280 phy_qcom_qmp_combo dispcc_sc7280 coresight_stm camcc_sc7280 qcom_refgen_regulator qcom_stats spi_geni_qcom dwc3_qcom usb_f_fs aux_bridge stm_p_basic msm typec gpi phy_qcom_snps_femto_v2 qcom_eud icc_bwmon bluetooth stm_core bridge ubwc_config coresight_cti coresight_tpdm ecdh_generic stp kpp llc overlay ecc libcomposite ath11k_ahb llcc_qcom ath11k snd_soc_lpass_va_macro snd_soc_lpass_wsa_macro ocmem mac80211 qcom_q6v5_pas soundwire_qcom snd_soc_lpass_macro_common coresight_replicator gpu_sched qcom_pil_info libarc4 coresight_tmc qcom_q6v5 drm_gpuvm snd_soc_core snd_compress coresight_etm4x qcom_sysmon
[   20.791274]  coresight_funnel qrtr gpucc_sc7280 qcrypto drm_display_helper snd_pcm qcom_common sha256 snd_timer cec qcom_glink_smem coresight pmic_glink sha1 soundwire_bus lpassaudiocc_sc7280 snd drm_dp_aux_bus mdt_loader libdes pdr_interface pinctrl_sc7280_lpass_lpi cfg80211 drm_client_lib soundcore qcom_pdr_msg authenc pinctrl_lpass_lpi slimbus pci_pwrctrl_tc9563 rfkill icc_osm_l3 socinfo qmi_helpers display_connector drm_kms_helper qcom_rng nvmem_reboot_mode sch_fq_codel fuse
[   21.170589] xhci-pci-renesas 0001:04:00.0: failed to load firmware renesas_usb_fw.mem: -2
[   21.213198] xhci-pci-renesas 0001:04:00.0: probe with driver xhci-pci-renesas failed with error -2
[   22.627369] Bluetooth: hci0: command 0xfc00 tx timeout
[   22.639919] Bluetooth: hci0: Reading QCA version information failed (-110)
[   22.652097] Bluetooth: hci0: Retry BT power ON:0
[   22.706596] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[   22.719197] Bluetooth: BNEP filters: protocol multicast
[   22.719204] Bluetooth: BNEP socket layer initialized
[   23.123401] Bluetooth: hci0: QCA Product ID   :0x00000015
[   23.132217] Bluetooth: hci0: QCA SOC Version  :0x40140110
[   23.150091] Bluetooth: hci0: QCA ROM Version  :0x00000101
[   23.155714] Bluetooth: hci0: QCA Patch Version:0x000024c7
[   23.165303] Bluetooth: hci0: QCA controller version 0x01100101
[   23.172966] Bluetooth: hci0: QCA Downloading qca/msbtfw11.mbn
[   24.193137] Bluetooth: hci0: QCA Downloading qca/msnv11.bin
[   24.325620] Bluetooth: hci0: QCA FW build version: BTFW.MOSELLE.1.1.3-00106-MSL_PATCHZ-1
[   24.335237] Bluetooth: hci0: QCA setup on UART is completed
[  287.493900] Bluetooth: MGMT ver 1.23
[  287.498546] Bluetooth: hci0: setting up wcn6750
[  287.562270] Bluetooth: hci0: QCA Product ID   :0x00000015
[  287.567880] Bluetooth: hci0: QCA SOC Version  :0x40140110
[  287.573507] Bluetooth: hci0: QCA ROM Version  :0x00000101
[  287.579290] Bluetooth: hci0: QCA Patch Version:0x000024c
[  287.596249] Bluetooth: hci0: QCA controller version 0x01100101
[  287.602763] Bluetooth: hci0: QCA Downloading qca/msbtfw11.mbn
[  288.629814] Bluetooth: hci0: QCA Downloading qca/msnv11.bin
[  288.751030] Bluetooth: hci0: QCA FW build version: BTFW.MOSELLE.1.1.3-00106-MSL_PATCHZ-1
[  288.759441] Bluetooth: hci0: QCA setup on UART is completed
[  288.834672] Bluetooth: RFCOMM TTY layer initialized
[  288.839721] Bluetooth: RFCOMM socket layer initialized
[  288.845032] Bluetooth: RFCOMM ver 1.11

> 
>>   drivers/bluetooth/btqca.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
>> index dda76365726f..04ebe290bc78 100644
>> --- a/drivers/bluetooth/btqca.c
>> +++ b/drivers/bluetooth/btqca.c
>> @@ -143,6 +143,8 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
>>         hci_set_fw_info(hdev, "%s", build_label);
>>   +    bt_dev_info(hdev, "QCA FW build version: %s", build_label);
>> +
>>       kfree(build_label);
>>   out:
>>       kfree_skb(skb);
> 
> 
> Kind regards,
> 
> Paul


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log
  2026-06-10  7:36     ` Xiuzhuo Shang
  2026-06-10  8:17       ` Bartosz Golaszewski
@ 2026-06-12  7:42       ` Dmitry Baryshkov
  2026-06-15  3:27         ` Xiuzhuo Shang
  1 sibling, 1 reply; 15+ messages in thread
From: Dmitry Baryshkov @ 2026-06-12  7:42 UTC (permalink / raw)
  To: Xiuzhuo Shang
  Cc: Bartosz Golaszewski, linux-arm-msm, linux-bluetooth,
	linux-kernel, cheng.jiang, quic_chezhou, wei.deng, shuai.zhang,
	mengshi.wu, jinwang.li, Bartosz Golaszewski, Marcel Holtmann,
	Luiz Augusto von Dentz

On Wed, Jun 10, 2026 at 03:36:46PM +0800, Xiuzhuo Shang wrote:
> Hi Bart,
> 
> The main change in v2 was the commit message — I added the motivation and an example log line as
> 
> Paul requested on v1. Carrying your Acked-by (given on v1) forward was just to avoid losing it. So
> 
> v2 wasn't sent solely to collect a tag.

Please don't send new revisions as a response to the previous
iterations. Also don't top-post. Responses should go below the questions
/ comments they are intended to answer.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>



> 
> 
> Thanks,
> 
> Xiuzhuo
>  
> 
> On 6/10/2026 3:07 PM, Bartosz Golaszewski wrote:
> > On Wed, 10 Jun 2026 08:42:32 +0200, Xiuzhuo Shang
> > <xiuzhuo.shang@oss.qualcomm.com> said:
> >> Firmware version is critical for bug triage. Users reporting issues
> >> typically share dmesg output rather than debugfs contents, requiring
> >> extra communication rounds to collect this information. Log the FW
> >> build version directly to the kernel log so it is immediately
> >> available in bug reports.
> >>
> >> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> >> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
> >> ---
> > 
> > Please don't send a new version if all you did is collected a single tag.
> > 
> > Bart
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log
  2026-06-12  7:42       ` Dmitry Baryshkov
@ 2026-06-15  3:27         ` Xiuzhuo Shang
  0 siblings, 0 replies; 15+ messages in thread
From: Xiuzhuo Shang @ 2026-06-15  3:27 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: Bartosz Golaszewski, linux-arm-msm, linux-bluetooth,
	linux-kernel, cheng.jiang, quic_chezhou, wei.deng, shuai.zhang,
	mengshi.wu, jinwang.li, Bartosz Golaszewski, Marcel Holtmann,
	Luiz Augusto von Dentz



On 6/12/2026 3:42 PM, Dmitry Baryshkov wrote:
> On Wed, Jun 10, 2026 at 03:36:46PM +0800, Xiuzhuo Shang wrote:
>> Hi Bart,
>>
>> The main change in v2 was the commit message — I added the motivation and an example log line as
>>
>> Paul requested on v1. Carrying your Acked-by (given on v1) forward was just to avoid losing it. So
>>
>> v2 wasn't sent solely to collect a tag.
> 
> Please don't send new revisions as a response to the previous
> iterations. Also don't top-post. Responses should go below the questions
> / comments they are intended to answer.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

Got it, thanks for your suggestions.
> 
> 
> 
>>
>>
>> Thanks,
>>
>> Xiuzhuo
>>  
>>
>> On 6/10/2026 3:07 PM, Bartosz Golaszewski wrote:
>>> On Wed, 10 Jun 2026 08:42:32 +0200, Xiuzhuo Shang
>>> <xiuzhuo.shang@oss.qualcomm.com> said:
>>>> Firmware version is critical for bug triage. Users reporting issues
>>>> typically share dmesg output rather than debugfs contents, requiring
>>>> extra communication rounds to collect this information. Log the FW
>>>> build version directly to the kernel log so it is immediately
>>>> available in bug reports.
>>>>
>>>> Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
>>>> Signed-off-by: Xiuzhuo Shang <xiuzhuo.shang@oss.qualcomm.com>
>>>> ---
>>>
>>> Please don't send a new version if all you did is collected a single tag.
>>>
>>> Bart
>>
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2026-06-15  3:27 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-09  7:54 [PATCH v1] Bluetooth: qca: Add BT FW build version log Xiuzhuo Shang
2026-06-09  9:39 ` Bartosz Golaszewski
2026-06-09 10:29   ` Paul Menzel
2026-06-09 10:49     ` Bartosz Golaszewski
2026-06-10  5:49     ` Xiuzhuo Shang
2026-06-10  6:42 ` [PATCH v2] Bluetooth: qca: Add BT FW build version to kernel log Xiuzhuo Shang
2026-06-10  7:07   ` Bartosz Golaszewski
2026-06-10  7:36     ` Xiuzhuo Shang
2026-06-10  8:17       ` Bartosz Golaszewski
2026-06-12  7:42       ` Dmitry Baryshkov
2026-06-15  3:27         ` Xiuzhuo Shang
2026-06-10 15:40   ` patchwork-bot+bluetooth
2026-06-10 20:54   ` Paul Menzel
2026-06-11  2:51     ` Xiuzhuo Shang
2026-06-10 15:40 ` [PATCH v1] Bluetooth: qca: Add BT FW build version log patchwork-bot+bluetooth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome