[PATCH 0/2] media: i2c: ov08d10: fixups for reset and power management support

[PATCH 0/2] media: i2c: ov08d10: fixups for reset and power management support

[Matthias Fend]

Two minor improvements for OV08D10 image sensor driver that have already
been discussed, but which don't address any known functional issues.

These changes were already submitted as a fixup commit for the original
patch, but this wasn't applied before the merge. Therefore, here they are
again as separate commits.

Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
---
Matthias Fend (2):
      media: i2c: ov08d10: unconditionally use the startup delay
      media: i2c: ov08d10: respect 80 char line limit

 drivers/media/i2c/ov08d10.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
---
base-commit: 06cb687a5132fcffe624c0070576ab852ac6b568
change-id: 20260618-ov08d10-fixes-e03096cd7669

Best regards,
-- 
Matthias Fend <matthias.fend@emfend.at>

[PATCH 1/2] media: i2c: ov08d10: unconditionally use the startup delay

[Matthias Fend]

Even though the datasheet does not describe the timings for operation
without a dedicated hardware reset, it seems sensible to wait for the
"XSHUTDN pull up to SCCB start" time even if no reset line is available.

Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
---
 drivers/media/i2c/ov08d10.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/ov08d10.c
index 9adef5446a61f3204fb809ca3f077c1afb5f7a47..cb7e55b168781dfeaae553734d24208a374fce9c 100644
--- a/drivers/media/i2c/ov08d10.c
+++ b/drivers/media/i2c/ov08d10.c
@@ -1358,11 +1358,11 @@ static int ov08d10_power_on(struct device *dev)
 		fsleep(5 * USEC_PER_MSEC);
 
 		reset_control_deassert(ov08d10->reset);
-
-		/* Delay from XSHUTDN pull up to SCCB start: 8ms */
-		fsleep(8 * USEC_PER_MSEC);
 	}
 
+	/* Delay from XSHUTDN pull up to SCCB start: 8ms */
+	fsleep(8 * USEC_PER_MSEC);
+
 	return 0;
 }
 

-- 
2.34.1

Re: [PATCH 1/2] media: i2c: ov08d10: unconditionally use the startup delay

[Kieran Bingham]

Quoting Matthias Fend (2026-06-18 10:31:12)
> Even though the datasheet does not describe the timings for operation
> without a dedicated hardware reset, it seems sensible to wait for the
> "XSHUTDN pull up to SCCB start" time even if no reset line is available.
> 
> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
> ---
>  drivers/media/i2c/ov08d10.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/ov08d10.c
> index 9adef5446a61f3204fb809ca3f077c1afb5f7a47..cb7e55b168781dfeaae553734d24208a374fce9c 100644
> --- a/drivers/media/i2c/ov08d10.c
> +++ b/drivers/media/i2c/ov08d10.c
> @@ -1358,11 +1358,11 @@ static int ov08d10_power_on(struct device *dev)
>                 fsleep(5 * USEC_PER_MSEC);
>  
>                 reset_control_deassert(ov08d10->reset);
> -
> -               /* Delay from XSHUTDN pull up to SCCB start: 8ms */
> -               fsleep(8 * USEC_PER_MSEC);
>         }
>  
> +       /* Delay from XSHUTDN pull up to SCCB start: 8ms */

8 ms seems like a long delay at startup... but it was preceeding this
patch anyway.

If there's no hardware reset line, then I'd expect the module to have
tied that in - so I expect the delay is still required too.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> +       fsleep(8 * USEC_PER_MSEC);
> +
>         return 0;
>  }
>  
> 
> -- 
> 2.34.1
>

[PATCH 2/2] media: i2c: ov08d10: respect 80 char line limit

[Matthias Fend]

Fix a violation of the preferred line limit of 80 characters.

Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
---
 drivers/media/i2c/ov08d10.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/ov08d10.c
index cb7e55b168781dfeaae553734d24208a374fce9c..da517eb2181b83ed2ad786bd5e197fe755a47ada 100644
--- a/drivers/media/i2c/ov08d10.c
+++ b/drivers/media/i2c/ov08d10.c
@@ -1515,7 +1515,8 @@ static int ov08d10_probe(struct i2c_client *client)
 		return ret;
 	}
 
-	ov08d10->reset = devm_reset_control_get_optional_exclusive(ov08d10->dev, NULL);
+	ov08d10->reset = devm_reset_control_get_optional_exclusive(ov08d10->dev,
+								   NULL);
 	if (IS_ERR(ov08d10->reset))
 		return dev_err_probe(ov08d10->dev, PTR_ERR(ov08d10->reset),
 				     "failed to get reset\n");

-- 
2.34.1

Re: [PATCH 2/2] media: i2c: ov08d10: respect 80 char line limit

[Kieran Bingham]

Quoting Matthias Fend (2026-06-18 10:31:13)
> Fix a violation of the preferred line limit of 80 characters.
> 

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
> ---
>  drivers/media/i2c/ov08d10.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov08d10.c b/drivers/media/i2c/ov08d10.c
> index cb7e55b168781dfeaae553734d24208a374fce9c..da517eb2181b83ed2ad786bd5e197fe755a47ada 100644
> --- a/drivers/media/i2c/ov08d10.c
> +++ b/drivers/media/i2c/ov08d10.c
> @@ -1515,7 +1515,8 @@ static int ov08d10_probe(struct i2c_client *client)
>                 return ret;
>         }
>  
> -       ov08d10->reset = devm_reset_control_get_optional_exclusive(ov08d10->dev, NULL);
> +       ov08d10->reset = devm_reset_control_get_optional_exclusive(ov08d10->dev,
> +                                                                  NULL);
>         if (IS_ERR(ov08d10->reset))
>                 return dev_err_probe(ov08d10->dev, PTR_ERR(ov08d10->reset),
>                                      "failed to get reset\n");
> 
> -- 
> 2.34.1
>