mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tristan Madani <tristmd@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Tristan Madani <tristan@talencesecurity.com>
Subject: Re: [PATCH v2] profiling: don't free prof_cpu_mask on init failure
Date: Mon, 22 Jun 2026 18:28:45 -0000	[thread overview]
Message-ID: <178215292501.1603617.6905680542049189509@gmail.com> (raw)
In-Reply-To: <fb12bd4b-58e0-4d78-a725-7e2d44b6350c@I-love.SAKURA.ne.jp>

On 2026/06/22 20:32, Tetsuo Handa wrote:
> Why 22b8ce94708f ? That commit did not add free_cpumask_var().
> Since free_cpumask_var() was removed by 7c51f7bbf057, your patch might want
> explanation about why you choose to only avoid UAF-read for stable kernels
> instead of try to apply 7c51f7bbf057.

Thanks for the review. You're right, the Fixes tag should be
c309b917cab5 ("cpumask: convert kernel/profile.c").

I went with the minimal fix you suggested since 7c51f7bbf057 touches
two files and adds serialization, which felt heavier for a stable
backport.

Would a v3 with the corrected Fixes tag and a note explaining the
choice over 7c51f7bbf057 work, or would you prefer to just Cc stable
on your commit?

Tristan

  reply	other threads:[~2026-06-22 18:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-21 19:23 [PATCH] profiling: prevent stale prof_cpu_mask access " Tristan Madani
2026-06-21 22:49 ` Tetsuo Handa
2026-06-21 23:45   ` Tristan Madani
2026-06-22  0:00 ` [PATCH v2] profiling: don't free prof_cpu_mask " Tristan Madani
2026-06-22 11:32   ` Tetsuo Handa
2026-06-22 18:28     ` Tristan Madani [this message]
2026-06-22 22:50       ` Tetsuo Handa
2026-06-25  1:11   ` Andrew Morton
2026-06-26 15:36     ` Tristan Madani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178215292501.1603617.6905680542049189509@gmail.com \
    --to=tristmd@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=stable@vger.kernel.org \
    --cc=tristan@talencesecurity.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®