mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Vincent Guittot" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: sched/core] sched/fair: Set next buddy for preempt short
Date: Tue, 30 Jun 2026 09:03:46 -0000	[thread overview]
Message-ID: <178281022631.3843924.15673295909496337278.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260624151229.1710703-2-vincent.guittot@linaro.org>

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     8f97b627ff1c9b0f2eba71b326ac09326bf6b4ea
Gitweb:        https://git.kernel.org/tip/8f97b627ff1c9b0f2eba71b326ac09326bf6b4ea
Author:        Vincent Guittot <vincent.guittot@linaro.org>
AuthorDate:    Wed, 24 Jun 2026 17:12:24 +02:00
Committer:     Peter Zijlstra <peterz@infradead.org>
CommitterDate: Tue, 30 Jun 2026 10:56:54 +02:00

sched/fair: Set next buddy for preempt short

If a shorter slice task can preempt current at wakeup, we make sure that
the decision will not be overwritten in between by setting the task as the
next buddy. This still implies that the waking task remains eligible when
the scheduler will actually pick the next task to run.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
Link: https://patch.msgid.link/20260624151229.1710703-2-vincent.guittot@linaro.org
---
 kernel/sched/fair.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 90d7f83..976cc3c 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -9757,6 +9757,15 @@ static inline bool set_preempt_buddy(struct cfs_rq *cfs_rq, struct sched_entity 
 	return true;
 }
 
+static inline bool set_short_buddy(struct cfs_rq *cfs_rq, struct sched_entity *pse)
+{
+	if (cfs_rq->next && cfs_rq->next->slice < pse->slice)
+		return false;
+
+	set_next_buddy(cfs_rq, pse);
+	return true;
+}
+
 /*
  * WF_SYNC|WF_TTWU indicates the waker expects to sleep but it is not
  * strictly enforced because the hint is either misunderstood or
@@ -9931,7 +9940,7 @@ pick:
 preempt:
 	if (preempt_action == PREEMPT_WAKEUP_SHORT) {
 		cancel_protect_slice(se);
-		clear_buddies(cfs_rq, se);
+		set_short_buddy(cfs_rq, pse);
 	}
 
 	resched_curr_lazy(rq);

  parent reply	other threads:[~2026-06-30  9:03 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-24 15:12 [PATCH 0/6 v3] sched/eevdf: Improve scheduling latency of short slice task Vincent Guittot
2026-06-24 15:12 ` [PATCH 1/6 v3] sched/fair: Set next buddy for preempt short Vincent Guittot
2026-06-25  6:24   ` K Prateek Nayak
2026-06-25 12:40     ` Vincent Guittot
2026-06-25 12:43       ` Peter Zijlstra
2026-06-26  6:54       ` Peter Zijlstra
2026-06-26  7:02         ` Vincent Guittot
2026-06-26  8:08           ` Peter Zijlstra
2026-06-26  8:55             ` Vincent Guittot
2026-06-30  9:03   ` tip-bot2 for Vincent Guittot [this message]
2026-06-24 15:12 ` [PATCH 2/6 v3] sched/eevdf: Take into account current's lag when updating slice protection Vincent Guittot
2026-06-30  9:03   ` [tip: sched/core] " tip-bot2 for Vincent Guittot
2026-06-24 15:12 ` [PATCH 3/6 v3] sched/eevdf: Update slice protection even when resched is already set Vincent Guittot
2026-06-26  7:21   ` Peter Zijlstra
2026-06-26  7:46     ` Peter Zijlstra
2026-06-30  9:03       ` [tip: sched/core] sched/core: Fix inter-class wakeup_preempt() tip-bot2 for Peter Zijlstra
2026-06-30  9:03   ` [tip: sched/core] sched/eevdf: Update slice protection even when resched is already set tip-bot2 for Vincent Guittot
2026-06-24 15:12 ` [PATCH 4/6 v3] sched/eevdf: Cancel slice protection if short slice task is eligible Vincent Guittot
2026-06-25  6:00   ` K Prateek Nayak
2026-06-25 12:40     ` Vincent Guittot
2026-06-26  5:51       ` Shubhang Kaushik
2026-06-26  7:39         ` Vincent Guittot
2026-06-30  9:03   ` [tip: sched/core] " tip-bot2 for Vincent Guittot
2026-06-24 15:12 ` [PATCH 5/6 v3] sched/eevdf: Always update slice protection Vincent Guittot
2026-06-30  9:03   ` [tip: sched/core] " tip-bot2 for Vincent Guittot
2026-06-24 15:12 ` [PATCH 6/6 v3] sched/eevdf: Speedup short slice task scheduling Vincent Guittot
2026-06-25  7:37   ` K Prateek Nayak
2026-06-25  8:37     ` Peter Zijlstra
2026-06-25 10:09       ` Peter Zijlstra
2026-06-25 12:57         ` Vincent Guittot
2026-06-25 12:59           ` Vincent Guittot
2026-06-25 22:28             ` Peter Zijlstra
2026-06-26  3:57               ` K Prateek Nayak
2026-06-26  6:41                 ` Peter Zijlstra
2026-06-26  7:05                 ` Vincent Guittot
2026-06-26  7:18                   ` Peter Zijlstra
2026-06-26  7:54                     ` Peter Zijlstra
2026-06-26  8:55                       ` Vincent Guittot
2026-06-26 13:55                         ` Vincent Guittot
2026-06-29 14:25                           ` Vincent Guittot
2026-06-25 14:55       ` Vincent Guittot
2026-06-25 12:51     ` Vincent Guittot
2026-06-25  8:33   ` Peter Zijlstra
2026-06-30  9:03   ` [tip: sched/core] " tip-bot2 for Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178281022631.3843924.15673295909496337278.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®