From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Hans de Goede <hansg@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Daniel Gibson <daniel@gibson.sh>
Cc: kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/1] platform/x86/amd/pmc: Avoid logging "(null)" for DMI values
Date: Fri, 03 Jul 2026 16:42:37 +0300 [thread overview]
Message-ID: <178308615726.25771.14949789172723746192.b4-ty@b4> (raw)
In-Reply-To: <20260626220210.1761783-2-daniel@gibson.sh>
On Sat, 27 Jun 2026 00:02:10 +0200, Daniel Gibson wrote:
> dmi_get_system_info(...) can return NULL. Using that as %s arguments
> of dev_info() would log "(null)" (as part of a message like
> '... System Vendor: "(null)", Product Name: "(null)" ...'), which may
> be confusing for users.
>
> Use Elvis operator to print "(Unknown)" instead.
>
> [...]
Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86/amd/pmc: Avoid logging "(null)" for DMI values
commit: a0738abd042f7406edd2175a819cf2e66388ed97
--
i.
prev parent reply other threads:[~2026-07-03 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-26 22:02 [PATCH 0/1] amd_pmc: Avoid "(null)" in log message Daniel Gibson
2026-06-26 22:02 ` [PATCH 1/1] platform/x86/amd/pmc: Avoid logging "(null)" for DMI values Daniel Gibson
2026-07-03 13:42 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178308615726.25771.14949789172723746192.b4-ty@b4 \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=daniel@gibson.sh \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®