mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Gibson <daniel@gibson.sh>
To: "Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Daniel Gibson <daniel@gibson.sh>
Subject: [PATCH 0/1] amd_pmc: Avoid "(null)" in log message
Date: Sat, 27 Jun 2026 00:02:09 +0200	[thread overview]
Message-ID: <20260626220210.1761783-1-daniel@gibson.sh> (raw)

The kernel test robot complained that dmi_get_system_info(...) is used
for %s arguments of a dev_info() call, because it can return NULL.
That would lead to "(null)" being printed in those messages.

Ilpo Järvinen suggested using the Elvis operator to print something
that is more informative for normal users. Now "(Unknown)" is printed
instead.

See: https://lore.kernel.org/all/202606251540.Nr2BtaNu-lkp@intel.com/T/#u

Daniel Gibson (1):
  platform/x86/amd/pmc: Avoid logging "(null)" for DMI values

 drivers/platform/x86/amd/pmc/pmc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

-- 
2.48.1


             reply	other threads:[~2026-06-26 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-26 22:02 Daniel Gibson [this message]
2026-06-26 22:02 ` [PATCH 1/1] platform/x86/amd/pmc: Avoid logging "(null)" for DMI values Daniel Gibson
2026-07-03 13:42   ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260626220210.1761783-1-daniel@gibson.sh \
    --to=daniel@gibson.sh \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®