* Re: [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance
2026-04-29 9:35 [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance Kuldeep Singh
@ 2026-04-29 9:45 ` Konrad Dybcio
2026-05-07 6:30 ` Wenjia Zhang
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Konrad Dybcio @ 2026-04-29 9:45 UTC (permalink / raw)
To: Kuldeep Singh, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manish Pandey, Melody Olvera,
Nitin Rawat
Cc: Wenjia Zhang, linux-arm-msm, devicetree, linux-kernel
On 4/29/26 11:35 AM, Kuldeep Singh wrote:
> The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
> UFS node lacks the required qcom,ice phandle reference.
>
> Add the qcom,ice property to explicitly associate the UFS controller
> with its ICE instance.
>
> Fixes: d288abc3a70e ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC")
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance
2026-04-29 9:35 [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance Kuldeep Singh
2026-04-29 9:45 ` Konrad Dybcio
@ 2026-05-07 6:30 ` Wenjia Zhang
2026-05-21 5:51 ` Kuldeep Singh
2026-07-05 20:58 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Wenjia Zhang @ 2026-05-07 6:30 UTC (permalink / raw)
To: Kuldeep Singh, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manish Pandey, Melody Olvera,
Nitin Rawat
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel
On 4/29/2026 5:35 PM, Kuldeep Singh wrote:
> The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
> UFS node lacks the required qcom,ice phandle reference.
>
> Add the qcom,ice property to explicitly associate the UFS controller
> with its ICE instance.
>
> Fixes: d288abc3a70e ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC")
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
> ---
> Validations:
> * Driver probe
> * FBE with standard keys.
> ---
> arch/arm64/boot/dts/qcom/sm8750.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index 18fb52c14acd..4ea7f6b7e20d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -5396,6 +5396,7 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> phy-names = "ufsphy";
>
> #reset-cells = <1>;
> + qcom,ice = <&ice>;
>
> status = "disabled";
>
>
> ---
> base-commit: 39704f00f747aba3144289870b5fd8ac230a9aaf
> change-id: 20260428-sm8750_ice_dt_fix-d32c838c0c3b
>
> Best regards,
> --
> Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Tested-by: Wenjia Zhang <wenjia.zhang@oss.qualcomm.com> # on sm8750-mtp
Already validated the standard key and wrappred key.
Regards,
Wenjia
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance
2026-04-29 9:35 [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance Kuldeep Singh
2026-04-29 9:45 ` Konrad Dybcio
2026-05-07 6:30 ` Wenjia Zhang
@ 2026-05-21 5:51 ` Kuldeep Singh
2026-07-05 20:58 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Kuldeep Singh @ 2026-05-21 5:51 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Manish Pandey, Melody Olvera, Nitin Rawat
Cc: Konrad Dybcio, Wenjia Zhang, linux-arm-msm, devicetree, linux-kernel
On 29-04-2026 15:05, Kuldeep Singh wrote:
> The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
> UFS node lacks the required qcom,ice phandle reference.
>
> Add the qcom,ice property to explicitly associate the UFS controller
> with its ICE instance.
>
> Fixes: d288abc3a70e ("arm64: dts: qcom: sm8750: Add UFS nodes for SM8750 SoC")
> Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Bjorn, kind reminder to review and pick the fix patch.
This is required for ufs-ice to work for standard/wrapped keys which
isn't in working stage right now.
--
Regards
Kuldeep
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance
2026-04-29 9:35 [PATCH] arm64: dts: qcom: sm8750: wire UFS to ice instance Kuldeep Singh
` (2 preceding siblings ...)
2026-05-21 5:51 ` Kuldeep Singh
@ 2026-07-05 20:58 ` Bjorn Andersson
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2026-07-05 20:58 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manish Pandey, Melody Olvera, Nitin Rawat, Kuldeep Singh
Cc: Konrad Dybcio, Wenjia Zhang, linux-arm-msm, devicetree, linux-kernel
On Wed, 29 Apr 2026 15:05:40 +0530, Kuldeep Singh wrote:
> The Inline Crypto Engine (ICE) exists as a standalone DT node, but the
> UFS node lacks the required qcom,ice phandle reference.
>
> Add the qcom,ice property to explicitly associate the UFS controller
> with its ICE instance.
>
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sm8750: wire UFS to ice instance
commit: ac456227d22952b656ad291ebd2d3d3e498e3d95
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread