mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Kemeng Shi" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Kemeng Shi <shikemeng@huaweicloud.com>,
	Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: irq/drivers] irqchip/gic-v3-its: Fix memleak in its_probe_one()
Date: Tue, 07 Jul 2026 20:54:33 -0000	[thread overview]
Message-ID: <178345767313.744054.2153233997978345196.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260702033050.1583-2-shikemeng@huaweicloud.com>

The following commit has been merged into the irq/drivers branch of tip:

Commit-ID:     1efffab6fe336a5c4fd3c2886f255cd2f998e65f
Gitweb:        https://git.kernel.org/tip/1efffab6fe336a5c4fd3c2886f255cd2f998e65f
Author:        Kemeng Shi <shikemeng@huaweicloud.com>
AuthorDate:    Thu, 02 Jul 2026 11:30:45 +08:00
Committer:     Thomas Gleixner <tglx@kernel.org>
CommitterDate: Tue, 07 Jul 2026 22:49:37 +02:00

irqchip/gic-v3-its: Fix memleak in its_probe_one()

Fix collection leak when its_init_domain() failed in its_probe_one().

Fixes: 4c21f3c26ecc2 ("irqchip: GICv3: ITS: DT probing and initialization")
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Radu Rendec <radu@rendec.net>
Link: https://patch.msgid.link/20260702033050.1583-2-shikemeng@huaweicloud.com
---
 drivers/irqchip/irq-gic-v3-its.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index b57d81a..1ab6fc7 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -5322,7 +5322,7 @@ static int __init its_probe_one(struct its_node *its)
 
 	err = its_init_domain(its);
 	if (err)
-		goto out_free_tables;
+		goto out_free_collection;
 
 	raw_spin_lock(&its_lock);
 	list_add(&its->entry, &its_nodes);
@@ -5330,6 +5330,8 @@ static int __init its_probe_one(struct its_node *its)
 
 	return 0;
 
+out_free_collection:
+	kfree(its->collections);
 out_free_tables:
 	its_free_tables(its);
 out_free_cmd:

  parent reply	other threads:[~2026-07-07 20:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  3:30 [PATCH v4 0/6] Some Minor fixes and cleanups to irqchip/gic-v3-its Kemeng Shi
2026-07-02  3:30 ` [PATCH v4 1/6] irqchip/gic-v3-its: Fix memleak in its_probe_one() Kemeng Shi
2026-07-04 14:51   ` Radu Rendec
2026-07-07 20:54   ` tip-bot2 for Kemeng Shi [this message]
2026-07-02  3:30 ` [PATCH v4 2/6] irqchip/gic-v3-its: Fix its node leak in gic_acpi_parse_madt_its() Kemeng Shi
2026-07-04 15:08   ` Radu Rendec
2026-07-07 20:54   ` [tip: irq/drivers] " tip-bot2 for Kemeng Shi
2026-07-02  3:30 ` [PATCH v4 3/6] irqchip/gic-v3-its: Fix leak in its_vpe_irq_domain_alloc() Kemeng Shi
2026-07-02 22:12   ` Marc Zyngier
2026-07-03  1:44     ` Kemeng Shi
2026-07-06  8:36       ` Marc Zyngier
2026-07-13 12:11         ` Kemeng Shi
2026-07-13 13:05         ` Kemeng Shi
2026-07-13 20:58           ` Marc Zyngier
2026-07-02  3:30 ` [PATCH v4 4/6] irqchip/gic-v3-its: Add ITS address info in more error logs Kemeng Shi
2026-07-02 22:10   ` Marc Zyngier
2026-07-03  1:45     ` Kemeng Shi
2026-07-02  3:30 ` [PATCH v4 5/6] irqchip/gic-v3-its: Fix grammar and replace a bit number with its symbol Kemeng Shi
2026-07-04 15:37   ` Radu Rendec
2026-07-13 12:07     ` Kemeng Shi
2026-07-02  3:30 ` [PATCH v4 6/6] irqchip/gic-v3-its: Remove redundant check in its_vpe_db_proxy_unmap_locked() Kemeng Shi
2026-07-04 16:32   ` Radu Rendec
2026-07-06  8:31     ` Marc Zyngier
2026-07-13 12:08     ` Kemeng Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178345767313.744054.2153233997978345196.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=radu@rendec.net \
    --cc=shikemeng@huaweicloud.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®