From: Kemeng Shi <shikemeng@huaweicloud.com>
To: Marc Zyngier <maz@kernel.org>
Cc: tglx@kernel.org, lpieralisi@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/6] irqchip/gic-v3-its: Add ITS address info in more error logs
Date: Fri, 3 Jul 2026 09:45:19 +0800 [thread overview]
Message-ID: <5140126d-ea86-4532-9ee3-33b98a064d1e@huaweicloud.com> (raw)
In-Reply-To: <87h5mh6o1q.wl-maz@kernel.org>
在 2026/7/3 6:10:09, Marc Zyngier 写道:
> On Thu, 02 Jul 2026 04:30:48 +0100,
> Kemeng Shi <shikemeng@huaweicloud.com> wrote:
>>
>> Multiple ITS units may exist in a system. When an error occurs, it is
>> difficult to identify which ITS triggered it because most error logs
>> lack the ITS address. Some logs already include this information and
>> is useful for debugging. Add the ITS address to the remaining error
>> logs so that all ITS-related errors can be consistently attributed to
>> a specific ITS instance.
>
> I already said *no* to this.
>
> If you want to log errors, implement a PMU or RAS driver that reports
> errors on a per ITS basis, in a way that is collectable by existing
> tooling.
>
> The kernel log is not the place for your sorry debug hacks, which is
> in general not readable by normal users. And I'd rather remove the
> other instances as a matter of consistency.
>
Will drop this in next version...> M.
>
next prev parent reply other threads:[~2026-07-03 1:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 3:30 [PATCH v4 0/6] Some Minor fixes and cleanups to irqchip/gic-v3-its Kemeng Shi
2026-07-02 3:30 ` [PATCH v4 1/6] irqchip/gic-v3-its: Fix memleak in its_probe_one() Kemeng Shi
2026-07-04 14:51 ` Radu Rendec
2026-07-07 20:54 ` [tip: irq/drivers] " tip-bot2 for Kemeng Shi
2026-07-02 3:30 ` [PATCH v4 2/6] irqchip/gic-v3-its: Fix its node leak in gic_acpi_parse_madt_its() Kemeng Shi
2026-07-04 15:08 ` Radu Rendec
2026-07-07 20:54 ` [tip: irq/drivers] " tip-bot2 for Kemeng Shi
2026-07-02 3:30 ` [PATCH v4 3/6] irqchip/gic-v3-its: Fix leak in its_vpe_irq_domain_alloc() Kemeng Shi
2026-07-02 22:12 ` Marc Zyngier
2026-07-03 1:44 ` Kemeng Shi
2026-07-06 8:36 ` Marc Zyngier
2026-07-13 12:11 ` Kemeng Shi
2026-07-13 13:05 ` Kemeng Shi
2026-07-13 20:58 ` Marc Zyngier
2026-07-02 3:30 ` [PATCH v4 4/6] irqchip/gic-v3-its: Add ITS address info in more error logs Kemeng Shi
2026-07-02 22:10 ` Marc Zyngier
2026-07-03 1:45 ` Kemeng Shi [this message]
2026-07-02 3:30 ` [PATCH v4 5/6] irqchip/gic-v3-its: Fix grammar and replace a bit number with its symbol Kemeng Shi
2026-07-04 15:37 ` Radu Rendec
2026-07-13 12:07 ` Kemeng Shi
2026-07-02 3:30 ` [PATCH v4 6/6] irqchip/gic-v3-its: Remove redundant check in its_vpe_db_proxy_unmap_locked() Kemeng Shi
2026-07-04 16:32 ` Radu Rendec
2026-07-06 8:31 ` Marc Zyngier
2026-07-13 12:08 ` Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140126d-ea86-4532-9ee3-33b98a064d1e@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox