* [PATCH] remoteproc: qcom_q6v5_adsp: Fix reference leak for device node
@ 2026-01-16 12:11 Felix Gu
2026-01-16 13:56 ` Markus Elfring
2026-07-10 18:07 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Felix Gu @ 2026-01-16 12:11 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Srinivasa Rao Mandadapu
Cc: linux-arm-msm, linux-remoteproc, linux-kernel, Felix Gu
When calling of_parse_phandle_with_args(), the caller is responsible
to call of_node_put() to release the reference of device node.
In adsp_map_carveout, it does not release the reference.
Fixes: f22eedff28af ("remoteproc: qcom: Add support for memory sandbox")
Signed-off-by: Felix Gu <gu_0233@qq.com>
---
drivers/remoteproc/qcom_q6v5_adsp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
index b5c8d6d38c9c..c81e6c33c747 100644
--- a/drivers/remoteproc/qcom_q6v5_adsp.c
+++ b/drivers/remoteproc/qcom_q6v5_adsp.c
@@ -355,6 +355,7 @@ static int adsp_map_carveout(struct rproc *rproc)
return ret;
sid = args.args[0] & SID_MASK_DEFAULT;
+ of_node_put(args.np);
/* Add SID configuration for ADSP Firmware to SMMU */
iova = adsp->mem_phys | (sid << 32);
---
base-commit: 9b7977f9e39b7768c70c2aa497f04e7569fd3e00
change-id: 20260116-qcom_q6v5-150af62cd206
Best regards,
--
Felix Gu <gu_0233@qq.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remoteproc: qcom_q6v5_adsp: Fix reference leak for device node
2026-01-16 12:11 [PATCH] remoteproc: qcom_q6v5_adsp: Fix reference leak for device node Felix Gu
@ 2026-01-16 13:56 ` Markus Elfring
2026-07-10 18:07 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2026-01-16 13:56 UTC (permalink / raw)
To: Felix Gu, linux-remoteproc, linux-arm-msm
Cc: LKML, Bjorn Andersson, Mathieu Poirier, Srinivasa Rao Mandadapu
…
> In adsp_map_carveout, it does not release the reference.
See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n94
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remoteproc: qcom_q6v5_adsp: Fix reference leak for device node
2026-01-16 12:11 [PATCH] remoteproc: qcom_q6v5_adsp: Fix reference leak for device node Felix Gu
2026-01-16 13:56 ` Markus Elfring
@ 2026-07-10 18:07 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-07-10 18:07 UTC (permalink / raw)
To: Mathieu Poirier, Srinivasa Rao Mandadapu, Felix Gu
Cc: linux-arm-msm, linux-remoteproc, linux-kernel
On Fri, 16 Jan 2026 20:11:03 +0800, Felix Gu wrote:
> When calling of_parse_phandle_with_args(), the caller is responsible
> to call of_node_put() to release the reference of device node.
> In adsp_map_carveout, it does not release the reference.
>
>
Applied, thanks!
[1/1] remoteproc: qcom_q6v5_adsp: Fix reference leak for device node
commit: 8c952807c2cebd5e9e9b37146c9383229794c129
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-10 18:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-16 12:11 [PATCH] remoteproc: qcom_q6v5_adsp: Fix reference leak for device node Felix Gu
2026-01-16 13:56 ` Markus Elfring
2026-07-10 18:07 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox