From: Bjorn Andersson <andersson@kernel.org>
To: mathieu.poirier@linaro.org, Uday Khare <udaykhare77@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH 1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev
Date: Fri, 10 Jul 2026 13:07:06 -0500 [thread overview]
Message-ID: <178370682991.2572738.9046057904322921905.b4-ty@kernel.org> (raw)
In-Reply-To: <20260618132054.11010-1-udaykhare77@gmail.com>
On Thu, 18 Jun 2026 18:50:54 +0530, Uday Khare wrote:
> In qcom_add_glink_subdev(), the device node reference acquired via
> of_get_child_by_name() is stored in glink->node. If the subsequent
> kstrdup_const() allocation for glink->ssr_name fails, the function
> returns early without calling of_node_put() on glink->node, leaking
> the reference count.
>
> Fix this by adding of_node_put(glink->node) on the error path before
> returning.
>
> [...]
Applied, thanks!
[1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev
commit: ed5dd2a9b716568ff7d6446322ee60846af313aa
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2026-07-10 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 13:20 Uday Khare
2026-07-01 11:30 ` (subset) " Mark Brown
2026-07-10 18:07 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178370682991.2572738.9046057904322921905.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=udaykhare77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®