mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property
@ 2026-07-12 16:22 Krzysztof Kozlowski
  2026-07-20 21:05 ` Rob Herring (Arm)
  2026-07-31  3:23 ` Bjorn Andersson
  0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-12 16:22 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Andy Gross, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

The DT schema core defines the type ($ref) of 'firmware-name' property
as string-array, so individual schemas do not need to.  They also should
not redefine it to a single string, but instead just set number of
expected firmware names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Changes in v2:
1. Switch default to an array
---
 Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
index 72a7f8cb09ba..cfaa15d86ece 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
@@ -19,8 +19,8 @@ properties:
     const: qcom,wcnss
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
-    default: wlan/prima/WCNSS_qcom_wlan_nv.bin
+    maxItems: 1
+    default: [ wlan/prima/WCNSS_qcom_wlan_nv.bin ]
     description:
       Relative firmware image path for the WLAN NV blob.
 
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property
  2026-07-12 16:22 [PATCH v2] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property Krzysztof Kozlowski
@ 2026-07-20 21:05 ` Rob Herring (Arm)
  2026-07-31  3:23 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2026-07-20 21:05 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Andy Gross, Conor Dooley, Konrad Dybcio, devicetree,
	Bjorn Andersson, linux-arm-msm, linux-kernel,
	Krzysztof Kozlowski


On Sun, 12 Jul 2026 18:22:13 +0200, Krzysztof Kozlowski wrote:
> The DT schema core defines the type ($ref) of 'firmware-name' property
> as string-array, so individual schemas do not need to.  They also should
> not redefine it to a single string, but instead just set number of
> expected firmware names.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> 
> ---
> 
> Changes in v2:
> 1. Switch default to an array
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property
  2026-07-12 16:22 [PATCH v2] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property Krzysztof Kozlowski
  2026-07-20 21:05 ` Rob Herring (Arm)
@ 2026-07-31  3:23 ` Bjorn Andersson
  1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2026-07-31  3:23 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Andy Gross, linux-arm-msm, devicetree, linux-kernel,
	Krzysztof Kozlowski


On Sun, 12 Jul 2026 18:22:13 +0200, Krzysztof Kozlowski wrote:
> The DT schema core defines the type ($ref) of 'firmware-name' property
> as string-array, so individual schemas do not need to.  They also should
> not redefine it to a single string, but instead just set number of
> expected firmware names.
> 
> 

Applied, thanks!

[1/1] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property
      commit: 3fd6a04e5bf863a8c02c150d584f42c7b9ae5f8c

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-31  3:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-12 16:22 [PATCH v2] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property Krzysztof Kozlowski
2026-07-20 21:05 ` Rob Herring (Arm)
2026-07-31  3:23 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®