[PATCH] soc: qcom: pmic_glink_altmode: Define the TBT extradata properly

[PATCH] soc: qcom: pmic_glink_altmode: Define the TBT extradata properly

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Before the fixes-referenced commit, there was a trailing 'u32 reserved'
after the payload array. That commit gobbled it up into the thunderbolt
extradata. Push it back where it belongs.

There's no functional change, since the outer struct size remains
identical - struct usbc_sc8280x_tbt_data and therefore the union it's a
part of made up for the difference and the res bytes were ignored
anyway.

Fixes: 0539c5a6fdef ("soc: qcom: pmic_glink_altmode: Consume TBT3/USB4 mode notifications")
Reported-by: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 drivers/soc/qcom/pmic_glink_altmode.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c
index 619bad2c27ee..13c434f8d03a 100644
--- a/drivers/soc/qcom/pmic_glink_altmode.c
+++ b/drivers/soc/qcom/pmic_glink_altmode.c
@@ -53,7 +53,7 @@ struct usbc_sc8280x_tbt_data {
 	/* This field is NOP on USB4, all cables support rounded rates by spec */
 	u8 rounded_cable : 1;
 	u8 power_limited : 1;
-	u8 res[11];
+	u8 res[7];
 };
 
 struct usbc_notify {
@@ -74,6 +74,7 @@ struct usbc_notify {
 		struct usbc_sc8280x_dp_data dp;
 		struct usbc_sc8280x_tbt_data tbt;
 	} extended_data;
+	u32 reserved;
 };
 
 struct usbc_sc8180x_notify {

---
base-commit: 1a1757b76427f6201bfe0bf1bea9f7574f332a93
change-id: 20260717-topic-tbt_extradata_fixup-85b5e38b89e0

Best regards,
--  
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Re: [PATCH] soc: qcom: pmic_glink_altmode: Define the TBT extradata properly

[Bjorn Andersson]

On Fri, 17 Jul 2026 20:06:37 +0200, Konrad Dybcio wrote:
> Before the fixes-referenced commit, there was a trailing 'u32 reserved'
> after the payload array. That commit gobbled it up into the thunderbolt
> extradata. Push it back where it belongs.
> 
> There's no functional change, since the outer struct size remains
> identical - struct usbc_sc8280x_tbt_data and therefore the union it's a
> part of made up for the difference and the res bytes were ignored
> anyway.
> 
> [...]

Applied, thanks!

[1/1] soc: qcom: pmic_glink_altmode: Define the TBT extradata properly
      commit: b255c6f4e6b48e09227cd68777a5d2ec1d36dc31

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>