mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 00/12] clk: qcom: Assorted fixes for gcc-mdm9607 (and gcc-msm8916/39)
@ 2026-07-06 15:02 Stephan Gerhold
  2026-07-06 15:02 ` [PATCH v2 01/12] clk: qcom: gcc-msm8916: Fix enable_reg for gcc_blsp1_sleep_clk Stephan Gerhold
                   ` (12 more replies)
  0 siblings, 13 replies; 15+ messages in thread
From: Stephan Gerhold @ 2026-07-06 15:02 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Michael Turquette, Stephen Boyd, Georgi Djakov, Shawn Guo,
	Bryan O'Donoghue, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Taniya Das, linux-arm-msm,
	linux-clk, linux-kernel, devicetree, Konrad Dybcio,
	Krzysztof Kozlowski

The gcc-mdm9607 driver was originally based on gcc-msm8916, with register
addresses/frequency tables - where available - replaced with the values
from the downstream clock-gcc-mdm9607 driver. Nowadays, gcc-msm8909 is a
much closer match, so comparing the two drivers revealed quite a few
mistakes inside the gcc-mdm9607 driver.

This series fixes them, together with a few other related bug fixes in
gcc-msm8916, gcc-msm8939 and the dt-bindings for qcom,gcc-mdm9607.

Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
Changes in v2:
- Pick up review tags (Konrad, Taniya, Krzysztof)
- clk: qcom: gcc-mdm9607: Fix BIMC PLL definition
  - Replace with new commit that drops the BIMC PLL entirely, together with
    all related consumer clocks. Similar to newer SoCs, we now define the
    NoC-related clocks without parent. (Konrad, Taniya)
- clk: qcom: gcc-mdm9607: Drop incorrect apss_tcu_clk_src
  - Drop now unused static gcc_xo_gpll0_gpll1_gpll2_map variables (Sashiko)
  - Clarify commit message, looks like the apss_tcu_clk_src exists in the
    hardware, but at a different address. We don't have any use for this
    clock though, so leave the actual change as-is. (Konrad)
- clk: qcom: gcc-mdm9607: Drop incorrect system_noc_bfdcd_clk_src
  - Clarify commit message, the system_noc_bfdcd_clk_src is really missing
    in the hardware. (Konrad)
- dt-bindings: clock: qcom: gcc-mdm9607: Drop incorrect clocks
  - Keep APSS_TCU_CLK_SRC since Konrad mentioned this clock exists in the
    hardware. We don't use it in the driver, but the dt-bindings document
    the hardware, not the driver.
- Link to v1: https://patch.msgid.link/20260609-qcom-clk-mdm9607-fixes-v1-0-5e9717faf842@linaro.org

---
Stephan Gerhold (12):
      clk: qcom: gcc-msm8916: Fix enable_reg for gcc_blsp1_sleep_clk
      clk: qcom: gcc-msm8939: Fix enable_reg for gcc_blsp1_sleep_clk
      clk: qcom: gcc-mdm9607: Fix enable_reg for gcc_blsp1_sleep_clk
      clk: qcom: gcc-mdm9607: Fix halt_reg for gcc_apss_axi_clk
      clk: qcom: gcc-mdm9607: Increase delay for USB PHY reset
      clk: qcom: gcc-mdm9607: Drop incorrect apss_tcu_clk_src
      clk: qcom: gcc-mdm9607: Drop incorrect system_noc_bfdcd_clk_src
      clk: qcom: gcc-mdm9607: Drop incorrect BIMC PLL and related clocks
      dt-bindings: clock: qcom: gcc-mdm9607: Drop SYSTEM_NOC_BFDCD_CLK_SRC
      dt-bindings: clock: qcom: gcc-mdm9607: Add missing "clocks" property
      dt-bindings: clock: qcom: gcc-mdm9607: Use proper address in example
      clk: qcom: gcc-mdm9607: Drop redundant register update during probe

 .../bindings/clock/qcom,gcc-mdm9607.yaml           |  18 +-
 drivers/clk/qcom/gcc-mdm9607.c                     | 193 +--------------------
 drivers/clk/qcom/gcc-msm8916.c                     |   5 +-
 drivers/clk/qcom/gcc-msm8939.c                     |   5 +-
 include/dt-bindings/clock/qcom,gcc-mdm9607.h       |   1 -
 5 files changed, 29 insertions(+), 193 deletions(-)
---
base-commit: 696bef37f7f22f894ffc2059bdf9ec76b309cf8f
change-id: 20260609-qcom-clk-mdm9607-fixes-81a8d11dbd80

Best regards,
--  
Stephan Gerhold <stephan.gerhold@linaro.org>


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2026-07-31  3:25 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-06 15:02 [PATCH v2 00/12] clk: qcom: Assorted fixes for gcc-mdm9607 (and gcc-msm8916/39) Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 01/12] clk: qcom: gcc-msm8916: Fix enable_reg for gcc_blsp1_sleep_clk Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 02/12] clk: qcom: gcc-msm8939: " Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 03/12] clk: qcom: gcc-mdm9607: " Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 04/12] clk: qcom: gcc-mdm9607: Fix halt_reg for gcc_apss_axi_clk Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 05/12] clk: qcom: gcc-mdm9607: Increase delay for USB PHY reset Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 06/12] clk: qcom: gcc-mdm9607: Drop incorrect apss_tcu_clk_src Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 07/12] clk: qcom: gcc-mdm9607: Drop incorrect system_noc_bfdcd_clk_src Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 08/12] clk: qcom: gcc-mdm9607: Drop incorrect BIMC PLL and related clocks Stephan Gerhold
2026-07-06 15:35   ` Konrad Dybcio
2026-07-06 15:02 ` [PATCH v2 09/12] dt-bindings: clock: qcom: gcc-mdm9607: Drop SYSTEM_NOC_BFDCD_CLK_SRC Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 10/12] dt-bindings: clock: qcom: gcc-mdm9607: Add missing "clocks" property Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 11/12] dt-bindings: clock: qcom: gcc-mdm9607: Use proper address in example Stephan Gerhold
2026-07-06 15:02 ` [PATCH v2 12/12] clk: qcom: gcc-mdm9607: Drop redundant register update during probe Stephan Gerhold
2026-07-31  3:24 ` [PATCH v2 00/12] clk: qcom: Assorted fixes for gcc-mdm9607 (and gcc-msm8916/39) Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®