* [PATCH v2 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings
@ 2026-07-22 9:40 Abel Vesa
2026-07-22 9:40 ` [PATCH v2 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema Abel Vesa
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Abel Vesa @ 2026-07-22 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Luca Weiss,
Manivannan Sadhasivam, Konrad Dybcio, Dmitry Baryshkov
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Konrad Dybcio, Krzysztof Kozlowski, Abel Vesa
It has been pointed out [1] that, since the ADSP found on Eliza is
compatible with the ones from SM8750 class, they should be documented
in the SM8550 schema.
So move the compatible from Milos schema to the SM8550 one and then add
the fallback compatible to the node in the Eliza SoC DTSI.
This will also now be in line with the SM8550 driver match data which is
tied to the Eliza ADSP compatible in the driver.
[1] https://lore.kernel.org/all/20260721-benevolent-wonderful-kakapo-ca8c2c@quoll/
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Changes in v2:
- Rebased on next-20260721.
- Dropped the hunk for power-domains if clause, as Krzysztof suggested.
- Picked Krzysztof's and Dmitry's R-b tags for the devicetree patch.
- Link to v1: https://patch.msgid.link/20260721-dts-qcom-eliza-fix-adsp-binding-v1-0-3a0b03af2ec7@oss.qualcomm.com
---
Abel Vesa (2):
dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema
arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc
Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml | 3 ---
Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 2 ++
arch/arm64/boot/dts/qcom/eliza.dtsi | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
---
base-commit: 290aaf24a551d5a0dce037e3fab30820f9113a10
change-id: 20260721-dts-qcom-eliza-fix-adsp-binding-b7712a026b20
Best regards,
--
Abel Vesa <abel.vesa@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema
2026-07-22 9:40 [PATCH v2 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Abel Vesa
@ 2026-07-22 9:40 ` Abel Vesa
2026-07-23 8:16 ` Krzysztof Kozlowski
2026-07-22 9:40 ` [PATCH v2 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc Abel Vesa
2026-07-31 3:26 ` [PATCH v2 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Abel Vesa @ 2026-07-22 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Luca Weiss,
Manivannan Sadhasivam, Konrad Dybcio, Dmitry Baryshkov
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Konrad Dybcio, Krzysztof Kozlowski, Abel Vesa
The ADSP PAS found on Eliza SoC looks fully compatible with SM8750, which
can fallback to SM8550 except for the extra interrupt ("shutdown-ack").
So document its bindings in the SM8550 schema instead.
Fixes: 7cf2f07f949c ("dt-bindings: remoteproc: qcom,milos-pas: Document Eliza ADSP")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml | 3 ---
Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
index 99d7337e58ec..b24e6f6eaf37 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
@@ -16,7 +16,6 @@ description:
properties:
compatible:
enum:
- - qcom,eliza-adsp-pas
- qcom,milos-adsp-pas
- qcom,milos-cdsp-pas
- qcom,milos-mpss-pas
@@ -88,7 +87,6 @@ allOf:
properties:
compatible:
enum:
- - qcom,eliza-adsp-pas
- qcom,milos-adsp-pas
- qcom,milos-cdsp-pas
then:
@@ -109,7 +107,6 @@ allOf:
compatible:
contains:
enum:
- - qcom,eliza-adsp-pas
- qcom,milos-adsp-pas
then:
properties:
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index 2a4c527552e6..e6d81a38fd1c 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -29,6 +29,7 @@ properties:
- qcom,x1e80100-cdsp-pas
- items:
- enum:
+ - qcom,eliza-adsp-pas
- qcom,glymur-adsp-pas
- qcom,hawi-adsp-pas
- qcom,kaanapali-adsp-pas
@@ -134,6 +135,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,eliza-adsp-pas
- qcom,glymur-adsp-pas
- qcom,glymur-cdsp-pas
- qcom,hawi-adsp-pas
--
2.54.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc
2026-07-22 9:40 [PATCH v2 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Abel Vesa
2026-07-22 9:40 ` [PATCH v2 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema Abel Vesa
@ 2026-07-22 9:40 ` Abel Vesa
2026-07-31 3:26 ` [PATCH v2 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-07-22 9:40 UTC (permalink / raw)
To: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Luca Weiss,
Manivannan Sadhasivam, Konrad Dybcio, Dmitry Baryshkov
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Konrad Dybcio, Krzysztof Kozlowski, Abel Vesa
The ADSP found on Eliza SoC is actually fully compatible with the ones
from SM8750 class. So add the SM8550 compatible as fallback, just like
the rest from the SM8750 class SoCs.
Fixes: 88ddafb01ec0 ("arm64: dts: qcom: eliza: Describe the ADSP and USB related nodes")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/eliza.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
index 357e8066c176..5712c094cbb3 100644
--- a/arch/arm64/boot/dts/qcom/eliza.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
@@ -1967,7 +1967,7 @@ tcsr: clock-controller@1fbf000 {
};
remoteproc_adsp: remoteproc@3000000 {
- compatible = "qcom,eliza-adsp-pas";
+ compatible = "qcom,eliza-adsp-pas", "qcom,sm8550-adsp-pas";
reg = <0x0 0x03000000 0x0 0x10000>;
interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
--
2.54.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema
2026-07-22 9:40 ` [PATCH v2 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema Abel Vesa
@ 2026-07-23 8:16 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-23 8:16 UTC (permalink / raw)
To: Abel Vesa
Cc: Bjorn Andersson, Mathieu Poirier, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Luca Weiss,
Manivannan Sadhasivam, Konrad Dybcio, Dmitry Baryshkov,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Konrad Dybcio, Krzysztof Kozlowski
On Wed, Jul 22, 2026 at 12:40:52PM +0300, Abel Vesa wrote:
> The ADSP PAS found on Eliza SoC looks fully compatible with SM8750, which
> can fallback to SM8550 except for the extra interrupt ("shutdown-ack").
>
> So document its bindings in the SM8550 schema instead.
>
> Fixes: 7cf2f07f949c ("dt-bindings: remoteproc: qcom,milos-pas: Document Eliza ADSP")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml | 3 ---
> Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 2 ++
> 2 files changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings
2026-07-22 9:40 [PATCH v2 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Abel Vesa
2026-07-22 9:40 ` [PATCH v2 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema Abel Vesa
2026-07-22 9:40 ` [PATCH v2 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc Abel Vesa
@ 2026-07-31 3:26 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2026-07-31 3:26 UTC (permalink / raw)
To: Mathieu Poirier, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Luca Weiss, Manivannan Sadhasivam, Konrad Dybcio,
Dmitry Baryshkov, Abel Vesa
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Konrad Dybcio, Krzysztof Kozlowski
On Wed, 22 Jul 2026 12:40:51 +0300, Abel Vesa wrote:
> It has been pointed out [1] that, since the ADSP found on Eliza is
> compatible with the ones from SM8750 class, they should be documented
> in the SM8550 schema.
>
> So move the compatible from Milos schema to the SM8550 one and then add
> the fallback compatible to the node in the Eliza SoC DTSI.
>
> [...]
Applied, thanks!
[1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema
commit: 78fb78cb94d389c1696b439623cebe75775f1d4a
[2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc
commit: b589944ecd95fe4a51bc2aab13ce83b298b7bcc8
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-07-31 3:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-22 9:40 [PATCH v2 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Abel Vesa
2026-07-22 9:40 ` [PATCH v2 1/2] dt-bindings: remoteproc: qcom,milos-pas: Move Eliza ADSP to SM8550 schema Abel Vesa
2026-07-23 8:16 ` Krzysztof Kozlowski
2026-07-22 9:40 ` [PATCH v2 2/2] arm64: dts: qcom: eliza: Add fallback compatible for ADSP remoteproc Abel Vesa
2026-07-31 3:26 ` [PATCH v2 0/2] dt-bindings: remoteproc: qcom,milos-pas: Fix ADSP bindings Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®