mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Anvesh Jain P <anvesh.p@oss.qualcomm.com>,
	 Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
	Linmao Li <lilinmao@kylinos.cn>
Cc: Hans de Goede <hansg@kernel.org>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	 Maya Matuszczyk <maccraft123mc@gmail.com>,
	 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	 Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	 linux-arm-msm@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform: arm64: qcom-hamoa-ec: reject incomplete responses
Date: Mon, 03 Aug 2026 22:12:45 +0300	[thread overview]
Message-ID: <178578436515.17622.4835801853250373634.b4-ty@b4> (raw)
In-Reply-To: <20260728111924.4106898-1-lilinmao@kylinos.cn>

On Tue, 28 Jul 2026 19:19:24 +0800, Linmao Li wrote:

> qcom_ec_read() accepts short positive transfers, while both callers
> unconditionally consume every field in their fixed-size response. A short
> transfer can therefore make them use trailing stack bytes that were not
> returned by the device.
> 
> The first response byte contains the number of payload bytes, excluding
> the byte count itself. A complete response of resp_len bytes must
> therefore report resp_len - 1 payload bytes. The existing check only
> rejects counts that do not fit in the response buffer and still accepts
> an incomplete payload.
> 
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform: arm64: qcom-hamoa-ec: reject incomplete responses
      commit: 1b04f556e8428a3865a95627ab7a0acb5d9b93a5

--
 i.


      parent reply	other threads:[~2026-08-03 19:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 11:19 Linmao Li
2026-07-28 11:25 ` Bryan O'Donoghue
2026-07-29 10:08 ` Anvesh Jain P
2026-07-29 10:23   ` Bryan O'Donoghue
2026-07-29 10:49     ` Anvesh Jain P
2026-08-03 19:12 ` Ilpo Järvinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178578436515.17622.4835801853250373634.b4-ty@b4 \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=anvesh.p@oss.qualcomm.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=hansg@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=lilinmao@kylinos.cn \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maccraft123mc@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=sibi.sankar@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®