From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Anvesh Jain P <anvesh.p@oss.qualcomm.com>,
Linmao Li <lilinmao@kylinos.cn>,
Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Cc: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Maya Matuszczyk" <maccraft123mc@gmail.com>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform: arm64: qcom-hamoa-ec: reject incomplete responses
Date: Wed, 29 Jul 2026 11:23:09 +0100 [thread overview]
Message-ID: <b98b48d4-6e9a-4fca-aec6-60cb618a9056@linaro.org> (raw)
In-Reply-To: <d1a6474c-68c1-42f1-8d2d-ad5acdd25fd6@oss.qualcomm.com>
On 29/07/2026 11:08, Anvesh Jain P wrote:
>> - if (resp[0] >= resp_len)
>> + if (resp[0] != resp_len - 1)
>> return -EINVAL;
>>
>> return 0;
> Thanks for catching this — nice find.
>
> This is independently fixed in an in-flight series that reworks
> qcom_ec_read() to use raw i2c_transfer() instead of
> i2c_smbus_read_i2c_block_data(), removing the partial-read case
> entirely, and it already has the same resp[0] != resp_len - 1 check.
> That series just hasn't landed yet, so your report stands on its own —
> happy to add a Reported-by: Linmao Li<lilinmao@kylinos.cn> tag on that
> commit when it's re-posted, if that works for you.
What about -stable ?
Seems like we should take this fix and your series should rebase on top
of the fix instead of the corollary.
That's the way this should work Fixes > New stuff.
Can you add your Review-by/Tested-by and then rebase yourself ?
---
bod
next prev parent reply other threads:[~2026-07-29 10:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 11:19 Linmao Li
2026-07-28 11:25 ` Bryan O'Donoghue
2026-07-29 10:08 ` Anvesh Jain P
2026-07-29 10:23 ` Bryan O'Donoghue [this message]
2026-07-29 10:49 ` Anvesh Jain P
2026-08-03 19:12 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b98b48d4-6e9a-4fca-aec6-60cb618a9056@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=anvesh.p@oss.qualcomm.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=lilinmao@kylinos.cn \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maccraft123mc@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®