From: "tip-bot2 for Julian Braha" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Julian Braha <julianbraha@gmail.com>,
Thomas Gleixner <tglx@kernel.org>,
Bradley Morgan <include@grrlz.net>,
Nicolas Schier <nsc@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/core] nohz: Replace dead select with choice default
Date: Tue, 11 Aug 2026 13:42:17 -0000 [thread overview]
Message-ID: <178645573768.442315.16529554154363095595.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260801160140.2391000-1-julianbraha@gmail.com>
The following commit has been merged into the timers/core branch of tip:
Commit-ID: b17006b45283f012a6e166517f5ca3e1af2f806a
Gitweb: https://git.kernel.org/tip/b17006b45283f012a6e166517f5ca3e1af2f806a
Author: Julian Braha <julianbraha@gmail.com>
AuthorDate: Sat, 01 Aug 2026 17:01:40 +01:00
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Tue, 11 Aug 2026 15:37:23 +02:00
nohz: Replace dead select with choice default
'select' does not work on config options in a 'choice', so currently the
'select VIRT_CPU_ACCOUNTING_GEN' for NO_HZ_FULL is dead, with the choice
option VIRT_CPU_ACCOUNTING_GEN only being enabled when NO_HZ_FULL=y because
the other choice members depend on NO_HZ_FULL=n.
Remove the dead select, and encode this relationship as a default of the
choice, instead.
This dead select was found by kconfirm, a static analysis tool for Kconfig.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Bradley Morgan <include@grrlz.net>
Reviewed-by: Nicolas Schier <nsc@kernel.org>
Link: https://patch.msgid.link/20260801160140.2391000-1-julianbraha@gmail.com
---
init/Kconfig | 1 +
kernel/time/Kconfig | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/init/Kconfig b/init/Kconfig
index 5230d48..523e41d 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -562,6 +562,7 @@ config VIRT_CPU_ACCOUNTING
choice
prompt "Cputime accounting"
+ default VIRT_CPU_ACCOUNTING_GEN if NO_HZ_FULL
default TICK_CPU_ACCOUNTING
# Kind of a stub config for the pure tick based cputime accounting
diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
index d098ac3..ddfb6be 100644
--- a/kernel/time/Kconfig
+++ b/kernel/time/Kconfig
@@ -133,7 +133,6 @@ config NO_HZ_FULL
depends on HAVE_VIRT_CPU_ACCOUNTING_GEN
select NO_HZ_COMMON
select RCU_NOCB_CPU
- select VIRT_CPU_ACCOUNTING_GEN
select IRQ_WORK
select CPU_ISOLATION
help
prev parent reply other threads:[~2026-08-11 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-01 16:01 [PATCH] nohz: replace " Julian Braha
2026-08-01 21:26 ` Bradley Morgan
2026-08-02 19:40 ` Nicolas Schier
2026-08-11 13:42 ` tip-bot2 for Julian Braha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178645573768.442315.16529554154363095595.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=include@grrlz.net \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=nsc@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®