mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: akpm@linux-foundation.org
Cc: arnd@arndb.de, ojeda@kernel.org, n.schier@fritz.com,
	tglx@kernel.org, gary@garyguo.net,
	thomas.weissschuh@linutronix.de, aliceryhl@google.com,
	leitao@debian.org, dianders@chromium.org, linux.amoon@gmail.com,
	oleg@redhat.com, peterz@infradead.org, andreas@gaisler.com,
	linux-kernel@vger.kernel.org,
	Julian Braha <julianbraha@gmail.com>
Subject: [PATCH] nohz: replace dead select with choice default
Date: Sat,  1 Aug 2026 17:01:40 +0100	[thread overview]
Message-ID: <20260801160140.2391000-1-julianbraha@gmail.com> (raw)

'select' does not work on config options in a 'choice', so currently the
'select VIRT_CPU_ACCOUNTING_GEN' for NO_HZ_FULL is dead, with the choice
option VIRT_CPU_ACCOUNTING_GEN only being enabled when NO_HZ_FULL=y because
the other choice members depend on NO_HZ_FULL=n.

Let's remove the dead select, and encode this relationship as a default of
the choice, instead.

This dead select was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 init/Kconfig        | 1 +
 kernel/time/Kconfig | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/Kconfig b/init/Kconfig
index 544167a7045d..8583d9f06c52 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -565,6 +565,7 @@ config VIRT_CPU_ACCOUNTING
 
 choice
 	prompt "Cputime accounting"
+	default VIRT_CPU_ACCOUNTING_GEN if NO_HZ_FULL
 	default TICK_CPU_ACCOUNTING
 
 # Kind of a stub config for the pure tick based cputime accounting
diff --git a/kernel/time/Kconfig b/kernel/time/Kconfig
index d098ac39bde4..ddfb6bee0745 100644
--- a/kernel/time/Kconfig
+++ b/kernel/time/Kconfig
@@ -133,7 +133,6 @@ config NO_HZ_FULL
 	depends on HAVE_VIRT_CPU_ACCOUNTING_GEN
 	select NO_HZ_COMMON
 	select RCU_NOCB_CPU
-	select VIRT_CPU_ACCOUNTING_GEN
 	select IRQ_WORK
 	select CPU_ISOLATION
 	help
-- 
2.55.0


             reply	other threads:[~2026-08-01 16:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-01 16:01 Julian Braha [this message]
2026-08-01 21:26 ` Bradley Morgan
2026-08-02 19:40 ` Nicolas Schier
2026-08-11 13:42 ` [tip: timers/core] nohz: Replace " tip-bot2 for Julian Braha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260801160140.2391000-1-julianbraha@gmail.com \
    --to=julianbraha@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=aliceryhl@google.com \
    --cc=andreas@gaisler.com \
    --cc=arnd@arndb.de \
    --cc=dianders@chromium.org \
    --cc=gary@garyguo.net \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    --cc=n.schier@fritz.com \
    --cc=ojeda@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®