From: Carlos Maiolino <cem@kernel.org>
To: Yun Zhou <yun.zhou@windriver.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] xfs: don't hold buffer locks across sync transaction commit in xfs_sync_sb_buf
Date: Fri, 21 Aug 2026 09:35:46 +0200 [thread overview]
Message-ID: <178729774687.580975.9479028821685428366.b4-ty@kernel.org> (raw)
In-Reply-To: <20260731031010.2627884-1-yun.zhou@windriver.com>
On Fri, 31 Jul 2026 11:10:10 +0800, Yun Zhou wrote:
> xfs_sync_sb_buf() holds sb/rtsb buffer locks across a synchronous
> xfs_trans_commit(), which flushes the CIL push workqueue internally.
> If shutdown occurs during the CIL push, xfs_buf_item_unpin() needs to
> lock these buffers to fail them, causing a deadlock:
>
> setlabel: holds buf lock -> flush_workqueue(xfs-cil)
> CIL push worker: xfs_buf_item_unpin -> xfs_buf_lock(same buf)
>
> [...]
Applied to for-next, thanks!
[1/1] xfs: don't hold buffer locks across sync transaction commit in xfs_sync_sb_buf
commit: 41a28c865d1d5843f8cb9e0af17a8f4d9e2961ff
Best regards,
--
Carlos Maiolino <cem@kernel.org>
next prev parent reply other threads:[~2026-08-21 7:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 3:10 Yun Zhou
2026-08-21 7:35 ` Carlos Maiolino [this message]
2026-09-11 17:42 ` Darrick J. Wong
2026-09-15 3:18 ` Zhou, Yun
2026-09-15 4:31 ` Darrick J. Wong
2026-09-15 6:21 ` Christoph Hellwig
2026-09-15 9:44 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178729774687.580975.9479028821685428366.b4-ty@kernel.org \
--to=cem@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®