From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: "Zhou, Yun" <yun.zhou@windriver.com>,
cem@kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andrey Albershteyn <aalbersh@redhat.com>
Subject: Re: [PATCH v3] xfs: don't hold buffer locks across sync transaction commit in xfs_sync_sb_buf
Date: Mon, 14 Sep 2026 23:21:07 -0700 [thread overview]
Message-ID: <aqjj04f66MqUXgdV@infradead.org> (raw)
In-Reply-To: <20260915043105.GB2705364@frogsfrogsfrogs>
On Mon, Sep 14, 2026 at 09:31:05PM -0700, Darrick J. Wong wrote:
> >
> > Alternatively, since xfs_ioc_setlabel() is currently the only caller
> > and it's kernel-only, we could just move xfs_sync_sb_buf() out of
> > libxfs into xfs_ioctl.c.
>
> Probably safer to do that, since there's no other user of that function,
> and none in userspace.
Yeah, I was going to suggest to move it out of libxfs as well.
Either xfs_ioctl.c or something like xfs_mount.c if we think it will
be reused elsewhere in the near future.
next prev parent reply other threads:[~2026-09-15 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 3:10 Yun Zhou
2026-08-21 7:35 ` Carlos Maiolino
2026-09-11 17:42 ` Darrick J. Wong
2026-09-15 3:18 ` Zhou, Yun
2026-09-15 4:31 ` Darrick J. Wong
2026-09-15 6:21 ` Christoph Hellwig [this message]
2026-09-15 9:44 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqjj04f66MqUXgdV@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@redhat.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®