mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] soundwire: intel: initialise quirk_mask before reading it
@ 2026-08-20 21:22 Boris Faure
  2026-09-01 17:15 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Boris Faure @ 2026-08-20 21:22 UTC (permalink / raw)
  To: Vinod Koul, Bard Liao
  Cc: Pierre-Louis Bossart, linux-sound, linux-kernel, Boris Faure, stable

sdw_master_read_intel_prop() declares quirk_mask without an initialiser
and ignores the return value of fwnode_property_read_u32(). When a BIOS
does not describe "intel-quirk-mask" for a link, the property read leaves
the variable untouched and stack garbage decides whether
SDW_INTEL_QUIRK_MASK_BUS_DISABLE is honoured, so the link may be marked
hw_disabled at random.

Initialise it to 0, matching is_link_enabled() in
sound/hda/core/intel-sdw-acpi.c.
Found by code inspection, not observed at run time.

Fixes: 395713d8ca43 ("soundwire: intel: handle disabled links")
Cc: stable@vger.kernel.org
Signed-off-by: Boris Faure <boris@fau.re>
---
 drivers/soundwire/intel_auxdevice.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/intel_auxdevice.c b/drivers/soundwire/intel_auxdevice.c
index 0b8107bec9ab..26bdca95c7a0 100644
--- a/drivers/soundwire/intel_auxdevice.c
+++ b/drivers/soundwire/intel_auxdevice.c
@@ -158,7 +158,7 @@ static int sdw_master_read_intel_prop(struct sdw_bus *bus)
 	struct sdw_intel_prop *intel_prop;
 	struct fwnode_handle *link;
 	char name[32];
-	u32 quirk_mask;
+	u32 quirk_mask = 0;
 
 	/* Find master handle */
 	snprintf(name, sizeof(name),
-- 
2.55.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] soundwire: intel: initialise quirk_mask before reading it
  2026-08-20 21:22 [PATCH] soundwire: intel: initialise quirk_mask before reading it Boris Faure
@ 2026-09-01 17:15 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2026-09-01 17:15 UTC (permalink / raw)
  To: Bard Liao, Boris Faure
  Cc: Pierre-Louis Bossart, linux-sound, linux-kernel, stable


On Thu, 20 Aug 2026 21:22:57 +0000, Boris Faure wrote:
> sdw_master_read_intel_prop() declares quirk_mask without an initialiser
> and ignores the return value of fwnode_property_read_u32(). When a BIOS
> does not describe "intel-quirk-mask" for a link, the property read leaves
> the variable untouched and stack garbage decides whether
> SDW_INTEL_QUIRK_MASK_BUS_DISABLE is honoured, so the link may be marked
> hw_disabled at random.
> 
> [...]

Applied, thanks!

[1/1] soundwire: intel: initialise quirk_mask before reading it
      commit: ee8a8cfe4e8d3c67456e554c988017c252710a25

Best regards,
-- 
~Vinod



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-01 17:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-20 21:22 [PATCH] soundwire: intel: initialise quirk_mask before reading it Boris Faure
2026-09-01 17:15 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®