From: Jai Luthra <jai.luthra@ideasonboard.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Alexander Shiyan <eagle.alexander923@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH RFC 4/4] media: i2c: imx678: Add imx675 support to the driver
Date: Thu, 03 Sep 2026 09:52:34 +0530 [thread overview]
Message-ID: <178840935437.11722.581815298725172345@freya> (raw)
In-Reply-To: <20260805-media-starvis2-v1-4-91e8e4eae44f@raspberrypi.com>
Hi Dave,
Quoting Dave Stevenson (2026-08-05 21:39:19)
> The IMX675 is a 5MPix Starvis2 sensor that follows the same
> programming pattern as IMX678 and IMX662, so add it into the
> driver.
>
> FIXME: Validate common_regs against Sony documentation.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
> drivers/media/i2c/imx678.c | 222 +++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 222 insertions(+)
>
> diff --git a/drivers/media/i2c/imx678.c b/drivers/media/i2c/imx678.c
> index 9083f2744510..4b82823c260e 100644
> --- a/drivers/media/i2c/imx678.c
> +++ b/drivers/media/i2c/imx678.c
> @@ -714,6 +714,205 @@ const struct imx678_variant imx662_variant_def = {
> .hmax_min = imx662_min_hmax_4lane,
> };
>
> +static const struct cci_reg_sequence imx675_common_regs[] = {
> + { CCI_REG8(0x301B), 0x00 },
nit: Maybe run a quick grep to turn the hex values to lower case like rest
of the driver?
> + { CCI_REG8(0x301C), 0x00 },
> + { CCI_REG8(0x301E), 0x01 },
> +
> + { CCI_REG8(0x3060), 0x95 },
> + { CCI_REG8(0x3061), 0x00 },
> + { CCI_REG8(0x3062), 0x00 },
> + { CCI_REG8(0x3064), 0x56 },
> + { CCI_REG8(0x3065), 0x00 },
> + { CCI_REG8(0x3066), 0x00 },
> +
> + { CCI_REG8(0x3072), 0x00 },
> + { CCI_REG8(0x3073), 0x00 },
> + { CCI_REG8(0x3074), 0x00 },
> + { CCI_REG8(0x3075), 0x00 },
> + { CCI_REG8(0x3081), 0x00 },
> + { CCI_REG8(0x30A4), 0xAA },
> + { CCI_REG8(0x30A6), 0x0F },
> + { CCI_REG8(0x30CC), 0x00 },
> + { CCI_REG8(0x30CD), 0x00 },
> + { CCI_REG8(0x30CE), 0x02 },
> + { CCI_REG8(0x3400), 0x01 },
> +
> + { CCI_REG8(0x3400), 0x01 },
> + { CCI_REG8(0x3460), 0x22 },
> + { CCI_REG8(0x3492), 0x08 },
> + { CCI_REG8(0x3B1D), 0x17 },
> + { CCI_REG8(0x3B44), 0x3F },
> + { CCI_REG8(0x3B60), 0x03 },
> + { CCI_REG8(0x3C03), 0x04 },
> + { CCI_REG8(0x3C04), 0x04 },
> + { CCI_REG8(0x3C0A), 0x00 },
> + { CCI_REG8(0x3C0B), 0x00 },
> + { CCI_REG8(0x3C0C), 0x00 },
> + { CCI_REG8(0x3C0D), 0x00 },
> + { CCI_REG8(0x3C0E), 0x00 },
> + { CCI_REG8(0x3C0F), 0x00 },
> + { CCI_REG8(0x3C30), 0x73 },
> + { CCI_REG8(0x3C3C), 0x20 },
> + { CCI_REG8(0x3C7C), 0xB9 },
> + { CCI_REG8(0x3C7D), 0x01 },
> + { CCI_REG8(0x3C7E), 0xB7 },
> + { CCI_REG8(0x3C7F), 0x01 },
> + { CCI_REG8(0x3CB0), 0x00 },
> + { CCI_REG8(0x3CB2), 0xFF },
> + { CCI_REG8(0x3CB3), 0x03 },
> + { CCI_REG8(0x3CB4), 0xFF },
> + { CCI_REG8(0x3CB5), 0x03 },
> + { CCI_REG8(0x3CBA), 0xFF },
> + { CCI_REG8(0x3CBB), 0x03 },
> + { CCI_REG8(0x3CC0), 0xFF },
> + { CCI_REG8(0x3CC1), 0x03 },
> + { CCI_REG8(0x3CC2), 0x00 },
> + { CCI_REG8(0x3CC6), 0xFF },
> + { CCI_REG8(0x3CC7), 0x03 },
> + { CCI_REG8(0x3CC8), 0xFF },
> + { CCI_REG8(0x3CC9), 0x03 },
> + { CCI_REG8(0x3E00), 0x1E },
> + { CCI_REG8(0x3E02), 0x04 },
> + { CCI_REG8(0x3E03), 0x00 },
> + { CCI_REG8(0x3E20), 0x04 },
> + { CCI_REG8(0x3E21), 0x00 },
> + { CCI_REG8(0x3E22), 0x1E },
> + { CCI_REG8(0x3E24), 0xBA },
> + { CCI_REG8(0x3E72), 0x85 },
> + { CCI_REG8(0x3E76), 0x0C },
> +
> + { CCI_REG8(0x3E77), 0x01 },
> + { CCI_REG8(0x3E7A), 0x85 },
> + { CCI_REG8(0x3E7E), 0x1F },
> + { CCI_REG8(0x3E82), 0xA6 },
> + { CCI_REG8(0x3E86), 0x2D },
> + { CCI_REG8(0x3EE2), 0x33 },
> + { CCI_REG8(0x3EE3), 0x03 },
> + { CCI_REG8(0x4490), 0x07 },
> + { CCI_REG8(0x4494), 0x19 },
> + { CCI_REG8(0x4495), 0x00 },
> + { CCI_REG8(0x4496), 0xBB },
> + { CCI_REG8(0x4497), 0x00 },
> + { CCI_REG8(0x4498), 0x55 },
> + { CCI_REG8(0x449A), 0x50 },
> + { CCI_REG8(0x449C), 0x50 },
> + { CCI_REG8(0x449E), 0x50 },
> + { CCI_REG8(0x44A0), 0x3C },
> + { CCI_REG8(0x44A2), 0x19 },
> + { CCI_REG8(0x44A4), 0x19 },
> + { CCI_REG8(0x44A6), 0x19 },
> + { CCI_REG8(0x44A8), 0x4B },
> + { CCI_REG8(0x44AA), 0x4B },
> + { CCI_REG8(0x44AC), 0x4B },
> + { CCI_REG8(0x44AE), 0x4B },
> + { CCI_REG8(0x44B0), 0x3C },
> + { CCI_REG8(0x44B2), 0x19 },
> + { CCI_REG8(0x44B4), 0x19 },
> + { CCI_REG8(0x44B6), 0x19 },
> + { CCI_REG8(0x44B8), 0x4B },
> + { CCI_REG8(0x44BA), 0x4B },
> + { CCI_REG8(0x44BC), 0x4B },
> + { CCI_REG8(0x44BE), 0x4B },
> + { CCI_REG8(0x44C0), 0x3C },
> + { CCI_REG8(0x44C2), 0x19 },
> + { CCI_REG8(0x44C4), 0x19 },
> + { CCI_REG8(0x44C6), 0x19 },
> + { CCI_REG8(0x44C8), 0xF0 },
> + { CCI_REG8(0x44CA), 0xEB },
> + { CCI_REG8(0x44CC), 0xEB },
> + { CCI_REG8(0x44CE), 0xE6 },
> + { CCI_REG8(0x44D0), 0xE6 },
> + { CCI_REG8(0x44D2), 0xBB },
> +
> + { CCI_REG8(0x44D4), 0xBB },
> + { CCI_REG8(0x44D6), 0xBB },
> + { CCI_REG8(0x44D8), 0xE6 },
> + { CCI_REG8(0x44DA), 0xE6 },
> + { CCI_REG8(0x44DC), 0xE6 },
> + { CCI_REG8(0x44DE), 0xE6 },
> + { CCI_REG8(0x44E0), 0xE6 },
> + { CCI_REG8(0x44E2), 0xBB },
> + { CCI_REG8(0x44E4), 0xBB },
> + { CCI_REG8(0x44E6), 0xBB },
> + { CCI_REG8(0x44E8), 0xE6 },
> + { CCI_REG8(0x44EA), 0xE6 },
> + { CCI_REG8(0x44EC), 0xE6 },
> + { CCI_REG8(0x44EE), 0xE6 },
> + { CCI_REG8(0x44F0), 0xE6 },
> + { CCI_REG8(0x44F2), 0xBB },
> + { CCI_REG8(0x44F4), 0xBB },
> + { CCI_REG8(0x44F6), 0xBB },
> + { CCI_REG8(0x4538), 0x15 },
> + { CCI_REG8(0x4539), 0x15 },
> + { CCI_REG8(0x453A), 0x15 },
> + { CCI_REG8(0x4544), 0x15 },
> + { CCI_REG8(0x4545), 0x15 },
> + { CCI_REG8(0x4546), 0x15 },
> + { CCI_REG8(0x4550), 0x11 },
> + { CCI_REG8(0x4551), 0x11 },
> + { CCI_REG8(0x4552), 0x11 },
> + { CCI_REG8(0x4553), 0x11 },
> + { CCI_REG8(0x4554), 0x11 },
> + { CCI_REG8(0x4555), 0x11 },
> + { CCI_REG8(0x4556), 0x11 },
> + { CCI_REG8(0x4557), 0x11 },
> + { CCI_REG8(0x4558), 0x11 },
> + { CCI_REG8(0x455C), 0x11 },
> + { CCI_REG8(0x455D), 0x11 },
> + { CCI_REG8(0x455E), 0x11 },
> + { CCI_REG8(0x455F), 0x11 },
> + { CCI_REG8(0x4560), 0x11 },
> + { CCI_REG8(0x4561), 0x11 },
> + { CCI_REG8(0x4562), 0x11 },
> + { CCI_REG8(0x4563), 0x11 },
> + { CCI_REG8(0x4564), 0x11 },
> +
> + { CCI_REG8(0x4569), 0x01 },
> + { CCI_REG8(0x456A), 0x01 },
> + { CCI_REG8(0x456B), 0x06 },
> + { CCI_REG8(0x456C), 0x06 },
> + { CCI_REG8(0x456D), 0x06 },
> + { CCI_REG8(0x456E), 0x06 },
> + { CCI_REG8(0x456F), 0x06 },
> + { CCI_REG8(0x4570), 0x06 },
> +};
> +
> +static const u16 imx675_min_hmax_4lane[] = {
> + [IMX678_LINK_FREQ_297MHZ] = 1125,
> + [IMX678_LINK_FREQ_360MHZ] = 1125,
> + [IMX678_LINK_FREQ_445MHZ] = 1125,
> + [IMX678_LINK_FREQ_594MHZ] = 1125 / 2,
> + [IMX678_LINK_FREQ_720MHZ] = 1125 / 2,
> + [IMX678_LINK_FREQ_891MHZ] = 1125 / 2,
> + [IMX678_LINK_FREQ_1039MHZ] = 1125 / 2,
> + [IMX678_LINK_FREQ_1188MHZ] = 1125 / 2,
> +};
> +
> +const struct imx678_variant imx675_variant_def = {
> + .name = "imx675",
> + .id_reg = IMX678_REG_MODULE_ID,
> + .id_value = 0x296,
> + .native_area = {
> + .top = 0,
> + .left = 0,
> + .width = 2609,
> + .height = 1984,
> + },
> + .active_area = {
> + .top = 0,
> + .left = 0,
> + .width = 2608,
> + .height = 1984,
> + },
> + .pixel_rate = 594000000,
> + .pix_per_clk = 8,
> + .common_regs = imx675_common_regs,
> + .num_common_regs = ARRAY_SIZE(imx675_common_regs),
> + .vmax_default = 1984 + 40,
Same doubt for the VBLANK = 40 here as IMX662, although I don't have a
datasheet for IMX675.
Thanks,
Jai
> + .hmax_min = imx675_min_hmax_4lane,
> +};
> +
> struct imx678_model_info {
> enum imx678_type type;
> const u32 *codes;
> @@ -764,6 +963,26 @@ static const struct imx678_model_info imx662_autodetect_info = {
> .auto_detect_mono = &imx662_aamr_info,
> };
>
> +static const struct imx678_model_info imx675_aaqr_info = {
> + .type = IMX678_COLOR,
> + .codes = codes_bayer,
> + .num_codes = ARRAY_SIZE(codes_bayer),
> + .variant = &imx675_variant_def,
> +};
> +
> +static const struct imx678_model_info imx675_aamr_info = {
> + .type = IMX678_MONOCHROME,
> + .codes = codes_monochrome,
> + .num_codes = ARRAY_SIZE(codes_monochrome),
> + .variant = &imx675_variant_def,
> +};
> +
> +static const struct imx678_model_info imx675_autodetect_info = {
> + .variant = &imx675_variant_def,
> + .auto_detect_colour = &imx675_aaqr_info,
> + .auto_detect_mono = &imx675_aamr_info,
> +};
> +
> static const char * const imx678_supply_name[] = {
> "avdd", /* Analog (3.3V) supply */
> "dvdd", /* Digital Core (1.1V) supply */
> @@ -1533,9 +1752,12 @@ static const struct of_device_id imx678_of_match[] = {
> { .compatible = "sony,imx678-aaqr", .data = &imx678_aaqr_info },
> { .compatible = "sony,imx662-aamr", .data = &imx662_aamr_info },
> { .compatible = "sony,imx662-aaqr", .data = &imx662_aaqr_info },
> + { .compatible = "sony,imx675-aamr", .data = &imx675_aamr_info },
> + { .compatible = "sony,imx675-aaqr", .data = &imx675_aaqr_info },
> /* for non-conforming DTs that rely on runtime check */
> { .compatible = "sony,imx678", .data = &imx678_autodetect_info },
> { .compatible = "sony,imx662", .data = &imx662_autodetect_info },
> + { .compatible = "sony,imx675", .data = &imx675_autodetect_info },
> { /* sentinel */ }
> };
>
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-09-03 4:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 16:09 [PATCH RFC 0/4] Update imx678 to act as a common Sony Starvis 2 driver Dave Stevenson
2026-08-05 16:09 ` [PATCH RFC 1/4] media: i2c: imx678: Always program the sensor in window mode Dave Stevenson
2026-09-03 4:16 ` Jai Luthra
2026-08-05 16:09 ` [PATCH RFC 2/4] media: i2c: imx678: Parameterise the configuration to allow for other models Dave Stevenson
2026-09-03 4:15 ` Jai Luthra
2026-08-05 16:09 ` [PATCH RFC 3/4] media: i2c: imx678: Add imx662 support to the driver Dave Stevenson
2026-09-03 4:20 ` Jai Luthra
2026-09-03 11:46 ` Dave Stevenson
2026-08-05 16:09 ` [PATCH RFC 4/4] media: i2c: imx678: Add imx675 " Dave Stevenson
2026-09-03 4:22 ` Jai Luthra [this message]
2026-09-03 11:54 ` Dave Stevenson
2026-09-03 12:24 ` Jai Luthra
2026-09-03 4:13 ` [PATCH RFC 0/4] Update imx678 to act as a common Sony Starvis 2 driver Jai Luthra
2026-09-03 11:55 ` Dave Stevenson
2026-09-03 12:25 ` Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178840935437.11722.581815298725172345@freya \
--to=jai.luthra@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=eagle.alexander923@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®