[PATCH net-next v2] net: mvpp2: simplify IRQ validity check

[PATCH net-next v2] net: mvpp2: simplify IRQ validity check

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
The current condition also checks for negative values, even though
irq_of_parse_and_map() does not return negative error codes.

Check only for a zero return value to match the semantics of
irq_of_parse_and_map().

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---

Link v1: 
https://lore.kernel.org/all/20260824100758.31622-1-phucduc.bui@gmail.com/

Changes in v2:
 - Drop the Fixes tag and rework the commit message to describe this
   as a cleanup.
 - Add net-next to the --subject-prefix.

 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index ccc24a1301f2..1c50174c9f1e 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -5874,7 +5874,7 @@ static int mvpp2_simple_queue_vectors_init(struct mvpp2_port *port,
 	v->sw_thread_mask = *cpumask_bits(cpu_online_mask);
 	v->port = port;
 	v->irq = irq_of_parse_and_map(port_node, 0);
-	if (v->irq <= 0)
+	if (!v->irq)
 		return -EINVAL;
 	netif_napi_add(port->dev, &v->napi, mvpp2_poll);
 
-- 
2.43.0

Re: [PATCH net-next v2] net: mvpp2: simplify IRQ validity check

[Simon Horman]

On Thu, Sep 03, 2026 at 02:57:53PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
> The current condition also checks for negative values, even though
> irq_of_parse_and_map() does not return negative error codes.
> 
> Check only for a zero return value to match the semantics of
> irq_of_parse_and_map().
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> 
> Link v1: 
> https://lore.kernel.org/all/20260824100758.31622-1-phucduc.bui@gmail.com/
> 
> Changes in v2:
>  - Drop the Fixes tag and rework the commit message to describe this
>    as a cleanup.
>  - Add net-next to the --subject-prefix.

Thanks for the updates.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next v2] net: mvpp2: simplify IRQ validity check

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Thu,  3 Sep 2026 14:57:53 +0700 you wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
> The current condition also checks for negative values, even though
> irq_of_parse_and_map() does not return negative error codes.
> 
> Check only for a zero return value to match the semantics of
> irq_of_parse_and_map().
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: mvpp2: simplify IRQ validity check
    https://git.kernel.org/netdev/net-next/c/bf6f89ccd974

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html