* [PATCH v3] Bluetooth: Fix code style error [not found] <20260825122207.101868-1-deaner92.ref@yahoo.com> @ 2026-08-25 12:22 ` Jeremy Dean 2026-08-25 12:52 ` Markus Elfring 2026-09-10 19:50 ` patchwork-bot+bluetooth 0 siblings, 2 replies; 3+ messages in thread From: Jeremy Dean @ 2026-08-25 12:22 UTC (permalink / raw) To: Marcel Holtmann, Luiz Augusto von Dentz Cc: linux-bluetooth, linux-kernel, Markus Elfring, Jeremy Dean checkpatch.pl flags the zero-length array members in struct qca_dump_hdr: ERROR: Use C99 flexible arrays - see https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays #3110: FILE: drivers/bluetooth/btusb.c:3110: + u8 data0[0]; Replace them with DECLARE_FLEX_ARRAY(), since C99 flexible array members are not permitted inside unions or as the sole member of a struct. The struct layout is unchanged, and everything compiles with the change. Link: https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays Signed-off-by: Jeremy Dean <deaner92@yahoo.com> --- drivers/bluetooth/btusb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 8f7ed469cac6..b78c4a0e75fd 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3103,10 +3103,10 @@ struct qca_dump_hdr { __le16 seqno; u8 reserved; union { - u8 data[0]; + DECLARE_FLEX_ARRAY(u8, data); struct { __le32 ram_dump_size; - u8 data0[0]; + DECLARE_FLEX_ARRAY(u8, data0); } __packed; }; } __packed; -- 2.43.0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Bluetooth: Fix code style error 2026-08-25 12:22 ` [PATCH v3] Bluetooth: Fix code style error Jeremy Dean @ 2026-08-25 12:52 ` Markus Elfring 2026-09-10 19:50 ` patchwork-bot+bluetooth 1 sibling, 0 replies; 3+ messages in thread From: Markus Elfring @ 2026-08-25 12:52 UTC (permalink / raw) To: Jeremy Dean, Luiz Augusto von Dentz, Marcel Holtmann, linux-bluetooth Cc: linux-kernel … > --- > drivers/bluetooth/btusb.c | 4 ++--… Some contributors would appreciate patch version descriptions. https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.2-rc7#n310 Regards, Markus ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] Bluetooth: Fix code style error 2026-08-25 12:22 ` [PATCH v3] Bluetooth: Fix code style error Jeremy Dean 2026-08-25 12:52 ` Markus Elfring @ 2026-09-10 19:50 ` patchwork-bot+bluetooth 1 sibling, 0 replies; 3+ messages in thread From: patchwork-bot+bluetooth @ 2026-09-10 19:50 UTC (permalink / raw) To: Jeremy Dean Cc: marcel, luiz.dentz, linux-bluetooth, linux-kernel, Markus.Elfring Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 25 Aug 2026 12:22:07 +0000 you wrote: > checkpatch.pl flags the zero-length array members in struct > qca_dump_hdr: > > ERROR: Use C99 flexible arrays - see > https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays > #3110: FILE: drivers/bluetooth/btusb.c:3110: > + u8 data0[0]; > > [...] Here is the summary with links: - [v3] Bluetooth: Fix code style error https://git.kernel.org/bluetooth/bluetooth-next/c/ca10117e55df You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-10 19:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20260825122207.101868-1-deaner92.ref@yahoo.com>
2026-08-25 12:22 ` [PATCH v3] Bluetooth: Fix code style error Jeremy Dean
2026-08-25 12:52 ` Markus Elfring
2026-09-10 19:50 ` patchwork-bot+bluetooth
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®