From: "tip-bot2 for Thomas Gleixner" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Thomas Gleixner <tglx@kernel.org>,
Kijo Park <red993688@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/core] posix-timers: Move POSIX timer group exit related code out of do_exit()
Date: Wed, 16 Sep 2026 16:48:08 -0000 [thread overview]
Message-ID: <178957728864.1720534.15046408980892509783.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260911090541.733966325@kernel.org>
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 24adce0b86c940ac3dcee0bcd75e799634fc9664
Gitweb: https://git.kernel.org/tip/24adce0b86c940ac3dcee0bcd75e799634fc9664
Author: Thomas Gleixner <tglx@kernel.org>
AuthorDate: Fri, 11 Sep 2026 11:09:26 +02:00
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Wed, 16 Sep 2026 18:44:03 +02:00
posix-timers: Move POSIX timer group exit related code out of do_exit()
Move the POSIX timer group exit handling into the posix timer code and
provide a proper stub when POSIX timers are disabled in Kconfig.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Tested-by: Kijo Park <red993688@gmail.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Link: https://patch.msgid.link/20260911090541.733966325@kernel.org
---
include/linux/posix-timers.h | 2 ++
include/linux/sched/task.h | 1 -
kernel/exit.c | 7 +++----
kernel/time/posix-timers.c | 16 +++++++++-------
4 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/include/linux/posix-timers.h b/include/linux/posix-timers.h
index 7b31da6..3050f9e 100644
--- a/include/linux/posix-timers.h
+++ b/include/linux/posix-timers.h
@@ -233,6 +233,7 @@ int update_rlimit_cpu(struct task_struct *task, unsigned long rlim_new);
#ifdef CONFIG_POSIX_TIMERS
void posixtimer_exec(void);
+void posixtimer_exit(void);
static inline void posixtimer_putref(struct k_itimer *tmr)
{
@@ -262,6 +263,7 @@ static inline bool posixtimer_valid(const struct k_itimer *timer)
}
#else /* CONFIG_POSIX_TIMERS */
static inline void posixtimer_exec(void) { }
+static inline void posixtimer_exit(void) { }
static inline void posixtimer_sigqueue_getref(struct sigqueue *q) { }
static inline void posixtimer_sigqueue_putref(struct sigqueue *q) { }
#endif /* !CONFIG_POSIX_TIMERS */
diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index e0c1ca8..90ed5bc 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -94,7 +94,6 @@ static inline void exit_thread(struct task_struct *tsk)
extern __noreturn void do_group_exit(int);
extern void exit_files(struct task_struct *);
-extern void exit_itimers(struct task_struct *);
extern pid_t kernel_clone(struct kernel_clone_args *kargs);
struct task_struct *copy_process(struct pid *pid, int trace, int node,
diff --git a/kernel/exit.c b/kernel/exit.c
index 424c44a..4ca9759 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -966,13 +966,12 @@ void __noreturn do_exit(long code)
panic("Attempted to kill init! exitcode=0x%08x\n",
tsk->signal->group_exit_code ?: (int)code);
-#ifdef CONFIG_POSIX_TIMERS
- hrtimer_cancel(&tsk->signal->real_timer);
- exit_itimers(tsk);
-#endif
+ posixtimer_exit();
+
if (tsk->mm)
setmax_mm_hiwater_rss(&tsk->signal->maxrss, tsk->mm);
}
+
acct_collect(code, group_dead);
if (group_dead)
tty_audit_exit();
diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index 9611ed4..8fb040a 100644
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -1077,13 +1077,9 @@ SYSCALL_DEFINE1(timer_delete, timer_t, timer_id)
return 0;
}
-/*
- * Invoked from do_exit() when the last thread of a thread group exits.
- * At that point no other task can access the timers of the dying
- * task anymore.
- */
-void exit_itimers(struct task_struct *tsk)
+static void posixtimer_delete_timers(void)
{
+ struct task_struct *tsk = current;
struct hlist_head timers;
struct hlist_node *next;
struct k_itimer *timer;
@@ -1120,12 +1116,18 @@ void exit_itimers(struct task_struct *tsk)
}
}
+void posixtimer_exit(void)
+{
+ hrtimer_cancel(¤t->signal->real_timer);
+ posixtimer_delete_timers();
+}
+
void posixtimer_exec(void)
{
scoped_guard(spinlock_irq, ¤t->sighand->siglock)
posix_cpu_timers_exit(current);
- exit_itimers(current);
+ posixtimer_delete_timers();
flush_itimer_signals();
}
next prev parent reply other threads:[~2026-09-16 16:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 9:09 [patch V3 0/8] exec/exit: POSIX timer related bugfixes and related cleanups Thomas Gleixner
2026-09-11 9:09 ` [patch V3 1/8] signal: Prevent exec() race Thomas Gleixner
2026-09-11 13:08 ` Frederic Weisbecker
2026-09-16 16:48 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2026-09-16 20:37 ` [patch V3 1/8] " Andrea Parri
2026-09-11 9:09 ` [patch V3 2/8] exec: Cleanup POSIX timers right after de_thread() Thomas Gleixner
2026-09-16 16:48 ` [tip: timers/core] " tip-bot2 for Hyunwoo Kim
2026-09-11 9:09 ` [patch V3 3/8] posix-timers: Move posixtimer_exec_cleanup() out of exec.c Thomas Gleixner
2026-09-11 13:58 ` Oleg Nesterov
2026-09-16 16:48 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2026-09-16 20:31 ` [patch V3 3/8] " Andrea Parri
2026-09-11 9:09 ` [patch V3 4/8] posix-timers: Move POSIX timer group exit related code out of do_exit() Thomas Gleixner
2026-09-11 13:59 ` Oleg Nesterov
2026-09-16 16:48 ` tip-bot2 for Thomas Gleixner [this message]
2026-09-11 9:09 ` [patch V3 5/8] posix-cpu-timers: Move inlines out of public header Thomas Gleixner
2026-09-11 13:59 ` Oleg Nesterov
2026-09-16 16:48 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2026-09-11 9:09 ` [patch V3 6/8] posix-cpu-timers: Use PF_EXITING to indicate exit Thomas Gleixner
2026-09-11 13:15 ` Frederic Weisbecker
2026-09-11 14:00 ` Oleg Nesterov
2026-09-16 16:48 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2026-09-16 20:21 ` [patch V3 6/8] " Andrea Parri
2026-09-11 9:09 ` [patch V3 7/8] posix-cpu-timers: Prevent enqueueing when PF_EXITING is set Thomas Gleixner
2026-09-12 21:09 ` Frederic Weisbecker
2026-09-16 16:48 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2026-09-11 9:09 ` [patch V3 8/8] posix-timers: Handle exit in do_exit() completely Thomas Gleixner
2026-09-11 14:02 ` Oleg Nesterov
2026-09-12 22:17 ` Frederic Weisbecker
2026-09-16 16:48 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2026-09-16 20:12 ` [patch V3 8/8] " Andrea Parri
2026-09-12 14:20 ` [patch V3 0/8] exec/exit: POSIX timer related bugfixes and related cleanups Kijo Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178957728864.1720534.15046408980892509783.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=red993688@gmail.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®