From: Frederic Weisbecker <frederic@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Hyunwoo Kim <imv4bel@gmail.com>, Oleg Nesterov <oleg@redhat.com>,
Christian Brauner <brauner@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
John Stultz <jstultz@google.com>, Ingo Molnar <mingo@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [patch V3 6/8] posix-cpu-timers: Use PF_EXITING to indicate exit
Date: Fri, 11 Sep 2026 15:15:28 +0200 [thread overview]
Message-ID: <aqP-8NpXNwBm4pBM@localhost.localdomain> (raw)
In-Reply-To: <20260911090541.837831386@kernel.org>
Le Fri, Sep 11, 2026 at 11:09:35AM +0200, Thomas Gleixner a écrit :
> From: Thomas Gleixner <tglx@kernel.org>
>
> Right now POSIX CPU timers use task::exit_state to check whether a task is
> exiting. That works correctly, but exit_state is set later in do_exit() and
> too late for allowing to cleanup POSIX timers earlier.
>
> It does not matter in case of exit whether the cutoff is a bit earlier.
>
> Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
>
> ---
> kernel/time/posix-cpu-timers.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -1505,7 +1505,7 @@ void run_posix_cpu_timers(void)
> * posix_cpu_timer_del() may fail to lock_task_sighand(tsk) and
> * miss timer->it.cpu.firing != 0.
> */
> - if (tsk->exit_state)
> + if (tsk->flags & PF_EXITING)
> return;
>
> /*
>
>
>
--
Frederic Weisbecker
SUSE Labs
next prev parent reply other threads:[~2026-09-11 13:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 9:09 [patch V3 0/8] exec/exit: POSIX timer related bugfixes and related cleanups Thomas Gleixner
2026-09-11 9:09 ` [patch V3 1/8] signal: Prevent exec() race Thomas Gleixner
2026-09-11 13:08 ` Frederic Weisbecker
2026-09-11 9:09 ` [patch V3 2/8] exec: Cleanup POSIX timers right after de_thread() Thomas Gleixner
2026-09-11 9:09 ` [patch V3 3/8] posix-timers: Move posixtimer_exec_cleanup() out of exec.c Thomas Gleixner
2026-09-11 13:58 ` Oleg Nesterov
2026-09-11 9:09 ` [patch V3 4/8] posix-timers: Move POSIX timer group exit related code out of do_exit() Thomas Gleixner
2026-09-11 13:59 ` Oleg Nesterov
2026-09-11 9:09 ` [patch V3 5/8] posix-cpu-timers: Move inlines out of public header Thomas Gleixner
2026-09-11 13:59 ` Oleg Nesterov
2026-09-11 9:09 ` [patch V3 6/8] posix-cpu-timers: Use PF_EXITING to indicate exit Thomas Gleixner
2026-09-11 13:15 ` Frederic Weisbecker [this message]
2026-09-11 14:00 ` Oleg Nesterov
2026-09-11 9:09 ` [patch V3 7/8] posix-cpu-timers: Prevent enqueueing when PF_EXITING is set Thomas Gleixner
2026-09-12 21:09 ` Frederic Weisbecker
2026-09-11 9:09 ` [patch V3 8/8] posix-timers: Handle exit in do_exit() completely Thomas Gleixner
2026-09-11 14:02 ` Oleg Nesterov
2026-09-12 22:17 ` Frederic Weisbecker
2026-09-12 14:20 ` [patch V3 0/8] exec/exit: POSIX timer related bugfixes and related cleanups Kijo Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqP-8NpXNwBm4pBM@localhost.localdomain \
--to=frederic@kernel.org \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=imv4bel@gmail.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=stern@rowland.harvard.edu \
--cc=tglx@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®