Re: [PATCH net-next 2/6] net/mlx5: HWS, Fix error message in mlx5hws_cmd_generate_wqe

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Commit subject/message misidentifies the location of the fix.

--

net/mlx5: HWS, Fix error message in mlx5hws_cmd_generate_wqe

This adds the missing trailing newline to the error message printed when
the generate WQE command fails in the HWS send path.

> net/mlx5: HWS, Fix error message in mlx5hws_cmd_generate_wqe

[Severity: Low]
This isn't a code bug, but does the subject point at the right function?
The only change is in hws_send_wqe_fw() in
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c, which is the
caller of mlx5hws_cmd_generate_wqe():

send_wqe:
	ret = mlx5hws_cmd_generate_wqe(mdev, &attr, &cqe);
	if (ret) {
		mlx5_core_err(mdev, "Failed to write WQE using command\n");
		return ret;
	}

mlx5hws_cmd_generate_wqe() itself lives in hws/cmd.c and both of its error
prints already end with '\n':

	ret = mlx5_cmd_exec(mdev, in, sizeof(in), out, sizeof(out));
	if (ret) {
		mlx5_core_err(mdev, "Failed to write GTA WQE using FW\n");
		return ret;
	}

	status = MLX5_GET(generate_wqe_out, out, status);
	if (status) {
		mlx5_core_err(mdev, "Invalid FW CQE status %d\n", status);
		return -EINVAL;
	}

Would something like "net/mlx5: HWS, Add missing newline to error message in
hws_send_wqe_fw" be more accurate, so that someone grepping cmd.c for the
quoted string is not sent to the wrong place?

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c
> index ae3ff232c63bc..80cfd0ddba08b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c
> @@ -1287,7 +1287,7 @@ hws_send_wqe_fw(struct mlx5_core_dev *mdev,
>  send_wqe:
>  	ret = mlx5hws_cmd_generate_wqe(mdev, &attr, &cqe);
>  	if (ret) {
> -		mlx5_core_err(mdev, "Failed to write WQE using command");
> +		mlx5_core_err(mdev, "Failed to write WQE using command\n");
>  		return ret;
>  	}
>

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260915111912.3926585-1-tariqt%40nvidia.com