* [PATCH net v2] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc
@ 2026-09-17 6:30 Karl Mehltretter
2026-09-17 12:15 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Karl Mehltretter @ 2026-09-17 6:30 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, Jakub Kicinski,
Florian Fainelli, Maxime Chevallier, Russell King (Oracle)
Cc: Karl Mehltretter, netdev, linux-kernel
The phy_may_wakeup() documentation refers to
device_set_wakeup_enabled(), but the function is named
device_set_wakeup_enable(). Correct the reference.
Fixes: b344bfacf1de ("net: phy: add phy_may_wakeup()")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
v2:
- Target net and add a Fixes tag (Andrew Lunn).
- No source changes from v1.
v1: https://lore.kernel.org/r/20260911204201.95270-1-kmehltretter@gmail.com/
include/linux/phy.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 5f8d65868e0ff558c163421cfea5a6f3bd73a53e..da2febc6425ed340248d9872dd8f2ef79b665168 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1697,7 +1697,7 @@ static inline bool phy_can_wakeup(struct phy_device *phydev)
* phy_may_wakeup() - indicate whether PHY has wakeup enabled
* @phydev: The phy_device struct
*
- * Returns: true/false depending on the PHY driver's device_set_wakeup_enabled()
+ * Returns: true/false depending on the PHY driver's device_set_wakeup_enable()
* setting if using the driver model, otherwise the legacy determination.
*/
bool phy_may_wakeup(struct phy_device *phydev);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc
2026-09-17 6:30 [PATCH net v2] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc Karl Mehltretter
@ 2026-09-17 12:15 ` Andrew Lunn
2026-09-17 15:42 ` Florian Fainelli
2026-09-19 0:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2026-09-17 12:15 UTC (permalink / raw)
To: Karl Mehltretter
Cc: Heiner Kallweit, Russell King, Jakub Kicinski, Florian Fainelli,
Maxime Chevallier, Russell King (Oracle),
netdev, linux-kernel
On Thu, Sep 17, 2026 at 08:30:51AM +0200, Karl Mehltretter wrote:
> The phy_may_wakeup() documentation refers to
> device_set_wakeup_enabled(), but the function is named
> device_set_wakeup_enable(). Correct the reference.
>
> Fixes: b344bfacf1de ("net: phy: add phy_may_wakeup()")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc
2026-09-17 6:30 [PATCH net v2] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc Karl Mehltretter
2026-09-17 12:15 ` Andrew Lunn
@ 2026-09-17 15:42 ` Florian Fainelli
2026-09-19 0:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2026-09-17 15:42 UTC (permalink / raw)
To: Karl Mehltretter, Andrew Lunn, Heiner Kallweit, Russell King,
Jakub Kicinski, Maxime Chevallier, Russell King (Oracle)
Cc: netdev, linux-kernel
On 9/16/26 23:30, Karl Mehltretter wrote:
> The phy_may_wakeup() documentation refers to
> device_set_wakeup_enabled(), but the function is named
> device_set_wakeup_enable(). Correct the reference.
>
> Fixes: b344bfacf1de ("net: phy: add phy_may_wakeup()")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net v2] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc
2026-09-17 6:30 [PATCH net v2] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc Karl Mehltretter
2026-09-17 12:15 ` Andrew Lunn
2026-09-17 15:42 ` Florian Fainelli
@ 2026-09-19 0:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-19 0:50 UTC (permalink / raw)
To: Karl Mehltretter
Cc: andrew, hkallweit1, linux, kuba, florian.fainelli,
maxime.chevallier, rmk+kernel, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 17 Sep 2026 08:30:51 +0200 you wrote:
> The phy_may_wakeup() documentation refers to
> device_set_wakeup_enabled(), but the function is named
> device_set_wakeup_enable(). Correct the reference.
>
> Fixes: b344bfacf1de ("net: phy: add phy_may_wakeup()")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
>
> [...]
Here is the summary with links:
- [net,v2] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc
https://git.kernel.org/netdev/net-next/c/d4f90143b9ff
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-19 0:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 6:30 [PATCH net v2] net: phy: Fix device_set_wakeup_enable() reference in kernel-doc Karl Mehltretter
2026-09-17 12:15 ` Andrew Lunn
2026-09-17 15:42 ` Florian Fainelli
2026-09-19 0:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®