* [PATCH net-next] net: hibmcge: fix spelling mistakes in comments and identifiers
@ 2026-09-15 13:23 Jijie Shao
2026-09-20 0:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jijie Shao @ 2026-09-15 13:23 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, andrew+netdev, horms
Cc: shenjian15, liuyonglong, chenhao418, yangshuaisong, ningwei15,
netdev, linux-kernel, shaojijie
Fix several typos found in the driver:
- hbg_irq.c: macro parameter "ndde_reset" -> "need_reset"
- hbg_txrx.c: macro "hbg_queue_next_prt" -> "hbg_queue_next_ptr"
(and its call sites)
- hbg_txrx.c: function "hbg_ring_page_pool_destory" ->
"hbg_ring_page_pool_destroy"
- hbg_common.h: comment "after rest" -> "after reset"
- hbg_reg.h: register macro "HBG_REG_BRUST_LENGTH_*" ->
"HBG_REG_BURST_LENGTH_*" (and references in hbg_hw.c)
No functional changes.
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
---
drivers/net/ethernet/hisilicon/hibmcge/hbg_common.h | 2 +-
drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c | 4 ++--
drivers/net/ethernet/hisilicon/hibmcge/hbg_irq.c | 4 ++--
drivers/net/ethernet/hisilicon/hibmcge/hbg_reg.h | 4 ++--
drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c | 12 ++++++------
5 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_common.h b/drivers/net/ethernet/hisilicon/hibmcge/hbg_common.h
index 8e134da3e217..9ca04909774d 100644
--- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_common.h
+++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_common.h
@@ -152,7 +152,7 @@ struct hbg_mac_filter {
bool enabled;
};
-/* saved for restore after rest */
+/* saved for restore after reset */
struct hbg_user_def {
struct ethtool_pauseparam pause_param;
};
diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c
index d6e8ce8e351a..54ed1c17bc2d 100644
--- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c
+++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_hw.c
@@ -190,8 +190,8 @@ void hbg_hw_set_mtu(struct hbg_priv *priv, u16 mtu)
hbg_hw_set_pcu_max_frame_len(priv, frame_len);
hbg_hw_set_mac_max_frame_len(priv, frame_len);
- hbg_reg_write_field(priv, HBG_REG_BRUST_LENGTH_ADDR,
- HBG_REG_BRUST_LENGTH_B, burst_len_bit);
+ hbg_reg_write_field(priv, HBG_REG_BURST_LENGTH_ADDR,
+ HBG_REG_BURST_LENGTH_B, burst_len_bit);
}
void hbg_hw_mac_enable(struct hbg_priv *priv, u32 enable)
diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_irq.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_irq.c
index ae4cb35186d8..2d67c7557b72 100644
--- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_irq.c
+++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_irq.c
@@ -37,9 +37,9 @@ static void hbg_irq_handle_rx_buf_val(struct hbg_priv *priv,
#define HBG_IRQ_I(name, handle) \
{#name, HBG_INT_MSK_##name##_B, false, false, false, handle}
-#define HBG_ERR_IRQ_I(name, need_print, ndde_reset) \
+#define HBG_ERR_IRQ_I(name, need_print, need_reset) \
{#name, HBG_INT_MSK_##name##_B, true, need_print, \
- ndde_reset, hbg_irq_handle_err}
+ need_reset, hbg_irq_handle_err}
static const struct hbg_irq_info hbg_irqs[] = {
HBG_IRQ_I(RX, hbg_irq_handle_rx),
diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_reg.h b/drivers/net/ethernet/hisilicon/hibmcge/hbg_reg.h
index 30b3903c8f2d..0d2554ca3b5f 100644
--- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_reg.h
+++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_reg.h
@@ -191,8 +191,8 @@
#define HBG_REG_TX_CFF_ADDR_2_ADDR (HBG_REG_SGMII_BASE + 0x0490)
#define HBG_REG_TX_CFF_ADDR_3_ADDR (HBG_REG_SGMII_BASE + 0x0494)
#define HBG_REG_RX_CFF_ADDR_ADDR (HBG_REG_SGMII_BASE + 0x04A0)
-#define HBG_REG_BRUST_LENGTH_ADDR (HBG_REG_SGMII_BASE + 0x04C4)
-#define HBG_REG_BRUST_LENGTH_B BIT(29)
+#define HBG_REG_BURST_LENGTH_ADDR (HBG_REG_SGMII_BASE + 0x04C4)
+#define HBG_REG_BURST_LENGTH_B BIT(29)
#define HBG_REG_RX_BUF_SIZE_ADDR (HBG_REG_SGMII_BASE + 0x04E4)
#define HBG_REG_RX_BUF_SIZE_M GENMASK(15, 0)
#define HBG_REG_BUS_CTRL_ADDR (HBG_REG_SGMII_BASE + 0x04E8)
diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c
index 207ada721dd9..2ea025fd964f 100644
--- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c
+++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_txrx.c
@@ -26,10 +26,10 @@
(hbg_queue_used_num((head), (tail), (ring)) == 0)
#define hbg_queue_is_full(head, tail, ring) \
(hbg_queue_left_num((head), (tail), (ring)) == 0)
-#define hbg_queue_next_prt(p, ring) (((p) + 1) % (ring)->len)
+#define hbg_queue_next_ptr(p, ring) (((p) + 1) % (ring)->len)
#define hbg_queue_move_next(p, ring) ({ \
typeof(ring) _ring = (ring); \
- _ring->p = hbg_queue_next_prt(_ring->p, _ring); })
+ _ring->p = hbg_queue_next_ptr(_ring->p, _ring); })
#define hbg_get_page_order(ring) ({ \
typeof(ring) _ring = (ring); \
@@ -167,7 +167,7 @@ netdev_tx_t hbg_net_start_xmit(struct sk_buff *skb, struct net_device *netdev)
/* This smp_store_release() pairs with smp_load_acquire() in
* hbg_napi_tx_recycle() called in tx interrupt handle process.
*/
- smp_store_release(&ring->ntu, hbg_queue_next_prt(ntu, ring));
+ smp_store_release(&ring->ntu, hbg_queue_next_ptr(ntu, ring));
dev_sw_netstats_tx_add(netdev, 1, skb->len);
return NETDEV_TX_OK;
}
@@ -220,7 +220,7 @@ static int hbg_napi_tx_recycle(struct napi_struct *napi, int budget)
break;
hbg_buffer_free(buffer);
- ntc = hbg_queue_next_prt(ntc, ring);
+ ntc = hbg_queue_next_ptr(ntc, ring);
packet_done++;
}
@@ -535,7 +535,7 @@ static int hbg_napi_rx_poll(struct napi_struct *napi, int budget)
return packet_done;
}
-static void hbg_ring_page_pool_destory(struct hbg_ring *ring)
+static void hbg_ring_page_pool_destroy(struct hbg_ring *ring)
{
if (!ring->page_pool)
return;
@@ -589,7 +589,7 @@ static void hbg_ring_uninit(struct hbg_ring *ring)
buffer->priv = NULL;
}
- hbg_ring_page_pool_destory(ring);
+ hbg_ring_page_pool_destroy(ring);
dma_free_coherent(&ring->priv->pdev->dev,
ring->len * sizeof(*ring->queue),
ring->queue, ring->queue_dma);
base-commit: 348ea4642f56ab3dc93621c8e3ab0ccd0e5f1782
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: hibmcge: fix spelling mistakes in comments and identifiers
2026-09-15 13:23 [PATCH net-next] net: hibmcge: fix spelling mistakes in comments and identifiers Jijie Shao
@ 2026-09-20 0:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-20 0:10 UTC (permalink / raw)
To: Jijie Shao
Cc: davem, edumazet, kuba, pabeni, andrew+netdev, horms, shenjian15,
liuyonglong, chenhao418, yangshuaisong, ningwei15, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 15 Sep 2026 21:23:41 +0800 you wrote:
> Fix several typos found in the driver:
>
> - hbg_irq.c: macro parameter "ndde_reset" -> "need_reset"
> - hbg_txrx.c: macro "hbg_queue_next_prt" -> "hbg_queue_next_ptr"
> (and its call sites)
> - hbg_txrx.c: function "hbg_ring_page_pool_destory" ->
> "hbg_ring_page_pool_destroy"
> - hbg_common.h: comment "after rest" -> "after reset"
> - hbg_reg.h: register macro "HBG_REG_BRUST_LENGTH_*" ->
> "HBG_REG_BURST_LENGTH_*" (and references in hbg_hw.c)
>
> [...]
Here is the summary with links:
- [net-next] net: hibmcge: fix spelling mistakes in comments and identifiers
https://git.kernel.org/netdev/net-next/c/5ac134441dc8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-20 0:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-15 13:23 [PATCH net-next] net: hibmcge: fix spelling mistakes in comments and identifiers Jijie Shao
2026-09-20 0:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®