[PATCH] [v2] bpf: add printf attributes

[PATCH] [v2] bpf: add printf attributes

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

Building with extra warnings enabled shows a missing printf attribute:

kernel/bpf/diagnostics.c: In function 'bpf_diag_source':
kernel/bpf/diagnostics.c:828:9: error: function 'bpf_diag_source' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
  828 |         msg = bpf_diag_vfmt(env, fmt, args);

Add these to shut up the warning and allow the compiler to check the
format strings.

Fixes: b9c5d822f677 ("bpf: Add source and instruction diagnostic context")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
v2 changes:
 - only change the one function that needs it
 - fix line wrapping
 - use correct Fixes tag
---
 kernel/bpf/diagnostics.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/bpf/diagnostics.c b/kernel/bpf/diagnostics.c
index a2cac59c6639..48ea3ac23b63 100644
--- a/kernel/bpf/diagnostics.c
+++ b/kernel/bpf/diagnostics.c
@@ -794,8 +794,9 @@ static void diag_print_insn_context(struct bpf_verifier_env *env, u32 insn_idx,
 	}
 }
 
-static void bpf_diag_source(struct bpf_verifier_env *env, u32 insn_idx, const char *label,
-			    const char *fmt, ...)
+static __printf(4, 5) void bpf_diag_source(struct bpf_verifier_env *env,
+					   u32 insn_idx, const char *label,
+					   const char *fmt, ...)
 {
 	struct bpf_diag_scratch *scratch;
 	struct bpf_linfo_source *source_lines;
-- 
2.53.0

Re: [PATCH] [v2] bpf: add printf attributes

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Tue, 15 Sep 2026 23:30:09 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Building with extra warnings enabled shows a missing printf attribute:
> 
> kernel/bpf/diagnostics.c: In function 'bpf_diag_source':
> kernel/bpf/diagnostics.c:828:9: error: function 'bpf_diag_source' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
>   828 |         msg = bpf_diag_vfmt(env, fmt, args);
> 
> [...]

Here is the summary with links:
  - [v2] bpf: add printf attributes
    https://git.kernel.org/bpf/bpf-next/c/7f2b0b57a8d7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html