* [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests
@ 2026-09-17 6:47 Karl Mehltretter
2026-09-18 6:50 ` Daniel Machon
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Karl Mehltretter @ 2026-09-17 6:47 UTC (permalink / raw)
To: Steen Hegelund, Daniel Machon, UNGLinuxDriver
Cc: Karl Mehltretter, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-arm-kernel, netdev,
Geert Uytterhoeven, Brendan Higgins, David Gow, Rae Moar,
linux-kselftest, kunit-dev, linux-kernel
VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
leaves it disabled. Remove the selection, following the dependency rule
in Documentation/dev-tools/kunit/style.rst.
The debugfs implementation and its tests are already built only with
DEBUG_FS. The other VCAP tests can run without it.
Fixes: 552b7d131aa0 ("net: microchip: sparx5: Add VCAP debugfs KUNIT test")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
Validation on net c9151088f167: x86_64 LLVM builds and QEMU runs
with DEBUG_FS disabled and enabled. The other VCAP suites pass in both
configurations. The debugfs suite is present only with DEBUG_FS=y and
all four cases pass.
drivers/net/ethernet/microchip/vcap/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/vcap/Kconfig b/drivers/net/ethernet/microchip/vcap/Kconfig
index 97f43fd4473f..1af30a358a15 100644
--- a/drivers/net/ethernet/microchip/vcap/Kconfig
+++ b/drivers/net/ethernet/microchip/vcap/Kconfig
@@ -40,7 +40,6 @@ config VCAP_KUNIT_TEST
bool "KUnit test for VCAP library" if !KUNIT_ALL_TESTS
depends on KUNIT
depends on KUNIT=y && VCAP=y && y
- select DEBUG_FS
default KUNIT_ALL_TESTS
help
This builds unit tests for the VCAP library.
base-commit: c9151088f1674fd29ff26a20f5fc687acf53a2f0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests
2026-09-17 6:47 [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests Karl Mehltretter
@ 2026-09-18 6:50 ` Daniel Machon
2026-09-21 7:56 ` David Gow
2026-09-21 21:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Daniel Machon @ 2026-09-18 6:50 UTC (permalink / raw)
To: Karl Mehltretter
Cc: Steen Hegelund, UNGLinuxDriver, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-arm-kernel,
netdev, Geert Uytterhoeven, Brendan Higgins, David Gow, Rae Moar,
linux-kselftest, kunit-dev, linux-kernel
> VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
> leaves it disabled. Remove the selection, following the dependency rule
> in Documentation/dev-tools/kunit/style.rst.
>
> The debugfs implementation and its tests are already built only with
> DEBUG_FS. The other VCAP tests can run without it.
>
> Fixes: 552b7d131aa0 ("net: microchip: sparx5: Add VCAP debugfs KUNIT test")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Validation on net c9151088f167: x86_64 LLVM builds and QEMU runs
> with DEBUG_FS disabled and enabled. The other VCAP suites pass in both
> configurations. The debugfs suite is present only with DEBUG_FS=y and
> all four cases pass.
>
> drivers/net/ethernet/microchip/vcap/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/microchip/vcap/Kconfig b/drivers/net/ethernet/microchip/vcap/Kconfig
> index 97f43fd4473f..1af30a358a15 100644
> --- a/drivers/net/ethernet/microchip/vcap/Kconfig
> +++ b/drivers/net/ethernet/microchip/vcap/Kconfig
> @@ -40,7 +40,6 @@ config VCAP_KUNIT_TEST
> bool "KUnit test for VCAP library" if !KUNIT_ALL_TESTS
> depends on KUNIT
> depends on KUNIT=y && VCAP=y && y
> - select DEBUG_FS
> default KUNIT_ALL_TESTS
> help
> This builds unit tests for the VCAP library.
>
> base-commit: c9151088f1674fd29ff26a20f5fc687acf53a2f0
Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests
2026-09-17 6:47 [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests Karl Mehltretter
2026-09-18 6:50 ` Daniel Machon
@ 2026-09-21 7:56 ` David Gow
2026-09-21 21:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: David Gow @ 2026-09-21 7:56 UTC (permalink / raw)
To: Karl Mehltretter, Steen Hegelund, Daniel Machon, UNGLinuxDriver
Cc: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-arm-kernel, netdev, Geert Uytterhoeven,
Brendan Higgins, Rae Moar, linux-kselftest, kunit-dev,
linux-kernel
Le 17/09/2026 à 14:47, Karl Mehltretter a écrit :
> VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
> leaves it disabled. Remove the selection, following the dependency rule
> in Documentation/dev-tools/kunit/style.rst.
>
> The debugfs implementation and its tests are already built only with
> DEBUG_FS. The other VCAP tests can run without it.
>
> Fixes: 552b7d131aa0 ("net: microchip: sparx5: Add VCAP debugfs KUNIT test")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Validation on net c9151088f167: x86_64 LLVM builds and QEMU runs
> with DEBUG_FS disabled and enabled. The other VCAP suites pass in both
> configurations. The debugfs suite is present only with DEBUG_FS=y and
> all four cases pass.
>
Acked-by: David Gow <david@davidgow.net>
Cheers,
-- David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests
2026-09-17 6:47 [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests Karl Mehltretter
2026-09-18 6:50 ` Daniel Machon
2026-09-21 7:56 ` David Gow
@ 2026-09-21 21:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-21 21:20 UTC (permalink / raw)
To: Karl Mehltretter
Cc: Steen.Hegelund, daniel.machon, UNGLinuxDriver, andrew+netdev,
davem, edumazet, kuba, pabeni, linux-arm-kernel, netdev, geert,
brendan.higgins, david, raemoar63, linux-kselftest, kunit-dev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 17 Sep 2026 08:47:36 +0200 you wrote:
> VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
> leaves it disabled. Remove the selection, following the dependency rule
> in Documentation/dev-tools/kunit/style.rst.
>
> The debugfs implementation and its tests are already built only with
> DEBUG_FS. The other VCAP tests can run without it.
>
> [...]
Here is the summary with links:
- [net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests
https://git.kernel.org/netdev/net-next/c/2fba93180872
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-21 22:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-17 6:47 [PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests Karl Mehltretter
2026-09-18 6:50 ` Daniel Machon
2026-09-21 7:56 ` David Gow
2026-09-21 21:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®