mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH net v2] net: alacritech: publish the PCI module aliases
@ 2026-09-20  3:46 Pengpeng Hou
  2026-09-22  0:30 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Pengpeng Hou @ 2026-09-20  3:46 UTC (permalink / raw)
  To: linosanfilippo
  Cc: andrew+netdev, davem, edumazet, kuba, pabeni, netdev,
	linux-kernel, horms, richardcochran, hppiscas

The SLIC driver has a PCI ID table connected to its pci_driver, but does
not export it. Its module therefore lacks the PCI aliases used to
automatically load it for the supported Alacritech adapters.

Export the existing PCI table without changing device matching.

The issue was found by our static-analysis tool.

Fixes: 60c140df15db ("net: ethernet: slicoss: add slicoss gigabit ethernet driver")
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Assisted-by: gpt 5
Signed-off-by: Pengpeng Hou <hppiscas@163.com>
---
Changes since v1:
https://lore.kernel.org/all/20260704152053.49780-1-pengpeng@iscas.ac.cn/
Rewrite the source-analysis explanation as requested by Jakub; retain
the one-line change reviewed by Simon and Lino.

 drivers/net/ethernet/alacritech/slicoss.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
index c1949ca060ca..14b74c09233e 100644
--- a/drivers/net/ethernet/alacritech/slicoss.c
+++ b/drivers/net/ethernet/alacritech/slicoss.c
@@ -34,6 +34,7 @@ static const struct pci_device_id slic_id_tbl[] = {
 		     PCI_DEVICE_ID_ALACRITECH_OASIS) },
 	{ 0 }
 };
+MODULE_DEVICE_TABLE(pci, slic_id_tbl);
 
 static const char slic_stats_strings[][ETH_GSTRING_LEN] = {
 	"rx_packets",

base-commit: 518e5b794c06c0f0eb40df3e202274a66202c137
-- 
2.50.1 (Apple Git-155)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH net v2] net: alacritech: publish the PCI module aliases
  2026-09-20  3:46 [PATCH net v2] net: alacritech: publish the PCI module aliases Pengpeng Hou
@ 2026-09-22  0:30 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-09-22  0:30 UTC (permalink / raw)
  To: Pengpeng Hou
  Cc: linosanfilippo, andrew+netdev, davem, edumazet, kuba, pabeni,
	netdev, linux-kernel, horms, richardcochran

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 20 Sep 2026 11:46:51 +0800 you wrote:
> The SLIC driver has a PCI ID table connected to its pci_driver, but does
> not export it. Its module therefore lacks the PCI aliases used to
> automatically load it for the supported Alacritech adapters.
> 
> Export the existing PCI table without changing device matching.
> 
> The issue was found by our static-analysis tool.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: alacritech: publish the PCI module aliases
    https://git.kernel.org/netdev/net-next/c/4d68b3483721

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-22  0:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-20  3:46 [PATCH net v2] net: alacritech: publish the PCI module aliases Pengpeng Hou
2026-09-22  0:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®