Re: [PATCH net 1/8] net: bcmgenet: fix 64-bit RTNL stats reading in ethtool on 32-bit systems

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 1 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] The commit message of "net: bcmgenet: fix 64-bit RTNL stats
  reading in ethtool on 32-bit systems" has no Signed-off-by: line, so…

--

net: bcmgenet: fix 64-bit RTNL stats reading in ethtool on 32-bit systems

This changes the width test in bcmgenet_get_ethtool_stats() from a check
against sizeof(unsigned long) to a check against sizeof(u64), so that
STAT_RTNL entries pointing into struct rtnl_link_stats64 are read as
64-bit values on 32-bit architectures too.

No Link: tags are present in the commit header.

The code change itself looks fine; my only comments are about the trailer
block of the commit message:

>     Fixes: 59aa6e3072aa ("net: bcmgenet: switch to use 64bit statistics")
>     Assisted-by: LLM
>     Co-authored-by: Cursor <cursoragent@cursor.com>
>     Change-Id: I3e9f2f8d4fd136392148d6c0cd4eb40f7ccbe4ef

[Severity: Medium]
There is no Signed-off-by: line in this commit, so the Developer's
Certificate of Origin chain described in
Documentation/process/submitting-patches.rst is missing.  Can this be
applied as posted, or does it need a respin with a Signed-off-by: from the
author?

The remaining trailers also look unusual for an upstream posting:

  - Change-Id: I3e9f2f8d4fd136392148d6c0cd4eb40f7ccbe4ef is a Gerrit-internal
    identifier and is normally stripped before submission.
  - Assisted-by: LLM is not a trailer the kernel uses.
  - Co-authored-by: Cursor <cursoragent@cursor.com> does not match the
    kernel convention, which is Co-developed-by: immediately followed by
    that co-developer's own Signed-off-by:.  Can an agent address provide
    such a sign-off?

The same trailer block, with no Signed-off-by:, appears in all eight commits
of the series range 46bc52d1..e6810d7c, so no later patch in the series
corrects it.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260918000732.276506-1-florian.fainelli%40broadcom.com